171 Commits

Include renames

Author	SHA1	Message	Date
leonarski_fandClaude Opus 5	daac3c2da1	rugnux: report nine resolution shells, as XDS does ... The binning rule was already XDS's: equal steps in 1/d^2 between the lowest- and the highest-resolution reflection the merge kept, anchored on the data rather than on the nominal low-resolution cut. Only the count differed - ten shells against XDS's nine - so at the same resolution limits neither the boundaries nor the reflection populations matched, and a per-shell number could not be read across. Forced to nine on a tetragonal rotation dataset, rugnux now gives 4.27 3.03 2.47 2.14 1.92 1.75 1.62 1.52 1.43 against CORRECT.LP's 4.26 3.02 2.47 2.14 1.92 1.75 1.62 1.52 1.43; the hundredth of an angstrom in the first two shells is each program anchoring on its own lowest-resolution reflection, the two sets of survivors not being identical. This matters most to the comparisons that are made shell by shell. rugnux_vs_xds.py hands XDS's resolution range to rugnux but not its shell count, so its low-resolution R_meas column compared a shell running to 4.49 A against one running to 4.26 A - 814 unique reflections against 943. The outer shell was nearly immune, its inner edge being d_min*sqrt(n/(n-1)), which is 1.51 at ten shells and 1.52 at nine. --resolution-shells still sets any count. rugnux_stills_ab.py pins the count for both its arms and now pins nine, so its tables read the same way as everything else. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vi1gV6Z45aZL5wLwe85Ksn	2026-08-26 20:24:34 +02:00
leonarski_fandClaude Opus 5	f7cb701f43	rugnux: let --model settle the indexing of the reflections it writes ... ValidateAgainstModel was called after WriteReflections, so the two relabelings it makes - the change of hand where the data were merged in the model's enantiomorph, and the alternative indexing it picks by R-free where no reference MTZ had already fixed it - reached the R-factors, the maps and _maps.mtz and nothing else. The .mtz/.cif/.hkl beside them kept whichever indexing the merge happened to land in, so a file whose maps came from a model could not be refined against that model without being reindexed first. Validation now runs before the reflection files are written and returns the operators it applied. AdoptModelFrame puts the merged reflections through them with a proper ASU reduction - ReindexReflections only relabels, which is all its scoring callers need - and the Bijvoet halves follow the Friedel sign of that reduction. The integrated observations are relabelled too, so --export-unmerged describes the same indexing as the merged files rather than a second one. change_of_hand_op is the inversion, so adopting a model's hand exchanges I(+) and I(-). On a tetragonal crystal whose enantiomorphic pair share their whole absence pattern, the search picks one of the two arbitrarily, and the exported anomalous differences were the wrong way round whenever it picked the other member from the model's. The written space group follows the hand, and so does the report that describes those files. The _process.h5 is deliberately left alone: its per-image reflections went to disk as they were integrated, and recording a group that did not match them would mis-merge on a later --mode scale. Nothing is lost - an enantiomorphic pair has the same Laue class and the same absences, so it merges identically either way. Serial stills could not use a model for this at all: each crystal is indexed in its own hand, so by the time there is a merge to fit a model to, the hands have already been averaged together, and reindexing the merged result as a whole cannot separate them again. ModelReferenceIntensities computes |F_model|^2 from the structure - Fcalc plus a flat solvent term at the standard constants, which are not fitted because there are no observations yet - and hands it to the per-image resolver that a reference MTZ already drove. It needs the cell and the group up front, which serial indexing wants anyway. Measured on a serial dataset in a merohedral trigonal group, at a fixed resolution limit so the shells match: CC1/2 better in 8 of 10 shells (79.7 to 82.5 overall), R_meas better in 9 of 10 (111.1 to 104.7), ISa 1.11 to 1.20, and R-free against a structure the merge never saw 0.393 to 0.375. The ambiguity probe now logs the runner-up R-free as well as the winner. On the same data the margin is 0.016 when the hands are mixed, where the two global indexings are tied because both are already inside every reflection, and 0.193 once they are not - the difference between a decision and a coin toss, which the old single number hid. The warning about an unresolved ambiguity no longer fires when a model will resolve it, and names the flags that would; and the summary line no longer offers the adopted group as its own alternative, which it did once --model had moved the run onto the member the search had listed as the alternative. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vi1gV6Z45aZL5wLwe85Ksn	2026-08-26 20:04:02 +02:00
leonarski_fandClaude Opus 5	abb61e2708	Unmerged export: carry the sort key with the part here too ... SumRockingEvents assembles rocking events for the unmerged MTZ through the same indirect comparator the anisotropy diagnostic had, on a larger array - it has neither the scaled-image test nor the usable() filter in front of it. It is latent, since --export-unmerged is off by default, but it is the same defect and it is a mechanical fix. Same treatment: the key travels with the part, plus an exact reserve. p_unmerged.mtz, p_unmerged_partials.mtz and p.hkl are md5-identical across eight runs on two crystals. With the export on it is worth about 0.9 s on a seventeen-million-partial run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-26 14:11:56 +02:00
leonarski_fandClaude Opus 5	0e6ece3c38	Anisotropy: assemble only the reflections the floor actually reads ... BuildObservationCells strides whole ASU clusters down to MAX_CLUSTERS = 20000 and keeps 1.4% of what it is handed - so the assembly before it sorted and summed every integrated partial in the sweep to throw 98.6% of the result away on the next line. The comment there says the striding "costs nothing and bounds the work"; it bounded it after the expensive part. Sample first instead: keep a partial iff a splitmix64 hash of its ASU key falls in the low one part in 2^n. Whole ASU clusters are mandatory rather than convenient - the cluster-robust sandwich sums one score per cluster, and the forbidden-direction signal IS the contrast between mates, so a raw-hkl sample would collapse that onto the independent covariance and inflate the floor. The hash rather than the key matters too: HKLKey::pack puts h in the low bits, so masking the key directly would select lattice planes instead of a sample. The rate comes from the partial count, not from merged.size(): the merged list is resolution-cut, and taking the rate from it made the first version never fire at all on the crystal it was written for. One part in 2^n of the partials is one unique reflection in 2^n, so the count already computed for the reserve is the right one. DELTA_B is unchanged by construction, not by luck. AnalyzeAnisotropy touches the unmerged observations in exactly two places - an empty test and MeasureSystematicFloor - so the tensor, the shape verdict and the directional limits come from the merged list alone. Over the battery: 0 verdict flips of 38; DELTA_B, DELTA_B_LINEAR, SHAPE, FREE_DIRECTIONS and the D_MIN keys differ on none of the 38, byte-identical rather than within noise; every reported key identical on 26; the mmCIF diff is exactly _reflns.jfjoch_aniso_floor and _significance; no caution appears or disappears anywhere. The spread those two keys move within was measured rather than assumed, and re-running cannot measure it because the code is deterministic. The shipped code already samples - by striding cluster order - so moving the phase of its own stride gives the sampling spread it has always carried. Against that control the change moves the floor less: ratio range 0.803-1.481 against 0.497-1.343, geomean 1.031 against 0.941. The gate therefore did not get easier to trip - the floor's geomean moves +3.1% here against -5.9% for the phase control, the crystal nearest the gate is not sampled at all and is bit-identical, and the two sampled crystals nearest the gate both move away from it. N_OBSERVATIONS goes up, not down, because a smaller pool lands the downstream integer stride slightly above the cluster cap. The ASU reduction is 14-45 ns a call in isolation, which nearly sank the design; in place it is free, because it overlaps the memory stalls of the Reflection stream it walks. The 24 crystals below the sampling cap run the shipped algorithm plus the reduction and cost +1.79 s in total, median +0.04 s. The block that introduced this measures 8.07 s before and 1.97 s after, which is 5.74 s off the largest crystal (-12.3%) and -11.9 s of anisotropy time over the battery. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-26 14:11:56 +02:00
leonarski_fandClaude Opus 5	e332aaf28c	Space-group search: read the presence cut on counting significance ... present_i_over_sigma is meant to say "this reflection is really there". The merged I/sigma is not that quantity. The merge carries the error model's intensity-proportional term, sigma^2 = a*sigma0^2 + (b*I)^2, so I/sigma saturates - at ISa*sqrt(n) for a reflection observed n times, and at ISa exactly for one observed once. Above that knee it stops rising with the intensity. Measured over the battery's 76 search merges: the median I/sigma of the top E^2 decile sits at 0.81 of ISa, and on the weakest merge the decile profile reads 1.58 1.61 1.63 1.64 1.64 1.65 1.65 against an ISa of 1.70 - flat to three digits, log-log slope against E^2 of 0.008. Reflections an order of magnitude apart in real intensity read the same number. So one constant demands between 2.16 and 11.91 in counting significance depending on the crystal, and the fraction of a merge clearing it runs from 3.1% to 98.8%. Convert it once instead. For a reflection observed once sigma_counting^2 = sigma^2 - (b*I)^2, so I/sigma_counting >= T is exactly t >= T/sqrt(1+(T/ISa)^2). That cut lies strictly below ISa for every ISa, so it is always reachable by the reflection the ceiling binds hardest, and it is within 1% of T on any merge with ISa >= 21, so a healthy merge is left where it was. Multiplicity is taken as 1 deliberately rather than estimated, for the same reason. The quantile fallback goes with it. Its comment claimed to be inert on the battery; it fires on 4 of 76 arms, and on one of them it relaxes the cut BELOW the nominal value because that merge is bimodal. A cap on a statistic is not a substitute for measuring the right statistic. Two comments in the tree still described a merged sigma floored at b|I|, removed in 72efb75a8 before rc-161. Both corrected; that stale claim is what made this look like a different bug. Battery, both arms, against a control floor of exactly zero: space groups 35/38 before and after, the same three crystals differing from the reference, all 380 shells identical and all 38 merged mmCIFs byte-identical. It is live rather than dead code - the pass_cc population moves on 45 of 47 arms and 212 of 314 operator correlations move, with 0 of 314 verdicts changed. The weakest crystal's single 2-fold goes from CC 0.489 on 1131 pairs to 0.597 on 4822, widening its margin over the threshold by 57%. Two things this does not fix, both quantified in the work behind it. The conversion is monotone, so it corrects the threshold but cannot restore the ranking the (b*I)^2 term already destroyed - that needs a counting-only merged sigma and touches the CUDA merge kernel. And one crystal's gate still admits 98.8% of its merge with a slope of 0.037, discriminating nothing; the instrument for that is E^2, which needs min_operator_cc re-derived first. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-26 12:43:04 +02:00
leonarski_fandClaude Opus 5	278f8e3d73	Anisotropy: carry the sort key with the part, as the merge's ingest does ... ScaledObservations assembles every integrated partial into rocking events before the tensor is fitted, and sorted them through a pointer. On the largest sweep that is 29.1 million parts spread over about 2.5 GB of 88-byte records against a 32 MB L3, and the comparator dereferenced one of those pointers on every one of roughly 660 million comparisons. Single-threaded, once per run, at the end of a run whose image loop uses sixteen threads and a GPU - and for a diagnostic that corrects no intensity and removes no reflection. It was 8% of one run, 12%, 15% and 16% of others, and 19% of the largest. The fix is the idiom this repository already uses for this exact sort: RotationScaleMerge's ingest sorts the same partials on the same key through a narrow record and its header says why. ScaledObservations was the one place that read the key back through the pointer instead. The key now travels with the part. Twelve lines, no bit-packing, and a reserve of the upper bound so the growth chain stops copying a few hundred megabytes on a large sweep. Ties are real and had to be handled rather than argued away: the predictor emits both Ewald intersections and near the blind region both land on the same frame, so one crystal has 7424 tied adjacent pairs, 3778 of them in reverse arrival order. The comparator keeps the same four values in the same order, so introsort - whose every branch is decided by comparator outcomes at positions and never by element size - makes the same comparisons and the same swaps and leaves the same permutation. Checked rather than asserted: a hash of the sorted permutation of all 29.1 million parts, a hash of the returned vector's raw bytes, and the md5 of the whole .cif all match on eight crystals, each first run twice on the baseline as a determinism control. The sort is 1.7-2.1x faster and the function 1.5-2.0x, which is 6.7 s of single-threaded critical path over those eight crystals and 10.8% of total wall clock over six timed warm and interleaved. A wider element costs 7% in the grouping pass that follows. A 24-byte variant that indexes back instead was built and is marginally faster to sort and slower overall, so the plainest version is also the fastest. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-26 11:35:34 +02:00
leonarski_fandClaude Opus 5	d987bd6178	Space-group search: record what the E^2 shell count does on a small merge ... The shell count is order.size() / 100 in integer arithmetic, so a merge of fewer than two hundred reflections gets a single shell and E^2 becomes I divided by one global mean. That is harmless for the thing E^2 was introduced for - the operator correlation is a Pearson coefficient and is invariant to a common scale, so it lands on exactly the value raw I would have given. It is not harmless for the overlap cap, which then rejects reflections by their intensity against the whole merge rather than against their own resolution shell, and so cuts the low-resolution end and spares the high. No behaviour change; a merge that small has already failed for other reasons. This is here so the next reader does not have to rediscover that the normalisation quietly switches off at the bottom of the range. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-26 10:29:58 +02:00
leonarski_fandClaude Opus 5	64957d5a5f	Space-group search: record what min_pairs_per_operator is actually worth ... Comment only; the constant stays at 20. f6bfa5462 moved min_operator_cc to 0.30, which is close enough to the null of a sparse operator that the pair minimum deserved measuring rather than assuming. Measured, over 38 crystals and 142 (crystal, pair-count) points, the null of the normalised operator correlation has mean -0.02 to +0.05 and standard deviation 1.08/sqrt(n), flat from 20 pairs to 5000. Its tail is the part worth writing down: log10 P(null CC >= 0.30) = -1.03 z + 0.69, residual sd 0.14 decades One decade per standard deviation, where normal theory gives about five. So a false operator at 20 pairs clears 0.30 on 12.4% of draws, and any calibration of this gate that reasons from 1/sqrt(n-3) with a normal or Fisher-z tail is optimistic by one to two orders of magnitude. It does not bite where the decision is made. Over 314 candidate operators on 36 crystals the sparsest has 520 pairs and none is below 500; the weakest confirmed operator sits 9.1 sigma above its own null and the strongest rejected one 42.7 sigma above. Nothing passes on noise. The search's own <I/sigma> cut is what keeps that null flat - reconstructing the same crystals from an unfiltered merge reproduces a null floor of 0.10 to 0.20, which is where the "false CC rises at low pair count" impression came from. That describes a shrinking merge, not a sparse operator. A minimum of 251 pairs would buy a per-operator false rate of 1e-3. It was built and rejected on measurement: SearchSpaceGroup runs twice, once on all observations, which decides, and once on a Lorentz-filtered merge, which only reports - and no log prints the second arm's pair counts. Genuine operators fall to 98 pairs there, so a floor of 251 empties a conjugacy class on one crystal and makes the report say its filtered merge supports triclinic, about a merge whose own correlations put every one of those operators 9 sigma clear at 0.91 to 0.97. Any floor above about 150 does that; any below about 103 is barely better than 20. A count floor rejects on pair count however decisive the correlation is, which is why the shape is wrong rather than the value. The comment records the law, the rejected value, and the form that would work if this is ever revisited - a significance floor rather than a count floor. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-26 01:44:32 +02:00
leonarski_fandClaude Opus 5	f6bfa54624	Space-group search: score operators on normalised intensities ... Symmetry operators were scored by Pearson correlation on raw merged intensities. Both members of a symmetry pair sit at the same |s|, so the resolution fall-off is variance the two arms share exactly, and it inflates the correlation of true and false operators alike. The clearest demonstration is the test this commit adds: a synthetic data set with no symmetry at all - a radial fall-off times an independent per- reflection factor - is assigned point group 432 by the shipped code, with all 23 rotations confirmed at 0.632 to 0.656. The existing suite passes identically before and after, because nothing covered this. The new case fails 64 of its 100 assertions on the old scoring and passes on the new. On real data the same effect had the gate leaking: on one cubic crystal three pseudo-symmetric operators scored 0.506 to 0.517, above the 0.5 bound, so they were confirmed and 432 had to be refused further downstream by the twin-law and systematic-b guards. Scored on E-squared they read 0.283 to 0.298 and exactly the eleven genuine rotations of 23 are confirmed. The normalisation has to be over the reflections the correlation actually pairs. Reusing the existing normalised array is worse than doing nothing: it is normalised over the set the absence tests use, whose surviving fraction is itself resolution-dependent, and the coupling to the resolution cut rises from 0.086 to 0.262 against a raw baseline of 0.086. Normalised over the paired set it falls to 0.023. The twin-law H statistic keeps its own vectors on raw intensities. It shares the pair arrays with the correlation, and normalising in place moves it by up to 12% against a bound whose window is 5.5% wide. Verified rather than assumed: two instrumented binaries print the same H to twelve significant figures while the correlation differs. min_operator_cc goes 0.5 to 0.30. Normalised correlations run lower, and the observed window on rugnux's own search merges is 0.298 to 0.351; 0.35 is too high, because one crystal's weakest genuine operator reads 0.351. The headroom between a crystal's weakest true operator and its own measured false -operator floor widens on 14 of 14 crystals, median 0.430 to 0.619, and the worst operational margin goes from 0.031 to 0.051. Battery, twice, against a baseline reproducible to zero: the space group is identical on all 38 crystals, per-shell merging is 0 better and 0 worse across all 380 shells, and the merged mmCIF is byte-identical on 38 of 38 - on the 12 crystals whose integration radius now adapts as well as the 25 that do not. The arm is live rather than inert: all 313 operator correlations move while every pair count and every H value stays bit-identical, and on one cubic crystal three operators that raw intensities confirmed are rejected, with the space group unchanged. Following Padilla and Yeates (2003) Acta Cryst. D59, 1124-1130 for why a resolution-normalised statistic is the right one for a symmetry test. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-26 00:27:13 +02:00
leonarski_fandClaude Opus 5	4e6eb18d93	Integration: fall back to the fixed radius on a pattern too dense for it ... 48008e144 widens the signal radius on crystals with wide spots. On one battery crystal - simultaneously the widest-spot and among the highest in mosaicity - the wider radius left its neighbours' background rings with too few clean pixels and cost 28.5% of its observations. Pass 1 now measures how often that happens and, above a bound, hands pass 2 the settings from before the pre-scan widened them. The obvious quantity does not work. On the total rate of reflections dropped for a starved ring, the losing crystal reads 4.08% and the rule's four biggest winners read 1.89-2.04% - and a crystal at the shipped radius reads 2.37%, above all of them. Re-running the winners at r1 = 4 shows why: they read 2.20-2.32% there too, and widening moves them down. That floor is module gaps, the beam stop and the resolution mask, which are properties of the detector and do not move with the radius. So the counter separates the two. A ring is neighbour-starved when it would have kept more than five pixels but for the pixels a neighbouring reflection's signal region occupies. That is exact rather than estimated: the reflection mask marks the disk inside r2 and the ring is everything outside it, so a masked ring pixel always belongs to some other reflection's core. The separation goes from a factor of 2 to a factor of 13 - over the twelve crystals the radius moves, the rate is 0.000 five times, 0.001 three times, then 0.004, 0.235, 0.315 and 4.082 - and the bound is the log-space midpoint of that one gap, 0.0113, a factor 3.6 clear of the nearest measurement on either side. Predicted reflection spacing does not separate them at all: the losing crystal is 19th of 38, a winner sits at 21.9 px, and the loosest pattern in the battery starves 1.93% of its rings. Battery: the space group is identical on all 38 and the merged .hkl is byte-identical on 37, so it is inert wherever it does not fire. On the one crystal it fires on, <I/sigma> is up 18.3%, R_meas down 29.4%, observations up 6.3%, CC1/2 0.944 to 0.974, and its two empty top shells come back as numbers. Its indexing rate, refined distance, beam centre and cell are bit-identical between the two arms, so this is the guard and not the two-pass gate. The counters are a shared channel through both engines, summed across workers and logged once per pass; on the GPU it is one atomic add per dropped reflection. The profile-fit runaway guard reports on the same channel, which is the first measurement of its trip rate. This does not recover that crystal fully. With the adaptive radius on, pass 1 reaches a different lattice and pass 2 indexes 21% fewer frames - which happens before the measurement this guard reads exists, and is unaffected by it. At matched indexing rate the guard recovers 96% of the baseline's observations against 90.5% without it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-26 00:20:41 +02:00
leonarski_fandClaude Opus 5	0da593b32a	Anisotropy: say what was measured, and stop crying wolf ... Four reporting changes and a restored changelog line. The gate boundaries are unchanged - see below - and no merged number moves: .mtz and .hkl are byte-identical on two crystals, and REPORT_VERSION stays 3 because everything here is an added key or prose. A directional diffraction limit that is really the edge of the measured data was printed as if it were the crystal's. One crystal reported 1.09 / 0.99 / 0.99 A against a 0.994 A cutoff, so two of its three limits were the cutoff. A censored limit now prints with a "<" and sets ANISOTROPY_D_MIN_CENSORED. It fires on 4 of 28 crystals, and on two of those all three limits are censored, which means their reported directional spread was binning noise. The caution about a too-high symmetry assignment fired on every crystal with one deviatoric degree of freedom - every tetragonal, trigonal and hexagonal case, 17 of 38. A caution that fires on 45% of runs is noise. It is now conditional on the signature that actually indicates it, a large symmetry-forbidden signal with a gate that established nothing, and fires on 2 of 38: the crystal already on record as space-group unstable, and one other. The forbidden-direction z is now reported so the reader can see it; its battery median is 6.5. The verdict line quoted deltaB_linear while the headline reported deltaB, and the two differ - deltaB_linear is the larger on 12 of 31 crystals. It now writes out the arithmetic, says which number the gate tests, and says which to act on. The observation count the floor was measured on is reported, and the mmCIF verdict item carries its vocabulary like its neighbours. On the boundaries: they were calibrated against XDS-derived unmerged data, while production measures the floor from rugnux's own observations, and those disagree by 0.12x to 16.2x with 7 of 29 verdicts flipping. Re-measured on production input - by merging each cubic crystal in proper subgroups of its own Laue class, where the true anisotropy is exactly zero and every deltaB that comes back is manufactured - the false-positive rate is 24% at 2.0, 10% at 3.5 and 5% at 5.0. Each sits inside the published band read as its worst-case figure rather than its average. 3.5 maximises power minus false-positive rate across the grid; moving to 4.0 costs a real detection and reduces the false-positive rate by nothing. So the boundaries stay, and the "strong" band at 5.0 is a 5% statement on real data rather than the 0.5% its derivation suggested. The changelog entry for the diagnostic itself was committed with only its first line, having been extracted by a script that took one line of a four-line bullet. Restored. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-25 23:56:08 +02:00
leonarski_fandClaude Opus 5	3175e65400	Space-group search: say what it tested, and what it could not ... Three reporting changes. None of them touches a decision: the merged .mtz, .hkl, .cif and _image.dat are byte-identical before and after on two test crystals, and the space group and cell are unchanged. REPORT_VERSION moves to 3 and one warning appears where the second change is working. The alternatives line was misleading. "Best space group: C2 or P21 or P2 (indistinguishable from these data)" sat forty lines below the run's single cell, which is C2's. P2 and P21 are primitive: their lattice is a sub-lattice of that one, their cell has half its volume, and their indices are not the ones in the written files. A user acting on "P21" got a group name with no cell, beside a cell belonging to a different group, with nothing saying so. The report now names the alternatives whose centring differs from the chosen group's, gives the volume ratio of the cell each implies, and says that adopting one means reindexing. It stays byte-identical when every alternative shares the chosen centring, which is every other case that occurs - the enantiomorphic and origin-ambiguous pairs, where one cell really does describe them all. It does not print derived cell constants: the primitive cell of a C-centred monoclinic is not P2's conventional cell, and deriving that is a reduction plus a per-group setting choice, which is more than a report line should carry. A centring the data could not test now says so. Prediction runs in P so the search can confirm a centring from the reflections it extinguishes, but when the indexer returns the primitive sub-cell those reflections are never predicted, and an absent count of 0 reads as "predicts no absences" when it means "none was measured". The search abstains correctly and the centring is then taken from the metric, but none of that reached the user. The candidate table gains a three-valued centring column and the report raises a warning where the metric decides it. No decision logic changed - the flag is two counts the search had already made, and nothing reads it back. The twin-law H is now reported for every operator, and the adopted promotion's ratio against its bound. It was previously visible only inside a refusal message, which is why recalibrating that bound recently required rebuilding the statistic from reference data rather than reading it out of runs we already had. The ratio is reported at the Stage A promotion where it is computed, not in the Stage B table, whose rows all share one point group and would have printed the same number on every line. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-25 21:04:12 +02:00
leonarski_fandClaude Opus 5	491312f263	Fix the packaging split where it was only exercised on one configuration ... Three failures, all from validating the rugnux path alone and assuming the rest followed. viewer/CMakeLists.txt had an unbalanced ENDIF: removing the cuFFT bundling block took its opening IF(JFJOCH_CUDA_AVAILABLE) with it and left the closer behind, so every configuration that adds viewer/ died on "flow control statements are not properly nested" -- both Windows jobs and the viewer tarball. The cross toolchain could not find Eigen. CMAKE_FIND_ROOT_PATH_MODE_PACKAGE ONLY confines find_package to the target roots, and the ubuntu2404 image installs Eigen from source in /opt/eigen-3.4 rather than as libeigen3-dev, so it sat outside them. It is header-only, so serving it from outside the target roots is safe; the root is now listed explicitly. Static cuFFT is not available everywhere. The Windows toolkit ships no cufft_static.lib, so CUDA::cufft_static does not exist there and linking it fails at generate time. Condition on the target rather than the platform, so a toolkit that gains or loses the static library needs no further change, and restore the Windows DLL bundling for both products -- now in the top-level CMakeLists, since rugnux needs it too and does not add viewer/. rugnux.exe therefore ships beside cufft64_*.dll rather than alone; the Linux and cross artifacts are still one file. That condition also has to keep the JFJOCH_PORTABLE_ONLY half. Testing only for the target quietly moved the SERVER build onto static cuFFT as well, where every executable -- broker, tests, tools -- would then need the CUDA device-link step and would fail on an undefined __cudaRegisterLinkedBinary_* at link. Configure still succeeds, so nothing catches that until the link; the server build keeps libcufft.so exactly as before. Checked by configuring all four flavours in the image CI actually uses -- rugnux, viewer and server on x86_64 plus the aarch64 cross -- and confirming each links the cuFFT it should. The rugnux archives now also carry their target architecture, since that build produces more than one: rugnux-<version>-linux-x86_64-cuda13.tar.gz beside the aarch64 one. CMAKE_SYSTEM_PROCESSOR is the target's, never the build host's. The viewer is x86_64-only and keeps its existing name. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQjneRUssfhi1k9rq8Ts3h	2026-08-25 20:53:49 +02:00
leonarski_fandClaude Opus 5	8d32024dd1	Ship jfjoch_viewer and rugnux as two packages, and cross-build rugnux for arm64 ... The viewer tarball also carried rugnux, jfjoch_extract_hkl and jfjoch_recompress. A GUI download that contains a batch processor is confusing on its own, and it forced anyone who only wanted rugnux to take Qt with it. JFJOCH_RUGNUX_ONLY is the viewer-only subtree minus viewer/ and tools/, so it needs no Qt at all, and each of the two options now yields one artifact holding one program: JFJOCH_VIEWER_ONLY jfjoch_viewer .tar.gz / installer / .dmg JFJOCH_RUGNUX_ONLY rugnux .tar.gz / .zip The two CLI tools are still built and no longer installed anywhere. rugnux gets a CPack component of its own, so its notices land in share/doc/jfjoch_rugnux. What makes the split possible is linking cuFFT statically in both products. It was the only CUDA component still dynamic - cudart and the fast-feedback indexer were already static - and shipping it as a .so meant each self-contained archive had to carry the library beside its executables and find it again through an $ORIGIN rpath. That rpath was set on jfjoch_viewer alone, while the same tarball installed three more executables, so those shipped with no runpath at all (cmake strips the build-tree one, which points at the build host's CUDA directory) and could not load the libcufft lying next to them. Static, an artifact is one file that runs: the x86_64 rugnux tarball needs only libc, libstdc++, libgcc_s, libm, libpthread, librt and libdl. The bundling code and the rpath both go away. libcufft_static.a carries a relocatable-device-code object, so a consuming executable needs a CUDA device link; CUDA 13 no longer ships the libcufft_static_nocallback.a that used to avoid this. CUDA_RESOLVE_DEVICE_SYMBOLS emits that step while leaving the host link driver alone, so the -march and -flto flags CI passes still apply. The server build keeps the shared library: its .deb/.rpm take CUDA from the distro, and every executable there would otherwise need the same device link. The guards that exclude server-side targets keyed on NOT JFJOCH_VIEWER_ONLY, which a rugnux-only build does not satisfy - it failed on jfjoch_writer pulling in JFJochImagePuller. They now key on JFJOCH_PORTABLE_ONLY, true for either product, rather than on one product's option in five places. docker/ubuntu2404 additionally cross-compiles rugnux for arm64 SBSA, which is both DGX Spark (GB10, sm_121) and Grace Hopper (GH200, sm_90); one binary with both fatbins runs on either. It needed three things beyond a cross gcc. arm64 is published on ports.ubuntu.com and Noble's deb822 sources carry no Architectures: field, so adding the architecture without splitting the entries 404s on every index. The CUDA cross packages are in neither the x86_64 repo nor the sbsa one but in cross-linux-sbsa, whose fatbinary_section.h ships only in the x86_64 target tree even though it is architecture-neutral. And HDF5 has two try_run probes, so qemu-user-static is needed as CMAKE_CROSSCOMPILING_EMULATOR; every other fetched dependency either guards its run-checks or has none. The cross-built tarball is one ELF aarch64 binary carrying all 17 GPU modules for both sm_90 and sm_121, needing no cuFFT and no CUDA runtime at run time. It is untested on hardware: XDS is x86-64 only, so CI can show it links but only a Spark or a GH200 can show it works. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQjneRUssfhi1k9rq8Ts3h	2026-08-25 19:23:59 +02:00
leonarski_fandClaude Opus 5	3ea1206775	Space-group search: raise the twin-law H bound from 1.70 to 1.85 ... Re-measured over ~780 reports - three batteries and four de-novo integration-radius arms - H is the only Stage-A guard that ever fires: 14 refusals on three crystals, and not one chi-squared-ratio refusal or b veto anywhere. Two of the three are the genuine trigonal twins, reading 1.90 and 1.91 on every arm and 3.61-4.80. The third is a weak tetragonal crystal reading 1.73-1.80 that is not twinned: its 422 is confirmed by every operator correlation, and three independent tests agree - our own L test on the P2(1)2(1)2(1) merge it was demoted into, xtriage on that same merge ("no twinning is suspected... most likely due to an NCS axis parallel to the twin axis"), and the arithmetic that a twin at the implied fraction caps twin-pair correlation at 0.55 while the four added operators score 0.84-0.90. Its excess is the coverage limit the comment above the bound already names: the added 422 operators exchange h and k, so they carry a systematic floor the parent's sign-flipping 2-folds do not. The two populations therefore collide at 1.80 and 1.90, not at 1.70, and the bound now sits at the midpoint of that window. Degrading the data - 4x sigma inflation, or an eighth of the sweep - drives the ratio towards 1 and never up, and the estimator is precise (bootstrap standard error 0.2-3.7% of the ratio), so the collision is a genuine population overlap rather than sampling noise. That also rules out scaling the bound by its own error, which at any useful multiple refuses half the battery. Inert on the shipped defaults: no crystal in the battery reads between 1.70 and 1.85 there. It changes one assignment on an experimental integration radius, from wrong to right. The committed twin test is unaffected - genuine promotions in that harness read 0.959-1.016 against 4.23-5.36 for its twin, so nothing lies in the interval that moved. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-25 19:17:16 +02:00
leonarski_fandClaude Opus 5	80e10f51b3	rugnux: measure and report diffraction anisotropy ... rugnux now says whether a dataset's fall-off is direction-dependent, and by how much. It corrects nothing and truncates nothing: no intensity is changed, no reflection is dropped on a directional criterion, and the written files do not depend on direction at all. Two quantities, because they are not the same thing. The anisotropic deltaB is the range of the principal components of the anisotropy tensor - a rate of fall-off. The diffraction limit along each principal direction is where <I/sigma(I)> in a 20 degree cone falls through 2 - where signal actually runs out. One battery case has only 0.28 A between its directional limits and a 58x ratio in cone <I/sigma>, so reporting either alone would miss it. The tensor is a Laue-constrained deviatoric ADP tensor fitted on INTENSITIES with no positivity cut, by weighted Gauss-Newton over 12 shells x 60 directions with a free constant per shell. Fitting amplitudes after a positivity cut, which is what xtriage and ctruncate do, destroys about 40% of the measured anisotropy - the cut keeps only the positive noise excursions in whichever direction has died, and that is the direction carrying the signal. Against the same 38 merged files rugnux reads 1.24x xtriage's eigenvalue spread and 1.61x ctruncate's; on strong near-isotropic data all three agree to a few percent, and they diverge exactly where a direction has died. The verdict is gated three ways - not detected, detected, or cannot determine - against the dataset's own systematic floor, measured in the tensor directions its Laue symmetry forbids. The floor cannot be measured on merged reflections, which have exact Laue symmetry by construction, so the floor is taken from the unmerged observations and the verdict is "cannot determine" without them. Triclinic has no forbidden subspace and always returns cannot determine. A cubic crystal returns exactly zero, because that is its symmetry and not a measurement. A second axis reports the resolution signature: a genuine Debye-Waller fall-off is linear through the origin in s^2, and a deficit that is flat is something else. Magnitude alone had promoted a crystal that is 68% not a Debye-Waller B into the top five of this battery; it now reads not detected with the caution attached. Following Sheriff & Hendrickson (1987) Acta Cryst. A43, 118-121 for the tensor and Popov & Bourenkov (2003) Acta Cryst. D59, 1145-1153 for the estimator. The directional limits are written as jfjoch_ local mmCIF items rather than _reflns.pdbx_aniso_diffraction_limit_*, whose dictionary definition is explicitly the ellipsoid fitted to a diffraction cut-off surface - a construction rugnux does not perform. The generic anisotropic B tensor items are written. Changes no existing number; only REPORT_VERSION moves, 1 to 2. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-25 19:13:16 +02:00
leonarski_fandClaude Opus 5	0f5a6e41d6	rugnux: report the Wilson B in --mode scale, and correct what the docs claim about the fixed integration radius ... --mode scale called AnalyzeTwinning but not CalcGlobalWilsonB, so WILSON_B= read nan there. Mirrors what --mode mx does; on one crystal scale mode now reports 72.03 against mx mode's 71.91 on the same data, and where the fitted B is not positive it still reads nan, which is the same verdict --mode mx reaches. The merged .mtz and .hkl are byte-identical before and after. docs/CPU_DATA_ANALYSIS.md and BraggStencil.h both said the flux the fixed r1 disk does not capture "is a function of resolution alone, which the per-shell scale absorbs". Neither half is true. The loss carries a directional component of several A^2 on top of the isotropic part. There is no per-shell scale, and there cannot usefully be one: every scale is fitted against a reference built from a reflection's own symmetry equivalents, equivalents share s^2 exactly, so any function of s^2 lies in the exact null space of the scaling model. What actually absorbs the isotropic part is the Wilson B, which is degenerate with it - so WILSON_B and _reflns.B_iso_Wilson_estimate carry an r1-dependent bias, measured at 18 A^2 of spread across four radius triplets on one crystal. The text also corrected a third error: in the default gaussian mode r1 is not the integration domain at all - the intensity is a profile-fit amplitude over a grid set by r2 - and a note now sits at the section a reader looking up the Wilson B actually lands on. Comments and documentation only for that part; verified by rebuilding and confirming byte-identical output with no flags. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-25 18:51:06 +02:00
leonarski_fandClaude Opus 5	ef07770c5f	rugnux: name the unmerged export from the prefix, and drop centring absences ... --export-unmerged and --export-unmerged-partials no longer take a filename; they write <prefix>_unmerged.mtz and <prefix>_unmerged_partials.mtz, as --write-process-h5 already does for <prefix>_process.h5. Lattice-centring absences are no longer written. They are integrated on purpose - prediction runs in P so the space-group search can confirm or disprove the centring - but in an exported file they cost the reader the answer: pointless reads the interstitial nodes, takes the lattice for primitive, and demotes I23 to P2_1 3, while aimless roughly halves its <I/sigma> merging them. They were also only present when the indexer had settled on the conventional centred cell, so the file's content depended on which of two equivalent cells it picked. Screw and glide absences are still written. They are the evidence a space group is chosen on, so a program reading this file can check that choice independently; deleting them turns pointless's test into an assumption ("we cannot determine if the reflections are truly systematically absent"). Deleting them changes no merging statistic. XDS and DIALS draw the line in the same place - XDS ships screw absences and never measures a centring one, and DIALS's absence machinery has only screw-axis classes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-25 17:21:21 +02:00
leonarski_fandClaude Opus 5	bb5aaca68e	rugnux: sum each rotation reflection's partials into one full on export ... --export-unmerged now writes one row per reflection with its partials summed, which is how a rotation dataset is normally handed to a scaling program. The previous behaviour is still available as --export-unmerged-partials. Partials made the file's usefulness depend on the reading program's partial-assembly settings. On an orthorhombic case only 31% of partial sets passed aimless's default PARTIALS test, so it merged 2% of the file: multiplicity 4.7 against our own 12.4, CC1/2 0.788, and CC against our merged intensities 0.806. Summed, aimless uses 89% of the file and rejects nothing: multiplicity 12.5, CC1/2 0.931, completeness 96.1 to 98.0, pointless Laue confidence 0.669 to 0.792, CC 0.848. The other two test crystals are ties overall and win their outer shells, and the anomalous signal comes out stronger from the fulls. iotbx.merging_statistics, which never assembled partials at all, now reports real merging statistics rather than statistics of parts. Events are grouped by Combine()'s own rule so the file and the merge assemble exactly the same reflections; the sum is plain with variances in quadrature and no partiality division, which reproduces the merge's full times FRACTIONCALC to a few percent. Per-part metadata is combined on a partiality-weighted centroid rather than an intensity-weighted one: 8-41% of events have parts summing to zero or less, where intensity weights are undefined or sign-flipped, and 10-21% of intensity-weighted centroids fall outside the event's own frame range. Events below --min-partiality are not written. Declaring a reflection whose rocking curve caught a thousandth of itself as a complete measurement gives a scaling program noise with a small sigma and it weights it heavily; there is no partial test to catch it once it is a full. This is the same constant already applied to the same quantity in the merge, and it is what takes the orthorhombic case from CC 0.219 to 0.848. --min-partiality 0 writes every event. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-25 16:18:14 +02:00
leonarski_fandClaude Opus 5	86b7e07131	Drop Ceres' LAPACK, METIS and SuiteSparse back-ends: nothing calls them ... Every Ceres solve in the project selects a dense linear solver explicitly -- DENSE_QR in PostRefine, RingOptimizer and StillsPartialityRefine, DENSE_NORMAL_CHOLESKY in XtalOptimizer, DENSE_SCHUR in GeometryRefiner -- and none of the seven Solver::Options sites sets dense_linear_algebra_library_type, which defaults to EIGEN. ceres::Covariance, the other SuiteSparse consumer, is never instantiated. So no sparse factorization and no LAPACK call is reachable. Measured rather than argued: an LD_PRELOAD shim exporting dgeqrf_, dpotrf_, dtrtrs_, spotrf_ and METIS_NodeND, each aborting on entry, let a full mx run (1800 frames, index -> refine -> integrate -> scale -> merge) finish with every counter at zero. The change is a no-op on results. Baseline and modified binaries produce byte-identical run.mtz, run.hkl and run.cif on a rotation dataset at -N 1, and two baseline runs give that same signature, so the comparison is meaningful. Only the DATE= stamp in the report differs. What it buys is six fewer shared libraries: libopenblas and libmetis, plus libgfortran, libquadmath, libgomp and libz behind them. rugnux links its own zlib statically -- zero undefined zlib symbols before and after -- so the dynamic libz only ever arrived through OpenBLAS. It also makes the build reproducible across hosts. SUITESPARSE defaults ON and self-disables only when its probe fails, so a machine where SuiteSparse_DIR is not found already compiled CERES_NO_SUITESPARSE while one carrying the SuiteSparse CMake config would not have. Pinning it removes that divergence, and shortens what a cross-compiled aarch64 build has to supply. EIGENSPARSE stays ON, so a sparse solver remains available if one is ever selected, without an external library. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQjneRUssfhi1k9rq8Ts3h	2026-08-25 15:58:34 +02:00
leonarski_fandClaude Opus 5	5248b1bc00	rugnux: export the integrated observations as an unmerged MTZ ... Adds --export-unmerged <file.mtz>, in --mode mx and --mode scale alike. rugnux could only write merged reflections, which closed it off from the programs that consume unmerged observations - aimless, pointless, careless and iotbx.merging_statistics all read this file. The column layout follows what pointless itself writes (H K L M/ISYM BATCH I SIGI FRACTIONCALC XDET YDET ROT LP FLAG), with DELPHI, ZETA, BGMEAN and BGVAR added because we have them and a scale model can use them. Three details decide whether the file is usable: Lorentz-polarization is applied and recorded in LP. It is per-observation geometry spanning a factor of ~120 across a sweep and no reading program can recover it; merging with no scale model at all gives R_meas 0.372 / 0.346 / 0.324 in the low shells without it against 0.183 / 0.218 / 0.257 with it. The partiality is not divided out - it stays in FRACTIONCALC - and neither is the per-image scale, since these programs fit their own. The observations are partials and are flagged as such, packed as 256*M + ISYM with LDTYPE=1. Without the flag pointless reads every part as a whole observation and mis-assigns the symmetry; with it, a tetragonal case assembles 8.29M parts into 1.15M observations and comes back as its own space group at confidence 0.92. The scan axis is written as the negation of the stored goniometer axis, which is the Cambridge convention: against pointless's own orientation matrix that agrees to 0.6 degrees, where the axis as stored disagrees by 40. Merging the exported file with aimless reproduces rugnux's own merge to CC 0.9997 on a tetragonal case and 0.9978 on a cubic one, and the anomalous signal survives. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CHMmeM1d489zvNFT7ZMN2P	2026-08-25 15:21:57 +02:00
leonarski_fandjungfrau	4dc2534dbf	v1.0.0.rc-162 (#72) ... **Files written by Jungfraujoch now import correctly in DIALS, XDS and pyFAI.** A tilted detector, a grid scan, a still recorded at a goniometer position, and saturated or unreadable pixels were each described in a way that a third-party program acted on wrongly. If you process Jungfraujoch data outside Jungfraujoch, prefer this release to any earlier one. * HDF5: the detector tilt (`rot1`/`rot2`/`rot3`) is exported correctly in the NXmx transformation chain; untilted geometries are unaffected. * HDF5: a still recorded at a goniometer position is no longer read back as a single image, and a grid scan records a stationary spindle so a program that requires a rotation axis can open it. * HDF5: the sample transformation chain is written in mounting order, with a Smargon head position told apart from the spindle, one entry per image, `module_offset` as a float unit vector, and `offset_units` on every offset. * HDF5: saturated, underloaded and unreadable pixels are described so a downstream program masks them - `saturation_value`, `underload_value`, `error_value` and `bit_depth_readout` are written correctly, and a data file missing next to a VDS master reads as the error marker rather than as zero counts. * HDF5: the rotation axis is read back under whatever name it carries, and `mirror_y` records whether the assembled image is mirrored in Y relative to the detector's raw readout. * A grid scan and a goniometer axis can both be set; they are no longer alternatives. * `images_per_file` is chosen from the acquisition when it is not given: a rotation sweep of at most 20000 images goes into a single data file, a grid scan splits on whole fast-axis rows, and stills and serial keep 1000. * The writer refuses a stream whose start message declares a different pixel format than its images carry, and a DECTRIS detector sending signed images is no longer declared unsigned. * The image stream can carry the sample transformation chain (`transformations`, in the END message); a producer that does not send it gets the same chain built by the writer. * rugnux: fixing the space group with `-S` no longer prevents the lattice from being found - a lattice indexed in a different setting is reindexed into that group's own setting, and a run whose crystal does not have that group's lattice stops and names the cell it indexed as, rather than reporting statistics that cannot describe it. * rugnux: the per-image resolution estimate now predicts the resolution the merged data reach rather than the highest-resolution spot found, and is reported as `SPOT_RESOLUTION_ESTIMATE`. * rugnux: two runs of the same command on the same images produce the same merged intensities; the azimuthal profile written alongside them is not yet reproducible in the same way. * rugnux: the offline lattice refinement is bounded by iterations rather than by a wall clock, so a loaded machine can no longer refine to a different lattice; a live acquisition keeps its real-time bound. * rugnux: the detector-frame modulation correction is fitted on a grid spanning the detector, so whether it is applied no longer depends on how far integration reached. * rugnux: the geometry pre-pass no longer writes `<prefix>_01.mtz`, `_01.cif`, `_01.hkl` and `_01_image.dat`; the refined second pass writes those files under `<prefix>`, and that is the result to use. * rugnux: `_process.h5` describes the pixel format of the images it links to, and is written on a thread of its own. * rugnux: the detector geometry is also logged in XDS's convention (`ORGX`/`ORGY`, detector axis vectors, rotation axis), so it can be compared with an XDS refinement. * rugnux: an image integrated in pyFAI through the `.poni` file written by `--mode calibration` comes out with the correct azimuth, and the file declares pyFAI's `orientation`, which needs pyFAI 2024.01 or newer. Radial integration is unchanged. * rugnux: a rotation run is substantially faster throughout - beam-stop detection, first-pass indexing, geometry refinement, integration, scaling and merging - and observations outside the scaling resolution range are dropped as they are ingested. The refined geometry, the space group chosen and the merged statistics are unchanged. * Faster spot finding and indexing, on the broker as well as in rugnux; the spots found and the lattices indexed are unchanged. * A run reserves substantially less GPU memory: nothing is allocated for buffers that are never read, and a worker builds only the engines it uses. * rugnux: with `-N` left at its default the per-image loop of `--mode mx` uses at most 16 workers per GPU, rather than one per hardware thread; an explicit `-N` is obeyed as given. * CUDA 12 builds now contain device code for Volta, so the RHEL 8 packages and the portable Linux `.tgz` run on a V100; the CUDA 13 artefacts (RHEL 9, Ubuntu, Windows) remain Turing and newer. * The build resolves a single Eigen for the whole project, and refuses to configure if Ceres picks up a different one; a build that mixed two Eigen versions was undefined behaviour and crashed at -O2. * Documentation: a security page, and the supported GPU generations and minimum NVIDIA driver version of every released artefact. **Breaking change to OpenAPI** - regenerate the client (`jfjoch-client` 1.0.0-rc.162, `frontend/src/client`): * `dataset_settings.images_per_file` is no longer `default: 1000` and no longer accepts `0`; it is optional, and its minimum is 1. A client sending `0` (previously "one file for the whole run") is now rejected - omit the field instead, which for a rotation sweep gives the same single file. * `file_writer_format` now defaults to `NXmxVDS`, matching the server's own default and the layout recommended for DIALS, XDS and CrystFEL. A generated client that fills in schema defaults and does not set the format explicitly will write VDS masters where it previously wrote legacy ones; set `NXmxLegacy` explicitly to keep them. --------- Co-authored-by: jungfrau <jungfrau@mx-aare-test.psi.ch> Reviewed-on: #72 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-08-25 08:21:39 +02:00
leonarski_f	538f3504d3	v1.0.0.rc-161 (#71) ... This is an UNSTABLE release. It includes many experimental features, as well as many AI generated fixes. We recommend using rc.152 for production use. * **rugnux: significantly better quality of results, and faster.** A large rework of integration, scaling, merging, geometry refinement and space-group determination, together with measurements the program previously made no attempt at - the direct beam before indexing, the beam stop, the goniometer rotation scale, and the stretches of a sweep the crystal did not deliver. A rotation dataset typically gains observations at better <I/sigma> and R_meas, and every `mx` and `scale` run writes a `<prefix>_report.txt` results report modelled on XDS's `CORRECT.LP`. Many defaults moved with it: spot detection is self-calibrating, beam-stop detection and rotation geometry post-refinement are on, resolution limits default to as far as the detector reaches, and ice-ring handling engages only where the crystal is measured to have ice. * **jfjoch_viewer:** the beam-stop shadow, the detector calibration and the beam-centre measurement are reachable from "Analyze dataset"; the settings panel reports how the sample moved and how polarized the beam was; image rendering and interaction are faster. * **Performance:** bitshuffle+LZ4 images are decoded on the GPU rather than on the host, with the bitshuffle inverse fused into preprocessing so the decompressed frame is never held in device memory. * **Broker, writer, packaging and build:** image-slot lifetime and locking fixes, per-image datasets sized by the images actually written, the Debian/Ubuntu broker package renamed to `jfjoch`, and `image_analysis` compiling under MSVC again. **Breaking change to the rugnux command line:** * `--azint-only` and `--scale` are **removed**, replaced by `--mode azint` and `--mode scale`; the full pipeline is `--mode mx` and remains the default. A script passing the old flags now fails with the list of valid modes rather than silently running the wrong one. * `-t`/`--stride` is **refused on rotation data**: skipping frames cuts every reflection's rocking curve, so the combined fulls and their partiality would be measured over frames the sweep never recorded. Select a contiguous range with `-s`/`-e` instead. `--mode azint` and `--force-still` still take a stride. **Breaking changes to OpenAPI** - regenerate the client (`jfjoch-client` 1.0.0-rc.161, `frontend/src/client`) or read the affected fields as optional: * `image_scale_b` is removed from the `plot_type` enum, so a client requesting that plot now gets an error rather than a curve. * `azim_int_settings.high_q_recipA`, `spot_finding_settings.high_resolution_limit` and `spot_finding_settings.low_resolution_limit` are no longer `required`. All three mean "no limit at that end" when unset and are omitted from the response instead of carrying a placeholder value, which raises in a client generated from an rc.160-or-earlier spec. A value of 0 is still accepted and means the same thing. **Breaking changes to the stored formats** - a consumer reading these fields must treat them as optional: * The per-image image-scale B factor is no longer computed, so `/entry/MX/imageScaleBFactor` is absent from newly written HDF5 files and the corresponding key is absent from the CBOR DataMessage and END blocks. Files written by rc.160 and earlier still contain it and still open; nothing in the pipeline reads it any more. * `_reflns.jfjoch_diffrn_ISa` now carries the whole-range `1/sqrt(a*b)` that XDS's ISa denotes, and the error-model `a` and `b` are reported in XDS's convention; the strong-reflection asymptote moves to `_reflns.jfjoch_diffrn_ISa_asymptotic`. **A file written by an earlier version carries the asymptote under the plain `ISa` name.** Reviewed-on: #71 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-08-13 17:03:10 +02:00
leonarski_f	67dca388bd	v1.0.0-rc.160 (#70) ... This is an UNSTABLE release. It includes many experimental features, as well as many AI generated fixes. We recommend using rc.152 for production use. * rugnux: Add `--model model.pdb` - score the merged data against an atomic model and compute initial maps. It reports R-work/R-free (scaling the model to the observed amplitudes with an overall scale, an anisotropic B and a flat bulk solvent - the standard few-parameter model, so a batch of maps stays directly comparable) and writes 2Fo-Fc / Fo-Fc electron-density maps (CCP4) plus a map-coefficient MTZ. The structure itself is not refined; the model is only re-fractionalised into the data cell. * rugnux: The merged reflection output now carries French-Wilson amplitudes (|F| and its sigma) next to the intensities - MTZ `F`/`SIGF`, mmCIF `_refln.F_meas_au`, and the text HKL - computed with the correct centric/acentric Wilson prior and epsilon multiplicity, so a downstream program (e.g. phenix.refine) can refine against amplitudes. The intensity columns are unchanged. * rugnux: R-free test-set flags are now assigned deterministically and consistently across symmetry - a Bijvoet pair I(+)/I(-) is never split between the work and free sets, and the assignment is a reproducible per-hkl hash that depends only on the reflection index, so every dataset of one crystal form gets the same ~5% free set (what a multi-dataset campaign such as PanDDA needs). On small data the fraction is floored so the test set stays large enough for a stable R-free (~500 reflections, capped at 10%); it stays flat at 5% on ordinary data. When a reference MTZ carries a `FreeR_flag` column its test set is imported instead, letting a whole campaign inherit one shared free set. * rugnux: A reference MTZ (`--reference-mtz`) can now fix the space group and cell for rotation data too (previously rejected), without being used to scale - the rotation merge stays self-consistent. When the crystal has an indexing (merohedral) ambiguity - a lattice symmetry higher than its Laue symmetry, e.g. P3/P4/P6/C2 - the reference also resolves it: each candidate reindexing (identity plus the twin-law cosets of the metric symmetry) is scored by its intensity correlation against the reference and the data are re-merged in the best-correlating one. This is a metric-preserving relabelling of hkl (the cell is unchanged) and a no-op for a holohedral crystal such as lysozyme. * rugnux: `--model` validation now aligns the data to the model before scoring - the observed reflections are reindexed into the model's enantiomorph when the two differ only by hand (indistinguishable from merged intensities). A merohedral indexing ambiguity is resolved against the reference MTZ when one is given (so a whole campaign shares one indexing convention); only with a model and no reference does validation fall back to fitting each candidate reindexing and keeping the lowest R-free. * rugnux: De-novo symmetry - recover a genuine high-symmetry group whose data are imperfectly scaled. Such a merge's within-orbit chi² lands just past the self-consistency bound (each real symmetry step adds a little systematic scatter), right where a merohedral twin also lands, so the chi² ratio alone cannot separate them. The candidate is now rescued when the extra intensity-proportional systematic error it invokes stays small relative to the confirmed subgroup - a genuine symmetry step gains multiplicity without inflating the merge error model's b, whereas a twin forces non-equivalent reflections together and b balloons. Fixes cubic insulin (I23 instead of I222) with no change to any other crystal in the test battery, including the twins that must stay in their lower symmetry. * Docs: Document the French-Wilson amplitude estimation, R-free flagging, reference-based space-group/ambiguity resolution, and model-based validation/maps in CPU_DATA_ANALYSIS.md. * Frontend: The status-bar pill now shows a progress bar during detector calibration (previously only during measurement), and the calibration state and its button are labelled "Calibration"/"CALIBRATE" (the internal `Pedestal` state name is unchanged for back-compatibility).Reviewed-on: #70 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-07-19 09:39:28 +02:00
leonarski_f	dd0bffb283	v1.0.0-rc.159 (#69) ... This is an UNSTABLE release. It includes many experimental features, as well as many AI generated fixes. We recommend using rc.152 for production use. * rugnux: Add `--model model.pdb` - score the merged data against an atomic model and compute initial maps. It reports R-work/R-free (scaling the model to the observed amplitudes with an overall scale, an anisotropic B and a flat bulk solvent - the standard few-parameter model, so a batch of maps stays directly comparable) and writes 2Fo-Fc / Fo-Fc electron-density maps (CCP4) plus a map-coefficient MTZ. The structure itself is not refined; the model is only re-fractionalised into the data cell. * rugnux: The merged reflection output now carries French-Wilson amplitudes (|F| and its sigma) next to the intensities - MTZ `F`/`SIGF`, mmCIF `_refln.F_meas_au`, and the text HKL - computed with the correct centric/acentric Wilson prior and epsilon multiplicity, so a downstream program (e.g. phenix.refine) can refine against amplitudes. The intensity columns are unchanged. * rugnux: R-free test-set flags are now assigned deterministically and consistently across symmetry - a Bijvoet pair I(+)/I(-) is never split between the work and free sets, and the assignment is a reproducible per-hkl hash that depends only on the reflection index, so every dataset of one crystal form gets the same ~5% free set (what a multi-dataset campaign such as PanDDA needs). On small data the fraction is floored so the test set stays large enough for a stable R-free (~500 reflections, capped at 10%); it stays flat at 5% on ordinary data. When a reference MTZ carries a `FreeR_flag` column its test set is imported instead, letting a whole campaign inherit one shared free set. * rugnux: A reference MTZ (`--reference-mtz`) can now fix the space group and cell for rotation data too (previously rejected), without being used to scale - the rotation merge stays self-consistent. When the crystal has an indexing (merohedral) ambiguity - a lattice symmetry higher than its Laue symmetry, e.g. P3/P4/P6/C2 - the reference also resolves it: each candidate reindexing (identity plus the twin-law cosets of the metric symmetry) is scored by its intensity correlation against the reference and the data are re-merged in the best-correlating one. This is a metric-preserving relabelling of hkl (the cell is unchanged) and a no-op for a holohedral crystal such as lysozyme. * rugnux: `--model` validation now aligns the data to the model before scoring - the observed reflections are reindexed into the model's enantiomorph when the two differ only by hand (indistinguishable from merged intensities). A merohedral indexing ambiguity is resolved against the reference MTZ when one is given (so a whole campaign shares one indexing convention); only with a model and no reference does validation fall back to fitting each candidate reindexing and keeping the lowest R-free. * rugnux: De-novo symmetry - recover a genuine high-symmetry group whose data are imperfectly scaled. Such a merge's within-orbit chi² lands just past the self-consistency bound (each real symmetry step adds a little systematic scatter), right where a merohedral twin also lands, so the chi² ratio alone cannot separate them. The candidate is now rescued when the extra intensity-proportional systematic error it invokes stays small relative to the confirmed subgroup - a genuine symmetry step gains multiplicity without inflating the merge error model's b, whereas a twin forces non-equivalent reflections together and b balloons. Fixes cubic insulin (I23 instead of I222) with no change to any other crystal in the test battery, including the twins that must stay in their lower symmetry. * Docs: Document the French-Wilson amplitude estimation, R-free flagging, reference-based space-group/ambiguity resolution, and model-based validation/maps in CPU_DATA_ANALYSIS.md. * Frontend: The status-bar pill now shows a progress bar during detector calibration (previously only during measurement), and the calibration state and its button are labelled "Calibration"/"CALIBRATE" (the internal `Pedestal` state name is unchanged for back-compatibility).Reviewed-on: #69 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-07-13 13:54:03 +02:00
leonarski_f	451310f43d	v1.0.0-rc.158 (#68) ... This is an UNSTABLE release. It includes many experimental features, as well as many AI generated fixes. We recommend using rc.152 for production use. * Analysis: The azimuthal-integration solid-angle correction now follows the incidence angle to the detector normal (`cos^3` of that angle) instead of `cos^3(2*theta)`, so it is correct for a tilted detector and matches PyFAI `solidAngleArray` and MAX IV azint (unchanged for an untilted detector). Crystal geometry refinement (`XtalOptimizer`) no longer silently ignores an imported PONI `rot3` (rotation about the beam): it is applied as a fixed rotation in the residual so refinement stays consistent with the rest of the pipeline. Polarization and azimuthal binning already honoured `rot3` through the full PONI rotation. * jfjoch_viewer: Open datasets on the WSL2/UNC filesystem (paths starting `\\`); write processing outputs next to the input file, with a Browse button and independent `_process.h5` / merged `.mtz`/`.cif` toggles; and show the determined space group in the merge-statistics window. * rugnux: Accept an absolute `-o` output prefix in offline processing. * Packaging: The self-contained Linux viewer `.tgz` now bundles cuFFT, so it runs without a system CUDA toolkit (`.deb`/`.rpm` are unchanged, distro-managed). * Docs: Bring the analysis references up to date with the code. `docs/CPU_DATA_ANALYSIS.md` now reflects the unified profile-fit Bragg integration engine, multi-lattice indexing, azimuthal phi binning, the radial parallax/bandwidth profile with sub-pixel centring, the rot3d capture-fraction handling and the automatic CC1/2 resolution cutoff, and drops the descriptions of features that were never implemented (French-Wilson amplitudes, the still excitation-error partiality model); `docs/RUGNUX.md` documents the new `--resolution-cutoff`/`--resolution-cc-target`/`--resolution-shells`, `--min-captured-fraction`, `--mosaicity`, `--reference-column`, the azimuthal correction toggles and the geometry-override options, and corrects the `-N` default. The outdated in-source design notes (ICE_RING_DETECTION, BRAGG_INTEGRATION_ENGINE, NEXTGEN_INTEGRATOR) are removed.Reviewed-on: #68 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-07-12 19:42:29 +02:00
leonarski_f	54c0100e8e	v1.0.0-rc.157 (#67) ... This is an UNSTABLE release. It includes many experimental features, as well as many AI generated fixes. We recommend using rc.152 for production use. * rugnux: Rebrand the offline data-processing subsystem as `rugnux` and consolidate all offline analysis into the single `rugnux` binary - `jfjoch_process` is now `rugnux`, the former `jfjoch_azint` is now `rugnux --azint-only`, and `jfjoch_scale` is now `rugnux --scale` (see the new docs/NAMING.md and docs/RUGNUX.md). Scaling and merging are on by default for rotation and stills (`--no-merge` disables them), replacing the previous opt-in `-M, --scale-merge`. * rugnux: CLI fixes - default `-N` to all hardware threads, parse numeric option arguments strictly (reject non-numeric or trailing input instead of silently yielding 0), require `--wavelength > 0`, and correct the reproduced command line and `--scale` reference-cell handling. * rugnux: De-novo space-group improvements - recover genuine high symmetry and centred Bravais lattices from intensities, add an automatic CC1/2 high-resolution cutoff, and report L-test twinning statistics. * rugnux: Index weakly-diffracting low-resolution rotation data that previously failed (e.g. F-cubic crystals that diffract only to ~4 A on a detector reaching ~1.5 A). The per-frame indexing gate now measures the indexed fraction only within the resolution range the lattice actually diffracts to, so the many sub-diffraction ice/noise spots no longer make the fraction floor unreachable; the two-pass first pass tries several image-sampling schemes (spread across the whole rotation vs a consecutive wedge whose native stride keeps a reflection's rocking curve continuous, letting the FFT resolve a long axis) and keeps the one that indexes the most frames; and the de-novo space-group search no longer discards all reflections (and crashes) when every resolution shell falls below <I/sigma> = 1. * rugnux: Lower the low-resolution R-meas for strongly-diffracting rotation data - drop edge-of-sweep truncated fulls whose rocking curve was captured below `--min-captured-fraction` (default 0.7 for rotation), and report R-meas only over the observations kept by outlier rejection (matching XDS). The 0.7 default also strips the partiality-extrapolated fulls that dominate the intensity second moment on weakly-diffracting crystals, so the de-novo space-group search is no longer starved by the error-model I/sigma floor and recovers the correct symmetry (e.g. the F-cubic Benas crystals: Benas_3 -> F432, Benas_7 -> P6122, instead of P4/P1); on the reference battery every other crystal keeps its space group. * rugnux: Write the refined geometry (beam, tilt, axis) to _process.h5 and place non-standard mmCIF items under a reserved `jfjoch` prefix. * jfjoch_broker: Ordinary acquisition failures (receiver/writer/analysis problems, missed packets, writer disconnect) now return to the Idle state with an Error-severity message, so a run can be retried without an expensive re-initialisation; only failures that leave the detector in an undefined state (new JFJochCriticalException, e.g. PCIe/FPGA faults) go to the Error state and force re-initialisation. * jfjoch_broker: A synchronous /start now reports its failure to the HTTP caller instead of returning HTTP 200, and an incomplete or truncated dataset (missing packets, writer disconnect) is reported as an error rather than a "reduce frame rate" warning. * jfjoch_broker: Drop uncollected placeholder rows (number = -1) from the scan_result REST endpoint. * jfjoch_broker: Fix the inverted per-image compression ratio reported by the Lite receiver (was compressed/uncompressed instead of uncompressed/compressed). * jfjoch_broker: Bragg integration adds a quantization-noise variance floor with a box-sum fallback, and treats the type-maximum marker as an invalid pixel for unsigned image types. * jfjoch_writer: Detect file-overwrite conflicts at start for back-channel transports, and reset the writer when end-of-collection finalisation fails. * jfjoch_viewer: Preview overlays follow the geometry (resolution/ROI arcs, true beam centre, predictions, coral secondary-lattice spots, legend), add save-as-JPEG, and fix an HTTP live-follow memory leak. * Frontend: Improved aesthetics and usability, and added in-browser pixel-mask and JUNGFRAU-pedestal visualisation. * CI: Name the Windows installer jfjoch-viewer-* instead of jfjoch-*.Reviewed-on: #67 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-07-11 07:19:11 +02:00
leonarski_f	d6389e12da	v1.0.0-rc.156 (#66) ... This is an UNSTABLE release. It includes many experimental features, as well as many AI generated fixes. We recommend using rc.152 for production use. * jfjoch_process: Major rotation (rot3d) data processing overhaul - robust profile-fit integration, Cauchy-loss scaling with optional absorption surface, de-novo indexing and space-group/centering determination fixes, and merging statistics + ISa in the mmCIF output. * jfjoch_process: Add EXPERIMENTAL ice-ring detection (--detect-ice-rings) that excludes ice reflections from scaling. * Compression: Add BSHUF_ZSTD_RLE_HUFF, make compression size-aware (drop frames that don't fit rather than aborting), and add the jfjoch_recompress tool. * jfjoch_viewer: Report "Multiple lattices detected" and grey out "Analyze dataset" on a live connection. * jfjoch_broker: Write smargon chi/phi goniometer positions to NXmx; read sensor thickness/material from HDF5 metadata. * CI: Build Windows (CUDA and non-CUDA) installers.Reviewed-on: #66 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-07-03 19:18:56 +02:00
leonarski_f	54c667190f	v1.0.0-rc.155 (#65) ... This is an UNSTABLE release. It includes many experimental features, as well as many AI generated fixes. We recommend using rc.152 for production use. * jfjoch_process: Remove pixelrefine option (replaced with ProfileIntegrate2D) * jfjoch_viewer: Some graphical improvements. * jfjoch_viewer: Simplify und unify data analysis settings. * jfjoch_writer: Add TCP keepalive to increase robustness if jfjoch_broker "dies" in the middle of data acquisition. Reviewed-on: #65	2026-06-25 22:01:48 +02:00
leonarski_f	75e401f0e5	v1.0.0-rc.153 (#63) ... This is an UNSTABLE release. It includes many experimental features, as well as many AI generated fixes. We recommend using rc.152 for production use. * jfjoch_broker: Add EXPERIMENTAL pixelrefine mode for image processing * jfjoch_broker: Allow to load user mask from 8-bit and 16-bit TIFF files * jfjoch_broker: Add ROI calculation in non-FPGA workflow * jfjoch_broker: Fixes to TCP image pusher * jfjoch_broker: Remove NUMA bindings * jfjoch_broker: Improvements to indexing * jfjoch_broker: For PSI EIGER, trimming energies are taken from the detector configuration (now compulsory) instead of hardcoded values * jfjoch_writer: Save ROI definitions and the per-pixel ROI bitmap in the master file; azimuthal ROIs support phi (angular) sectors * jfjoch_viewer: Major redesign with dockable panels and saved layouts, plus on-canvas creation/move/resize of box, circle and azimuthal ROIs * jfjoch_viewer: Run jfjoch_process reprocessing jobs from inside the GUI and overlay per-run results Reviewed-on: #63	2026-06-23 20:29:49 +02:00
leonarski_f	90e804acd7	v1.0.0-rc.150 (#60) ... * jfjoch_broker: When in FPGA workflow (with PSI detectors) azimuthal integration might be forced to CPU - this will require more computational power, but it enables more integration bins and reports standard deviation of each bin. * jfjoch_broker: Raise error if one is in FPGA flow and there are too many azimuthal integration bins. Reviewed-on: #60	2026-06-15 20:24:15 +02:00
leonarski_f	cc3eb8352c	v1.0.0-rc.148 (#58) ... This is an UNSTABLE release. The release has significant modifications for data processing - in case of troubles go back to 1.0.0-rc.144. * jfjoch_broker: Improve azimuthal integration (add <I^2> calculation) * jfjoch_broker: Fixes around indexing, aiming to handle multi-lattice crystals (work in progress, it is not fully integrated) * jfjoch_writer: Save mean(I), stddev(I), and count(I) for each azimuthal bin Reviewed-on: #58	2026-06-08 08:30:35 +02:00
leonarski_f	75de40f52b	v1.0.0-rc.147 (#57) ... This is an UNSTABLE release. The release has significant modifications for data processing - in case of troubles go back to 1.0.0-rc.144. * jfjoch_viewer: Add reciprocal space viewer * jfjoch_process: Two pass algorithm that does spot finding/indexing + integration of full dataset * jfjoch_process: Improve logic for rotation indexer, to make execution more deterministic (still work in progress) Reviewed-on: #57 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch> Co-committed-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-06-02 11:49:24 +02:00
leonarski_f	fc68a9baed	v1.0.0-rc.146 (#56) ... This is an UNSTABLE release. The release has significant modifications for data processing - in case of troubles go back to 1.0.0-rc.144. jfjoch_process: Generate a dedicated file (_process.h5), which can be used as a replacement for the _master.h5 file for a reanalyzed dataset. jfjoch_process: Improve the performance of scaling and merging, implement on the fly scaling. jfjoch_writer: All final data analysis results are repopulated in the _master.h5 file. jfjoch_scale: Dedicated tool for rescaling/merging existing data. jfjoch_viewer: Fix bugs where pixel labels where displayed on a wrong pixel. WARNING! Scaling and merging are experimental at the moment, and may not provide reasonable results for the time being. Reviewed-on: #56	2026-05-28 18:48:35 +02:00
leonarski_f	87fde1b32e	v1.0.0-rc.142 (#52) ... This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.132. * Support for newer CUDA architectures (notably Blackwell); minimum CUDA version 12.8 * Minor changes to jfjoch_process, jfjoch_fpga_test and jfjoch_lite_perf_test to make them more consistent Reviewed-on: #52 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch> Co-committed-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-04-30 16:47:53 +02:00
leonarski_f	d760b12a18	v1.0.0-rc.141 (#51) ... This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.132. * jfjoch_broker: Azimuthal integration mapping is generated with parallel computations, significantly reducing setup times * frontend: Fix selection of FFTW in indexing settings Reviewed-on: #51 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch> Co-committed-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-04-30 13:04:54 +02:00
leonarski_f	239a441ee6	v1.0.0-rc.140 (#50) ... This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.132. * jfjoch_broker: For DECTRIS detectors, ZeroMQ link is persistent, to save time for establishing new connection * jfjoch_broker: Minor bug fixes for rare conditions Reviewed-on: #50	2026-04-29 21:40:22 +02:00
leonarski_f	4878318c27	v1.0.0-rc.139 (#49) ... This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.132. * jfjoch_broker: Further reduce startup time for DECTRIS detectors by selectively modifying SIMPLON parameters on `/start` * jfjoch_broker: Further reduce startup time for DECTRIS detectors by not setting beam center and detector distance via SIMPLON API on '/start' * jfjoch_broker: Add an extra message to ZeroMQ puller ready to monitor Lite worklow preparation time * jfjoch_broker: Image buffer configuration is postponed for Lite receiver flow till start message is received * jfjoch_broker: Use nanoseconds internally for frame/image/readout time * jfjoch_broker: Extra messages added for receiver operation (to be removed after debugging finished) * jfojch_broker: Improve profiling of different data analysis steps * jfjoch_broker: Record integration reflection count * jfjoch_broker: Fix bug where ZeroMQ preview frequency was confusing time units (micro vs. milliseconds) * jfjoch_broker: Fix bug where '/wait_till_done' got deadlocked * jfjoch_writer: Fix confusion between NaN and zero in floating-point datasets **Breaking changes**: detector definition is now using nanoseconds to define minimum frame time, minimum count time and readout time. Reviewed-on: #49	2026-04-29 09:50:50 +02:00
leonarski_fandtakaba_k	230480e390	v1.0.0-rc.138 (#48) ... This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.132. jfjoch_broker: Cleanup DECTRIS start-up code to enable a shorter start time jfjoch_broker: Allow for asynchronous start to allow overlapping detector configuration with other beamline preparations jfjoch_broker: Goniometer axis name is converted to lowercase jfjoch_broker: Fix bug, where wrong HTTP error codes were returned jfjoch_broker: Improve sigma estimation during merging (K. Takaba) --------- Co-authored-by: takaba_k <kiyofumi.takaba@psi.ch> Reviewed-on: #48 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch> Co-committed-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-04-27 19:56:14 +02:00
leonarski_f	c981e1b91c	v1.0.0-rc.137 (#46) ... This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.132. * jfjoch_broker: Better track time for each operation in the processing stack * jfjoch_broker: Rewrite preprocessing of diffraction images in the non-FPGA workflow to better use GPUs (work in progress) * jfjoch_broker: Remove ROI calculation in the non-FPGA workflow (work in progress) * jfjoch_viewer: Toolbar displays image number starting from 1 (instead of 0) Reviewed-on: #46	2026-04-25 19:59:21 +02:00
leonarski_f	c1c170112c	v1.0.0-rc.136 (#45) ... This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.132. * jfjoch_broker: Improve logic regarding indexing architecture and thread pools (work in progress). Reviewed-on: #45	2026-04-20 11:54:33 +02:00
leonarski_f	bb9f5c715f	v1.0.0-rc.135 (#44) ... This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.132. * Multiple small bug fixes scattered across the whole code base. (detected with GPT-5.4) * jfjoch_viewer: Improve image render performance Reviewed-on: #44 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch> Co-committed-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-04-16 11:59:59 +02:00
leonarski_f	6133da1377	v1.0.0-rc.133 ... This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.132. * jfjoch_broker: Use httplib for HTTP server instead of Pistache * jfjoch_broker: Drop OpenSSL support * jfjoch_broker: Base work for multi-lattice support in the future * Update dependencies to more recent versions (spdlog, HDF5, Catch2, httplib) Reviewed-on: #41	2026-03-26 20:50:33 +01:00
leonarski_f	166fcdb68f	v1.0.0-rc.131 (#39) ... This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.124. * jfjoch_broker: Fix bug in saving JUNGFRAU calibration (pedestal/pedestalRMS) * jfjoch_viewer: Fix calibration (pedestal) images being open flipped * jfjoch_process: Add space group detection (EXPERIMENTAL) Reviewed-on: #39	2026-03-07 11:34:04 +01:00
leonarski_f	928789a67c	v1.0.0-rc.130 (#37) ... This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.124. * jfjoch_broker: Rotation indexer has two retries if failes * jfjoch_broker: Rotation indexer handles small number of rotation images (like test shot) * jfjoch_broker: Integration calculates background mask based on R2 radius * jfjoch_process: HDF5 files are not saved by default Reviewed-on: #37	2026-03-06 14:38:56 +01:00
leonarski_f	64002f1e29	v1.0.0-rc.129 (#36) ... This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.124. * jfjoch_broker: Significant improvements in TCP image socket, as a viable alternative for ZeroMQ sockets (only a single port on broker side, dynamically change number of writers, acknowledgments for written files) * jfjoch_broker: Delta phi is calculated also for still data in Bragg prediction * jfjoch_broker: Image pusher statistics are accessible via the REST interface * jfjoch_writer: Supports TCP image socket and for these auto-forking option Reviewed-on: #36 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch> Co-committed-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-03-05 22:13:12 +01:00
leonarski_f	3036b1d37f	v1.0.0-rc.128 (#35) ... This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.124. * jfjoch_broker: Handle properly reuse of image buffer locations * jfjoch_broker: Fix bug in counting idle slots * jfjoch_broker: Force obtuse angle for monoclinic cells * jfjoch_process: Change scaling refinement tolerance Reviewed-on: #35 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch> Co-committed-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-03-03 22:24:44 +01:00
leonarski_f	f3e0a15d26	v1.0.0-rc.127 (#34) ... This is an UNSTABLE release. The release has significant modifications and bug fixes, if things go wrong, it is better to revert to 1.0.0-rc.124. * jfjoch_broker: Default EIGER readout time is 20 microseconds * jfjoch_broker: Multiple improvements regarding performance * jfjoch_broker: Image buffer allows to track frames in preparation and sending * jfjoch_broker: Dedicated thread for ZeroMQ transmission to better utilize the image buffer * jfjoch_broker: Experimental implementation of transmission with raw TCP/IP sockets * jfjoch_writer: Fixes regarding properly closing files in long data collections * jfjoch_process: Scale & merge has been significantly improved, but it is not yet integrated into mainstream code Reviewed-on: #34	2026-03-02 15:57:12 +01:00
leonarski_f	32b681e591	v1.0.0-rc.126 (#33) ... This is an UNSTABLE release. If things go wrong with analysis, it is better to revert to 1.0.0-rc.124. * jfjoch_broker: Fix bug for monoclinic space groups being wrongly refined when beta is much different from 90 deg. Reviewed-on: #33 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch> Co-committed-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-02-19 07:01:38 +01:00
leonarski_f	1ab257af6c	v1.0.0-rc.125 (#32) ... This is an UNSTABLE release. This version adds scalign and merging. These are experimental at the moment, and should not be used for production analysis. If things go wrong with analysis, it is better to revert to 1.0.0-rc.124. * jfjoch_broker: Improve logic on switching on/off spot finding * jfjoch_broker: Increase maximum spot count for FFBIDX to 65536 * jfjoch_broker: Increase default maximum unit cell for FFT to 500 A (could have performance impact, TBD) * jfjoch_process: Add scalign and merging functionality - program is experimental at the moment and should not be used for production analysis * jfjoch_viewer: Display partiality and reciprocal Lorentz-polarization correction for each reflection * jfjoch_writer: Save more information about each reflection Reviewed-on: #32 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch> Co-committed-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-02-18 16:17:21 +01:00