v1.0.0-rc.148 #58

Merged

leonarski_f merged 46 commits from 2606-azint into main 2026-06-08 08:30:35 +02:00

Conversation 0 Commits 46 Files Changed 390

+1730 -1251

leonarski_f commented 2026-06-07 22:17:43 +02:00

Owner

Copy Link

Copy Source

This is an UNSTABLE release. The release has significant modifications for data processing - in case of troubles go back to 1.0.0-rc.144.

• jfjoch_broker: Improve azimuthal integration (add <I^2> calculation)
• jfjoch_broker: Fixes around indexing, aiming to handle multi-lattice crystals (work in progress, it is not fully integrated)
• jfjoch_writer: Save mean(I), stddev(I), and count(I) for each azimuthal bin

This is an UNSTABLE release. The release has significant modifications for data processing - in case of troubles go back to 1.0.0-rc.144. * jfjoch_broker: Improve azimuthal integration (add <I^2> calculation) * jfjoch_broker: Fixes around indexing, aiming to handle multi-lattice crystals (work in progress, it is not fully integrated) * jfjoch_writer: Save mean(I), stddev(I), and count(I) for each azimuthal bin

leonarski_f added 46 commits 2026-06-07 22:17:44 +02:00

AzimuthalIntegrationProfile: Add standard deviation + save pixel count + improve handling of special cases (missing image) 953089009f

Save azimuthal integration map a36caa4ca7

Save Pixel-to-bin map in JFJochReceiver, and write it compressed in the master file 57fc38195e

AzIntEngine: Fixes 4e4b0a9b33

jfjoch_azint_test: Add temporary tool to benchmark azint dcef5469e8

Make x86-64-v3 default architecture ffcf037205

jfjoch_test: Reduce precision requirements after switching to -march=x86_64-v3. 4aac2aabd3

Architecture is set in CI file, not in CMake file (so one can still compile with mtune=native, march=native c1f884279d

FFTIndexerTest: Update test to sort input vectors + remove old, unused file duplicating this test ce23a6ccf2

CHANGELOG 1b1df4a605

CrystalLattice: Add Niggli reduction option ab9db988dd

FFTIndexer: Use Niggli Reduction 5ffe44892c

jfjoch_process: Allow to force lattice for rotation indexing 14b6816552

FFTIndexer: Fixes to handle better multiple lattices 47a066d631

LatticeSearch: Primitive reduced should return reduced value 56144a6e5f

LatticeSearch: Return reindex matrix fd9a9429b5

MultiLatticeSearch: Add function 736f5f2405

CrystalLattice: Print function 0c3efda5ac

CrystalLattice: Don't fix handedness after multiplying 1a3403a25c

Replace header guards with #pragma once (only keep ones in HLS/driver code) 21a8ea51ee

UDPSimulator: Fix header guards 64e6b32e1d

MultiLatticeSearch: Explore all valid sign flips when comparing with reference cell 02ecf5c32e

JFJochReceiver: Plot compression ratio 1fc8070118

Adding machinery to include indexing lattice count ae67b36160

MultiLatticeSearch: Remove reduced function 74c1a7a828

Add mechanics to save per spot lattice information (WIP) 83f467d4dc

MultiLatticeSearch: Work in progress b49c7a766d

MultiLatticeSearch: Works 3522568d49

RotationIndexer: Identify and save additional lattices 3bcfc08b21

IndexingSettings: Define limit for extra lattices 5780548964

RotationIndexer: Add refinement of extra lattices + limit number of extra lattices c3bb5e1f5f

Messages: Add extra information on additional lattices c1e9babe13

Multi lattice search: WIP - Integration added by Claude Opus (doesn't work :) ) 4c45d1c835

Multi lattice search: Small changes (WIP) f9eee954de

CBOR: Fixes ac7e0e5145

CBOR: Fixes bf305b33d1

Fix fa9b5c685f

Fixes from Claude Code (to be tested) 83377ef3d8

IndexingSettings: Figure out max extra lattices in StartMessage + make it changeable 2bffb38c82

AzIntEngine: Fix member initialization order UB ... f40197561c

Members are constructed in declaration order, not initializer-list
order. azint_bins and npixel were computed from the integration
reference before that reference member was bound, which is undefined
behavior and could leave both with garbage values (propagating to
GPU buffer sizes). Reorder declarations so integration is bound first.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

AzIntEngineCPU: Skip masked/saturated pixels ... 1d6d50c162

The GPU kernels exclude sentinel pixels (saturated/masked), but the
CPU path summed them blindly, corrupting the azimuthal integration
result and diverging from the GPU output. Skip them on the CPU too,
deriving the sentinels from the pixel type via std::numeric_limits:
the max value (saturated) for any type, plus the min value
(masked/bad) for signed types.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

AzIntEngine: Use integer fill value for azint_count ... 8e4cf98f8a

azint_count is std::vector<uint32_t>; initialize it with 0u instead
of the float literal 0.0f.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

AzIntEngineGPU: Check CUDA errors in constructor ... aa50e60f3c

cudaGetDeviceProperties and the two host-to-device cudaMemcpy calls
in the constructor were not error-checked, unlike the calls in Run().
Wrap them in cuda_err() so failures throw instead of passing silently.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

VERSION: 1.0.0-rc.148 5edf7c7907

NXmx: Save rotationExtraLattices (if present) 1ca8fec789

Include lattice count 8a059f3b94

leonarski_f merged commit cc3eb8352c into main 2026-06-08 08:30:35 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

appleb_m (appleb_m) buntschu_d (buntschu_d) duan_j (duan_j) glettig_w (glettig_w) gotthard_g (gotthard_g) leonarski_f (leonarski_f) takaba_k (takaba_k)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mx/Jungfraujoch#58