Add logic for EXT/EN to DDG and MCS for flOMNI #136
wakonig_k
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: bec/csaxs_bec#136
Reference in New Issue
Block a user
Delete Branch "feat/add_flomni_ext_en"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
PR to extend the logic on the DDG and the MCS card for operation with flOMNI. THe implementation now supports flOMNI fly scans, for which the mcs card is setup in a different fashion. We also configure the DDG differently in that scenario. In addition, we added the logic to the two devices to be able to cope with EXT/EN signals configured on the DDG. This is a first working version, but should be crosschecked for other built-in fly scans to make sure that they still work as expected.
Looks great to me. One thing I am currently wondering is the DDG line where we removed the shutter close time.
d = a + exp_time * burst_count + 1ms (to allow the shutter to close)
Removing the 1 ms makes sense because the shutter shall start closing immediately after the exposure ends.
Having some additional delay on another channel to account for the close time could be used to block the delay generator for the full shutter close time of 2 ms. Then the entire setup would be in a clean state for opening the shutter again.
With the new fast shutter system, I actually execute the full close movement before starting the open movement. If the trigger signal for opening comes to early, the shutter will still open, but then it will not take 2 ms but the full close open cycle of 2+2 ms.