default value for BASH_LOADABLES_PATH; other minor changes

CWRU/CWRU.chlog

@@ -9975,3 +9975,28 @@ parse.y:
 				    ---
 arrayfunc.c
 	- unbind_array_element: use VA_NOEXPAND instead of literal 1
+
+				    4/7
+				    ---
+lib/readline/funmap.c
+	- default_funmap: add missing `vi-undo' to the list of vi-mode bindable
+	  functions. Reported by Xirui Zhao <quinean@icloud.com>
+
+				    4/8
+				    ---
+
+config-top.h
+	- DEFAULT_LOADABLE_BUILTINS_PATH: default value for BASH_LOADABLES_PATH
+
+doc/{bash.1,bashref.texi}
+	- enable: note that it uses $BASH_LOADABLES_PATH, and that the default
+	  is system-dependent
+
+variables.c
+	- initialize_shell_variables: initialize BASH_LOADABLES_PATH to the
+	  default given in DEFAULT_LOADABLE_BUILTINS_PATH
+
+				   4/12
+				   ----
+doc/{bash.1,bashref.texi}
+	- add link to git master tar file as a place to get the current version

arrayfunc.c

@@ -1057,8 +1057,14 @@ unbind_array_element (var, sub, flags)
     {
       if (array_p (var) || assoc_p (var))
 	{
-	  unbind_variable (var->name);	/* XXX -- {array,assoc}_flush ? */
-	  return (0);
+#if 0	/* TAG: bash-5.2 */
+	  if (flags & VA_ALLOWALL)
+#endif
+	    {
+	      unbind_variable (var->name);	/* XXX -- {array,assoc}_flush ? */
+	      return (0);
+	    }
+	  /* otherwise we fall through and try to unset element `@' or `*' */
 	}
       else
 	return -2;	/* don't allow this to unset scalar variables */

arrayfunc.h

@@ -41,7 +41,8 @@ extern int array_expand_once;
 #define AV_NOEXPAND	0x020	/* don't run assoc subscripts through word expansion */
 
 /* Flags for valid_array_reference. Value 1 is reserved for skipsubscript().
-   Also used by unbind_array_element. */
+   Also used by unbind_array_element, which is currently the only function
+   that uses VA_ALLOWALL. */
 #define VA_NOEXPAND	0x001
 #define VA_ONEWORD	0x002
 #define VA_ALLOWALL	0x004	/* allow @ to mean all elements of the array */

builtins/Makefile.in

@@ -707,3 +707,14 @@ suspend.o: ${topdir}/bashintl.h ${LIBINTL_H} $(BASHINCDIR)/gettext.h
 type.o: ${topdir}/bashintl.h ${LIBINTL_H} $(BASHINCDIR)/gettext.h
 ulimit.o: ${topdir}/bashintl.h ${LIBINTL_H} $(BASHINCDIR)/gettext.h
 umask.o: ${topdir}/bashintl.h ${LIBINTL_H} $(BASHINCDIR)/gettext.h
+
+cd.o: $(topdir)/config-top.h
+command.o: $(topdir)/config-top.h
+common.o: $(topdir)/config-top.h
+declare.o: $(topdir)/config-top.h
+break.o: $(topdir)/config-top.h
+echo.o: $(topdir)/config-top.h
+evalstring.o: $(topdir)/config-top.h
+exit.o: $(topdir)/config-top.h
+kill.o: $(topdir)/config-top.h
+shopt.o: $(topdir)/config-top.h

builtins/common.c

@@ -935,7 +935,7 @@ find_special_builtin (name)
   			current_builtin->function :
   			(sh_builtin_func_t *)NULL);
 }
-  
+
 static int
 shell_builtin_compare (sbp1, sbp2)
      struct builtin *sbp1, *sbp2;

config-top.h

@@ -77,6 +77,12 @@
   "/bin:/usr/bin:/sbin:/usr/sbin:/etc:/usr/etc"
 #endif
 
+/* The default path for enable -f */
+#ifndef DEFAULT_LOADABLE_BUILTINS_PATH
+#define DEFAULT_LOADABLE_BUILTINS_PATH \
+  "/usr/local/lib/bash:/usr/lib/bash:/opt/local/lib/bash:/usr/pkg/lib/bash:/opt/pkg/lib/bash:."
+#endif
+
 /* Default primary and secondary prompt strings. */
 #define PPROMPT "\\s-\\v\\$ "
 #define SPROMPT "> "

doc/bash.1

@@ -3858,7 +3858,7 @@ the syntax \fB[.\fP\fIsymbol\fP\fB.]\fP matches the collating symbol
 .PD
 .PP
 If the \fBextglob\fP shell option is enabled using the \fBshopt\fP
-builtin, several extended pattern matching operators are recognized.
+builtin, the shell recognizes several extended pattern matching operators.
 In the following description, a \fIpattern-list\fP is a list of one
 or more patterns separated by a \fB|\fP.
 Composite patterns may be formed using one or more of the following
@@ -8381,7 +8381,11 @@ option means to load the new builtin command
 .I name
 from shared object
 .IR filename ,
-on systems that support dynamic loading.  The
+on systems that support dynamic loading.
+Bash will use the value of the \fBBASH_LOADABLES_PATH\fP variable as a
+colon-separated list of directories in which to search for \fIfilename\fP.
+The default is system-dependent.
+The
 .B \-d
 option will delete a builtin previously loaded with
 .BR \-f .
@@ -11291,7 +11295,8 @@ make sure that it really is a bug, and that it appears in the latest
 version of
 .BR bash .
 The latest version is always available from
-\fIftp://ftp.gnu.org/pub/gnu/bash/\fP.
+\fIftp://ftp.gnu.org/pub/gnu/bash/\fP and
+\fIhttp://git.savannah.gnu.org/cgit/bash.git/snapshot/bash-master.tar.gz\fP.
 .PP
 Once you have determined that a bug actually exists, use the
 .I bashbug

doc/bashref.texi

@@ -2870,7 +2870,7 @@ matches the collating symbol @var{symbol}.
 @end table
 
 If the @code{extglob} shell option is enabled using the @code{shopt}
-builtin, several extended pattern matching operators are recognized.
+builtin, the shell recognizes several extended pattern matching operators.
 In the following description, a @var{pattern-list} is a list of one
 or more patterns separated by a @samp{|}.
 Composite patterns may be formed using one or more of the following
@@ -4590,6 +4590,9 @@ each builtin with an indication of whether or not it is enabled.
 
 The @option{-f} option means to load the new builtin command @var{name}
 from shared object @var{filename}, on systems that support dynamic loading.
+Bash will use the value of the @enable{BASH_LOADABLES_PATH} variable as a
+colon-separated list of directories in which to search for @var{filename}.
+The default is system-dependent.
 The @option{-d} option will delete a builtin loaded with @option{-f}.
 
 If there are no options, a list of the shell builtins is displayed.
@@ -9294,7 +9297,8 @@ But first, you should
 make sure that it really is a bug, and that it appears in the latest
 version of Bash.
 The latest version of Bash is always available for FTP from
-@uref{ftp://ftp.gnu.org/pub/gnu/bash/}.
+@uref{ftp://ftp.gnu.org/pub/gnu/bash/} and from
+@uref{http://git.savannah.gnu.org/cgit/bash.git/snapshot/bash-master.tar.gz}.
 
 Once you have determined that a bug actually exists, use the
 @code{bashbug} command to submit a bug report.

lib/readline/funmap.c

@@ -199,6 +199,7 @@ static const FUNMAP default_funmap[] = {
   { "vi-set-mark", rl_vi_set_mark },
   { "vi-subst", rl_vi_subst },
   { "vi-tilde-expand", rl_vi_tilde_expand },
+  { "vi-undo", rl_vi_undo },
   { "vi-unix-word-rubout", rl_vi_unix_word_rubout },
   { "vi-yank-arg", rl_vi_yank_arg },
   { "vi-yank-pop", rl_vi_yank_pop },

tests/RUN-ONE-TEST

@@ -1,4 +1,4 @@
-BUILD_DIR=/usr/local/build/bash/bash-current
+BUILD_DIR=/usr/local/build/chet/bash/bash-current
 THIS_SH=$BUILD_DIR/bash
 PATH=$PATH:$BUILD_DIR
 

variables.c

@@ -664,6 +664,8 @@ initialize_shell_variables (env, privmode)
   /* Get the user's real and effective user ids. */
   uidset ();
 
+  temp_var = set_if_not ("BASH_LOADABLES_PATH", DEFAULT_LOADABLE_BUILTINS_PATH);
+
   temp_var = find_variable ("BASH_XTRACEFD");
   if (temp_var && imported_p (temp_var))
     sv_xtracefd (temp_var->name);