mx/AareDAQ
0
1
Fork 0
Code Issues 52 Pull Requests Actions Packages Projects Releases 74 Wiki Activity

fix: only set transmission when it actually differs #218

Merged
leonarski_f merged 1 commits from fix/transmission-set-condition into main 2026-09-10 17:55:51 +02:00
Conversation 1 Commits 1 Files Changed 1
+1 -1
leonarski_f commented 2026-09-10 17:54:08 +02:00
Owner
Copy Link
Copy Source
No description provided.
leonarski_f added 1 commit 2026-09-10 17:54:09 +02:00
fix: only set transmission when it actually differs
CI / lint (pull_request) Successful in 37s
Details
CI / test (3.12) (pull_request) Successful in 1m3s
Details
CI / test (3.13) (pull_request) Successful in 1m5s
Details
CI / test (3.14) (pull_request) Successful in 1m4s
Details
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 1m10s
Details
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 1m17s
Details
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 1m21s
Details
CI / test-with-coverage (pull_request) Successful in 1m31s
Details
CI / lint (push) Successful in 32s
Details
Docs build and publish / docker (push) Successful in 14s
Details
CI / coverage-analysis (pull_request) Successful in 4s
Details
CI / test (3.12) (push) Canceled after 45s
Details
CI / test (3.13) (push) Canceled after 41s
Details
CI / test (3.14) (push) Canceled after 40s
Details
CI / test-with-beamline-plugins (pxi_bec) (push) Canceled after 36s
Details
CI / test-with-beamline-plugins (pxii_bec) (push) Canceled after 35s
Details
CI / test-with-beamline-plugins (pxiii_bec) (push) Canceled after 31s
Details
CI / test-with-coverage (push) Canceled after 30s
Details
CI / coverage-analysis (push) Canceled after 0s
Details
Build and Publish / release (push) Successful in 35s
Details
702eb7d9f9 
The guard introduced with the transmission IOC workaround was inverted:
`abs(request - readback) < 0.001` fires only when the beamline is already
at the requested value, so any real transmission change was skipped and
collections ran at whatever transmission happened to be set.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ni1Uhb1WqzpXPwcYsvqnH1
leonarski_f scheduled this pull request to auto merge when all checks succeed 2026-09-10 17:54:24 +02:00
leonarski_f merged commit 702eb7d9f9 into main 2026-09-10 17:55:51 +02:00
gitea-actions bot commented 2026-09-10 17:56:29 +02:00
Copy Link
Copy Source

Coverage report (automated)

Total line + branch coverage: 51%
Diff coverage vs main: 100% (minimum 80%)

Full report: coverage artifact on this run.

Coverage report (automated) Total line + branch coverage: 51% Diff coverage vs main: 100% (minimum 80%) Full report: coverage artifact on this run.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
buntschu_d (buntschu_d) duan_j (duan_j) glettig_w (glettig_w) gobbo_a (gobbo_a) gotthard_g (gotthard_g) leonarski_f (leonarski_f) mx-gitea olieric (olieric) perl_d (perl_d) takaba_k (takaba_k) wang_m (wang_m)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mx/AareDAQ#218