mx/AareDAQ
0
1
Fork 0
Code Issues 52 Pull Requests 2 Actions Packages Projects Releases 77 Wiki Activity

fix: only set transmission when it actually differs
CI / lint (pull_request) Successful in 37s
Details
CI / test (3.12) (pull_request) Successful in 1m3s
Details
CI / test (3.13) (pull_request) Successful in 1m5s
Details
CI / test (3.14) (pull_request) Successful in 1m4s
Details
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 1m10s
Details
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 1m17s
Details
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 1m21s
Details
CI / test-with-coverage (pull_request) Successful in 1m31s
Details
CI / lint (push) Successful in 32s
Details
Docs build and publish / docker (push) Successful in 14s
Details
CI / coverage-analysis (pull_request) Successful in 4s
Details
CI / test (3.12) (push) Canceled after 45s
Details
CI / test (3.13) (push) Canceled after 41s
Details
CI / test (3.14) (push) Canceled after 40s
Details
CI / test-with-beamline-plugins (pxi_bec) (push) Canceled after 36s
Details
CI / test-with-beamline-plugins (pxii_bec) (push) Canceled after 35s
Details
CI / test-with-beamline-plugins (pxiii_bec) (push) Canceled after 31s
Details
CI / test-with-coverage (push) Canceled after 30s
Details
CI / coverage-analysis (push) Canceled after 0s
Details
Build and Publish / release (push) Successful in 35s
Details

Browse Source 
The guard introduced with the transmission IOC workaround was inverted:
`abs(request - readback) < 0.001` fires only when the beamline is already
at the requested value, so any real transmission change was skipped and
collections ran at whatever transmission happened to be set.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ni1Uhb1WqzpXPwcYsvqnH1
This commit was merged in pull request #218.
This commit is contained in:
leonarski_f
2026-09-10 17:53:01 +02:00
co-authored by Claude Opus 5
parent 59afc2d9eb
commit 702eb7d9f9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/aare/daq/daq.py
+1 -1
View File
@@ -1962,7 +1962,7 @@ class AareDAQ:
if (
request.transmission is not None
and abs(request.transmission - self._devs.transmission) < 0.001
and abs(request.transmission - self._devs.transmission) > 0.001
):
logger.info(f"requesting transmission to move to {request.transmission}")
self._devs.transmission = request.transmission