motion/ecmc_plugin_socketcan
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve error printouts for read and write

Browse Source
This commit is contained in:
Anders Sandstrom
2021-03-24 09:46:46 +01:00
parent 14cc799609
commit 256f0ef749
3 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
ecmc_plugin_socketcan/ecmc_plugin_socketcanApp/src/ecmcSocketCAN.cpp
View File

@@ -203,9 +203,19 @@ void ecmcSocketCAN::doReadWorker() {
}
// Wait for new CAN frame
int bytes = read(socketId_, &rxmsg_, sizeof(rxmsg_));
// error in read()
if(bytes == -1) {
errorCode_ = errno;
printf("ecmcSocketCAN: read() fail with error %s.\n", strerror(errno));
errorCode_ = errno;
printf("ecmcSocketCAN: read() fail with error: %s, (0x%x).\n", strerror(errno),errno);
refreshNeeded_ = 1;
continue;
}
// incomplete read()
if(bytes != sizeof(rxmsg_)) {
printf("ecmcSocketCAN: read() fail with error: Incomplete read, not a full can frame (0x%x).\n",ECMC_CAN_ERROR_READ_INCOMPLETE);
errorCode_ = ECMC_CAN_ERROR_READ_INCOMPLETE;
refreshNeeded_ = 1;
continue;
}

1
ecmc_plugin_socketcan/ecmc_plugin_socketcanApp/src/ecmcSocketCAN.h
View File

@@ -42,6 +42,7 @@
#define ECMC_CAN_ERROR_WRITE_NO_DATA 12
#define ECMC_CAN_ERROR_WRITE_INCOMPLETE 13
#define ECMC_CAN_ERROR_WRITE_BUFFER_NULL 14
#define ECMC_CAN_ERROR_READ_INCOMPLETE 15
class ecmcSocketCAN {
public:

6
ecmc_plugin_socketcan/ecmc_plugin_socketcanApp/src/ecmcSocketCANWriteBuffer.cpp
View File

@@ -185,12 +185,14 @@ int ecmcSocketCANWriteBuffer::writeCAN(can_frame *frame){
// Maybe need to add the size to write here.. if struct is not full, hmm?!
int nbytes = write(socketId_, frame, sizeof(struct can_frame));
if(nbytes == -1) {
printf("ecmcSocketCAN: write() fail with error %s.\n", strerror(errno));
return ECMC_CAN_ERROR_WRITE_INCOMPLETE;
printf("ecmcSocketCAN: write() fail with error: %s (0x%x).\n", strerror(errno),errno);
return errno;
}
if (nbytes!= sizeof(struct can_frame)) {
printf("ecmcSocketCAN: write() fail with error: Incomplete write(), not a full can frame (0x%x).\n",ECMC_CAN_ERROR_WRITE_INCOMPLETE);
return ECMC_CAN_ERROR_WRITE_INCOMPLETE;
}