lin-midas-drivers/itc_pressure_optimizer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Code Review #1 #1

New Issue
Closed
opened 2026-07-24 13:55:25 +02:00 by ponsin_h · 0 comments
ponsin_h commented 2026-07-24 13:55:25 +02:00
Owner
Copy Link
Copy Source
  • remove unused demand key
  • remove "Variox"
  • Explain that dotted line is data & execution going through the even bus
  • DemandHandlerConfig typo in namespace
  • swap to put public in front of private
  • add Enable in front of data type
  • constante is without a "e" in English
  • Comment : "maximal" with a cap M
  • uncaped => uncapped
  • cappedPressure : use std::clamp
  • DemandHandler : ensure that min < max
  • remove branchement of c2contrib (refactoring math) : (-c2contrib * cachedConstante1)
  • make average time window changeable
  • make Average inner class
  • OutputHandler can stay silent, because we print a error
  • CI to build
  • Print template for DemandHandler
  • Print template for SettingsHandler
  • Print template for
- [x] remove unused demand key - [x] remove "Variox" - [x] Explain that dotted line is data & execution going through the even bus - [x] DemandHandlerConfig typo in namespace - [x] swap to put public in front of private - [x] add Enable in front of data type - [x] constante is without a "e" in English - [x] Comment : "maximal" with a cap M - [x] uncaped => uncapped - [x] cappedPressure : use std::clamp - [x] DemandHandler : ensure that min < max - [x] remove branchement of c2contrib (refactoring math) : (-c2contrib * cachedConstante1) - [x] make average time window changeable - [x] make Average inner class - [x] OutputHandler can stay silent, because we print a error - [x] CI to build - [x] Print template for DemandHandler - [x] Print template for SettingsHandler - [x] Print template for
Sign in to join this conversation.
oop_is_the_way
Branches Tags
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
krieger_j (krieger_j) mathis_s (mathis_s) mueller_r4 (mueller_r4) ponsin_h (ponsin_h) soederqvist_a (soederqvist_a) wall_e (wall_e)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lin-midas-drivers/itc_pressure_optimizer#1