Compare commits

...

2 Commits

Author SHA1 Message Date
mathis_s c7a2a32c73 Bugfix
Test And Build / Lint (push) Failing after 4s
Test And Build / Build (push) Successful in 8s
2026-05-11 11:20:52 +02:00
mathis_s 21cd9320ee Fixed bug in enable method and adjusted PowerCycleTimeout value
Test And Build / Lint (push) Failing after 5s
Test And Build / Build (push) Failing after 6s
2026-05-11 11:16:59 +02:00
+8 -10
View File
@@ -38,7 +38,7 @@ A special communication timeout is used in the following two cases:
2) First move command after enabling the motor 2) First move command after enabling the motor
This is due to MasterMACS running a powerup cycle, which can delay the answer. This is due to MasterMACS running a powerup cycle, which can delay the answer.
*/ */
#define PowerCycleTimeout 10.0 // Value in seconds #define PowerCycleTimeout 6.0 // Value in seconds
/* /*
Contains all instances of turboPmacAxis which have been created and is used in Contains all instances of turboPmacAxis which have been created and is used in
@@ -1119,7 +1119,6 @@ asynStatus masterMacsAxis::readEncoderType() {
asynStatus masterMacsAxis::enable(bool on) { asynStatus masterMacsAxis::enable(bool on) {
int timeout_enable_disable = 2;
char msg[pC_->MAXBUF_]; char msg[pC_->MAXBUF_];
// ========================================================================= // =========================================================================
@@ -1177,8 +1176,7 @@ asynStatus masterMacsAxis::enable(bool on) {
// hence we wait for a custom timespan in seconds instead of // hence we wait for a custom timespan in seconds instead of
// pC_->comTimeout_ // pC_->comTimeout_
double timeout = pC_->comTimeout(); double timeout = pC_->comTimeout();
if (pMasterMacsA_->targetReachedUninitialized && if (timeout < PowerCycleTimeout) {
timeout < PowerCycleTimeout) {
timeout = PowerCycleTimeout; timeout = PowerCycleTimeout;
} }
@@ -1190,7 +1188,7 @@ asynStatus masterMacsAxis::enable(bool on) {
// Query the axis status every few milliseconds until the axis has been // Query the axis status every few milliseconds until the axis has been
// enabled or until the timeout has been reached // enabled or until the timeout has been reached
int startTime = time(NULL); int startTime = time(NULL);
while (time(NULL) < startTime + timeout_enable_disable) { while (time(NULL) < startTime + PowerCycleTimeout) {
// Read the axis status // Read the axis status
usleep(100000); usleep(100000);
@@ -1207,17 +1205,17 @@ asynStatus masterMacsAxis::enable(bool on) {
} }
} }
// Failed to change axis status within timeout_enable_disable => Send a // Failed to change axis status within PowerCycleTimeout => Send a
// corresponding message // corresponding message
asynPrint(pC_->pasynUser(), ASYN_TRACE_ERROR, asynPrint(pC_->pasynUser(), ASYN_TRACE_ERROR,
"Controller \"%s\", axis %d => %s, line %d:\nFailed to %s axis " "Controller \"%s\", axis %d => %s, line %d:\nFailed to %s axis "
"within %d seconds\n", "within %f seconds\n",
pC_->portName, axisNo_, __PRETTY_FUNCTION__, __LINE__, pC_->portName, axisNo_, __PRETTY_FUNCTION__, __LINE__,
on ? "enable" : "disable", timeout_enable_disable); on ? "enable" : "disable", PowerCycleTimeout);
// Output message to user // Output message to user
snprintf(msg, sizeof(msg), "Failed to %s within %d seconds", snprintf(msg, sizeof(msg), "Failed to %s within %f seconds",
on ? "enable" : "disable", timeout_enable_disable); on ? "enable" : "disable", PowerCycleTimeout);
setAxisParamChecked(this, motorMessageText, msg); setAxisParamChecked(this, motorMessageText, msg);
return asynError; return asynError;