- added rosenblatttransform
- added 3x3 eta methods
- interpolation can be used with various eta functions
- added documentation for interpolation, eta calculation
- exposed full eta struct in python
- disable ClusterFinder for 2x2 clusters
- factory function for ClusterVector
---------
Co-authored-by: Dhanya Thattil <dhanya.thattil@psi.ch>
Co-authored-by: Erik Fröjdh <erik.frojdh@psi.ch>
Saverio requested that max_sum_2x2 exposes index information in python
- max_sum_2x2 returns a corner as index
- replaced eta corner with corner enum class
- max_sum_2x2 now returns index as well in python
- added link to Documenation in README
Note: Some Tests fail in EtaCalculation due to previous PR about
updating Eta 2x2 will fix in other PR
Adapted eta interpolation:
### Issues with previous interpolation:
## Eta Calculation:
- previously assumed photon hit to be in bottom left pixel of cluster
(photon hit assumed in bottom right pixel of cluster)
- clusters are filled from top left to bottom right (previously assumed:
bottom left to top right)
## Actual Interpolation:
- photon hits are given in pixel coordinates (previous interpolation
assumed euclidean coordinates, e.g. positive distance in y coordinate
becomes negative distance in row pixels)
- removed *2 of calculated distance
## General Adaption:
- max_sum_2x2 return subcluster index relative to cluster center e.g.
bottomleft, bottomright
## Added proper test case
- simulated photon hit with normal energy distribution
- Note: Test case for 2x2 cluster fails - Think uniform photon hit
distribution cant be modeled by normalized eta distribution for 2x2
clusters
The python bindings build a shared library and I cant link against
static libraries. Apparently I have to build with
CMAKE_POSITION_INDEPENDANT_CODE=On.
- Still quite far from a state where it can be merged
- Reduce 5x5 to 3x3
- Reduce 3x3 to 2x2
Open issues:
- [ ] Can we generalize it?
- [ ] Which reductions are needed
- [ ] Naming
