Commit Graph
601 Commits
Author SHA1 Message Date
hinger_v 13b9f288a0 Rework ROI mirroring to clarify intent: Mirror on an axis 2026-08-20 16:49:22 +02:00
mazzol_a 4970a92d50 updated clang-format commands (#352)
Build on RHEL9 / build (push) Successful in 2m28s
Build on RHEL8 / build (push) Successful in 3m21s
Run tests using data on local RHEL8 / build (push) Successful in 3m59s
Build on local RHEL8 / build (push) Successful in 2m43s
- updated custom targets clang-format, check-format, clang-tidy 
- find: paths must precede expression: `\' (double \\ not properly
escaped in bash)
2026-08-20 16:14:32 +02:00
hinger_v 57e035abc3 Format
Build on RHEL9 / build (push) Successful in 2m32s
Build on RHEL8 / build (push) Successful in 3m13s
Run tests using data on local RHEL8 / build (push) Successful in 4m1s
2026-08-20 14:44:25 +02:00
hinger_v cb76a948e4 Merge remote-tracking branch 'refs/remotes/origin/dev/strixels/remap_simple' into dev/strixels/remap_simple
Build on RHEL9 / build (push) Successful in 2m40s
Build on RHEL8 / build (push) Successful in 3m27s
Run tests using data on local RHEL8 / build (push) Successful in 4m1s
2026-08-20 13:55:30 +02:00
hinger_v 605c28bc19 Fix names of format helpers and remove unused 2026-08-20 12:30:11 +02:00
Erik Fröjdh fef57c13c9 added const overload for NDArray::view() (#351)
Build on RHEL9 / build (push) Successful in 2m29s
Build on RHEL8 / build (push) Successful in 3m3s
Run tests using data on local RHEL8 / build (push) Successful in 3m59s
Build on local RHEL8 / build (push) Successful in 2m45s
- Added missing const T overload for NDArray::view()
- Tests
2026-08-19 16:21:37 +02:00
Erik Fröjdh af25aea684 Fixed bug in reading analog samples for <v8.0 (#349)
Build on RHEL9 / build (push) Successful in 2m34s
Build on RHEL8 / build (push) Successful in 3m2s
Run tests using data on local RHEL8 / build (push) Successful in 3m59s
Build on local RHEL8 / build (push) Successful in 2m43s
Before v8.0 we should always try to read analog samples. This bug
resulted in old Mönch03 data not being reordered.

1. Added test for master file parsing
2. Fixed code 

closing #348
2026-08-19 12:34:37 +02:00
mazzol_a e96778909e Merge branch 'main' into dev/strixels/remap_simple
Build on RHEL9 / build (push) Successful in 2m34s
Build on RHEL8 / build (push) Successful in 3m9s
Run tests using data on local RHEL8 / build (push) Successful in 3m56s
2026-08-19 11:47:39 +02:00
Erik Fröjdh aa39470686 Removed unused DynamicCluster (#346)
Build on RHEL9 / build (push) Successful in 2m31s
Build on RHEL8 / build (push) Successful in 3m4s
Run tests using data on local RHEL8 / build (push) Successful in 3m52s
Build on local RHEL8 / build (push) Successful in 2m45s
- Removed unused DynamicCluster
- Removed commented out references to ClusterFileV2
2026-08-14 11:11:43 +02:00
Erik Fröjdh 4f6b69fba6 Removing deprecated use of lmfit (#344)
Build on RHEL9 / build (push) Successful in 2m44s
Build on RHEL8 / build (push) Successful in 3m9s
Run tests using data on local RHEL8 / build (push) Successful in 3m58s
Build on local RHEL8 / build (push) Successful in 2m44s
Removed the lmfit based fitting and the old API for calling functions

closes #296
2026-08-14 10:31:07 +02:00
Erik Fröjdh e26db97b5c Prototype multi threaded file reader (#343)
Build on RHEL9 / build (push) Successful in 2m40s
Build on RHEL8 / build (push) Successful in 3m4s
Run tests using data on local RHEL8 / build (push) Successful in 3m51s
Build on local RHEL8 / build (push) Successful in 2m46s
- Reading files from nfs shares tops out at ~1GB/s for single threaded
reads.
- MultiThreadedFileReader uses our File wrapper to read a generic file
in parallel
- Placed in aare::experimental to show that it's not production ready
2026-08-11 15:28:54 +02:00
hinger_v 4bfe7eceea InclusiveROI comment 2026-07-24 11:47:25 +02:00
hinger_v f3c79465d5 Clarify and document strixel_to_pixel_map more
Build on RHEL9 / build (push) Successful in 2m45s
Build on RHEL8 / build (push) Successful in 3m13s
Run tests using data on local RHEL8 / build (push) Successful in 3m59s
2026-07-24 11:34:21 +02:00
hinger_v 561d76203d Clarify and document strixel_to_pixel_map
Build on RHEL8 / build (push) Failing after 1m28s
Build on RHEL9 / build (push) Failing after 1m41s
Run tests using data on local RHEL8 / build (push) Failing after 2m15s
2026-07-22 18:03:24 +02:00
hinger_v 13f8c9ea80 Document generators
Build on RHEL9 / build (push) Successful in 2m59s
Build on RHEL8 / build (push) Successful in 3m11s
Run tests using data on local RHEL8 / build (push) Successful in 3m49s
2026-07-22 15:52:58 +02:00
hinger_v 98cdc6ba08 Refactoring and simplifications:
Build on RHEL9 / build (push) Successful in 2m40s
Build on RHEL8 / build (push) Successful in 3m48s
Run tests using data on local RHEL8 / build (push) Successful in 4m1s
- Adjust for reduced remap result struct
- Add predefined SensorConfigs
- Move combine_group_maps to implementation detail of RemapGenerate
- Remove apply_rotation_shift and Rotation flip (have become superfluous)
2026-07-22 14:34:47 +02:00
hinger_v 9b5a15f2a4 Consistently add briefs
Build on RHEL8 / build (push) Failing after 1m31s
Build on RHEL9 / build (push) Failing after 1m34s
Run tests using data on local RHEL8 / build (push) Failing after 2m1s
2026-07-21 16:13:15 +02:00
hinger_v c5ccd44a4c Refactoring suggestion for remap result (better doc) 2026-07-21 16:04:41 +02:00
hinger_v 857059cdaf Fix duplicate include
Build on RHEL8 / build (push) Failing after 1m40s
Build on RHEL9 / build (push) Failing after 2m8s
Run tests using data on local RHEL8 / build (push) Failing after 2m32s
2026-07-21 15:46:09 +02:00
hinger_v 81b91fb959 Refactoring suggestion for mapping result (reduced + doc) 2026-07-21 15:45:39 +02:00
hinger_v 9a63c9ac94 Refactoring suggestion for remap result (correct comments)
Build on RHEL8 / build (push) Failing after 1m28s
Build on RHEL9 / build (push) Failing after 1m38s
Run tests using data on local RHEL8 / build (push) Failing after 2m5s
2026-07-21 15:22:25 +02:00
hinger_v f09ede2646 Refactoring suggestion for mapping result 2026-07-21 15:00:36 +02:00
hinger_v 9344cea819 Improve documentation of structs in defs and rename SensorPlacement -> SensorModulePlacement
Build on RHEL9 / build (push) Successful in 2m34s
Build on RHEL8 / build (push) Successful in 3m6s
Run tests using data on local RHEL8 / build (push) Successful in 4m1s
2026-07-17 15:51:16 +02:00
hinger_v 9bc4a4d6a9 Delete legacy configs
Build on RHEL9 / build (push) Successful in 2m33s
Build on RHEL8 / build (push) Successful in 3m8s
Run tests using data on local RHEL8 / build (push) Successful in 3m53s
2026-07-17 14:23:21 +02:00
hinger_v 4b8317de69 Missed file from previous commit (move SensorPixelGeometry and rename structs in defs) 2026-07-17 14:17:48 +02:00
hinger_v 6b0598cd30 Move SensorPixelGeometry to SensorConfig and rename group-specific entities to reflect independence of sensor 2026-07-17 14:16:50 +02:00
hinger_v 67690aacf9 Fix only one SensorPlacement also in RemapGenerate.hpp 2026-07-17 11:36:23 +02:00
hinger_v d3e337d061 Fix compiler warning -> ssize_t
Build on RHEL9 / build (push) Successful in 2m34s
Build on RHEL8 / build (push) Successful in 3m32s
Run tests using data on local RHEL8 / build (push) Successful in 4m6s
2026-07-16 19:39:24 +02:00
hinger_v 1b05488173 Separate flat_index < 0 from >= input.size() and throw only at the latter 2026-07-16 19:30:02 +02:00
hinger_v 14bfc19b6a Rework RemapAlgorithm.hpp according to comments
Build on RHEL9 / build (push) Successful in 2m36s
Build on RHEL8 / build (push) Successful in 3m9s
Run tests using data on local RHEL8 / build (push) Successful in 3m53s
- Add assert to flip
- Only one SensorPlacement for strixel_to_pixel_maps
- Pass order_map as NDView to ApplyRemap

Additional:
- Check output.shape() matches order_map.shape (correct buffer allocation)
- Chash nrows and ncols
- pass NDViews by value (copying is cheap and it makes the intent more clear that it only takes a snapshot of the arrays
2026-07-16 19:21:09 +02:00
hinger_v 60c4d77627 Rename: alignROIs -> rebaseROI 2026-07-16 12:22:26 +02:00
hinger_v a6927310a5 SImplify and document according to comments
Build on RHEL8 / build (push) Failing after 1m30s
Build on RHEL9 / build (push) Failing after 1m34s
Run tests using data on local RHEL8 / build (push) Failing after 2m10s
2026-07-16 12:15:01 +02:00
hinger_v 98385902df Merge branch 'main' into dev/strixels/remap_simple 2026-07-16 11:05:30 +02:00
hinger_v afd92ac457 Bugfix: Separate Rotation and Routing 2026-07-16 11:04:43 +02:00
mazzol_a 533ecb8a4a removed patch for minuit2 CMakeLists.txt (#336)
Build on RHEL9 / build (push) Successful in 2m57s
Build on RHEL8 / build (push) Successful in 3m35s
Run tests using data on local RHEL8 / build (push) Successful in 3m57s
Build on local RHEL8 / build (push) Successful in 2m46s
- patch no longer needed for minuit2 as CMakeLists.txt has been updated:
https://github.com/GooFit/Minuit2/commit/46716e516e34a95e1f4effa95705a9e0c3425839
2026-07-16 10:39:06 +02:00
Erik Fröjdh db67e870d9 readme
Build on RHEL9 / build (push) Successful in 2m42s
Build on RHEL8 / build (push) Successful in 3m15s
Run tests using data on local RHEL8 / build (push) Successful in 3m58s
Build on local RHEL8 / build (push) Successful in 2m46s
2026.7.2
2026-07-02 17:00:45 +02:00
Erik Fröjdh 7804e3a35b bumped version 2026-07-02 16:51:44 +02:00
4aadb6f7f0 refactor: hide Minuit2 from aare's public API (#331)
Build on RHEL9 / build (push) Successful in 3m13s
Build on RHEL8 / build (push) Successful in 3m52s
Run tests using data on local RHEL8 / build (push) Successful in 3m56s
Build on local RHEL8 / build (push) Successful in 2m45s
- Move Chi2.hpp from include/aare/ to src/ (private)
- Pimpl on FitModel<Model>: MnUserParameters/MnStrategy behind opaque
src/FitModelImpl.hpp, no Minuit2 includes in public headers
- Move fit_pixel/fit_3d bodies to Fit.cpp with explicit instantiations
for all 8 models; drop FCN template param from public API
- CMake: aare::Minuit2 wrapped in $<BUILD_INTERFACE:...> (hidden from
exported targets, same pattern as lmfit), MINUIT2_INSTALL OFF, Chi2.hpp
removed from PUBLICHEADERS
- Update python bindings and benchmark callsites accordingly

---------

Co-authored-by: Erik Fröjdh <erik.frojdh@psi.ch>
Co-authored-by: Alice <alice.mazzoleni@psi.ch>
2026-07-02 16:04:22 +02:00
mazzol_a b4686e6b85 added moench05 defs (#333)
Build on RHEL9 / build (push) Successful in 2m37s
Build on RHEL8 / build (push) Successful in 3m16s
Run tests using data on local RHEL8 / build (push) Successful in 3m56s
Build on local RHEL8 / build (push) Successful in 2m42s
- add moench05 chip/chiptestboard defs
2026-06-26 17:43:06 +02:00
maliakal_d 8c9f4ca763 cmake: treat warnings as errors (#330)
Build on RHEL9 / build (push) Successful in 2m33s
Build on RHEL8 / build (push) Successful in 3m13s
Run tests using data on local RHEL8 / build (push) Successful in 3m59s
Build on local RHEL8 / build (push) Successful in 2m44s
- treating warnings as errors during github and gitea workflows
2026-06-16 12:32:28 +02:00
mazzol_a 982419149d Merge branch 'main' into dev/treat_errors_as_warnings
Build on RHEL9 / build (push) Successful in 2m50s
Build on RHEL8 / build (push) Successful in 3m30s
Run tests using data on local RHEL8 / build (push) Successful in 3m53s
2026-06-15 14:44:13 +02:00
mazzol_a 0a4c4f5ec1 change AxisType to float for pixelhistogram tests 2026-06-15 14:27:26 +02:00
mazzol_a 559c822a02 change AxisType to float for pixelhistogram tests
Build on RHEL9 / build (push) Successful in 2m29s
Build on RHEL8 / build (push) Successful in 3m40s
Run tests using data on local RHEL8 / build (push) Successful in 3m58s
2026-06-15 14:22:24 +02:00
mazzol_a b71fcb1d1a fixed apple clang warning 2026-06-15 14:03:36 +02:00
mazzol_a 85833cebb3 fixed unsued warning in PedestalTrackingHistogram 2026-06-15 11:52:44 +02:00
Erik Fröjdh b4b28fc9e0 len() and pedestal subtraction (#328)
Build on RHEL9 / build (push) Successful in 2m57s
Build on RHEL8 / build (push) Successful in 3m28s
Run tests using data on local RHEL8 / build (push) Successful in 4m0s
Build on local RHEL8 / build (push) Successful in 2m44s
Collection of small improvements in usability: 

- NDView works for large arrays
- Direct subtraction of Pedestal from np.array
- len() support for python bindings of files
2026-06-15 11:38:06 +02:00
mazzol_a ae8744358a cmake format 2026-06-15 11:36:03 +02:00
mazzol_aandErik Fröjdh ee7503082d Dev/matterhorn decoder (#324)
Build on RHEL9 / build (push) Successful in 2m49s
Build on RHEL8 / build (push) Successful in 3m35s
Run tests using data on local RHEL8 / build (push) Successful in 4m1s
Build on local RHEL8 / build (push) Successful in 3m9s
- reshape image directly in decoder such that first dimension is num
counters
- take into account chip artefact in decoder.

---------

Co-authored-by: Erik Fröjdh <erik.frojdh@psi.ch>
2026-06-11 15:04:20 +02:00
Erik Fröjdh 2041c7310a Fixed usage of fmt::format and fmt::print for C++20 (#323)
Build on RHEL8 / build (push) Successful in 3m5s
Build on RHEL9 / build (push) Successful in 3m4s
Run tests using data on local RHEL8 / build (push) Successful in 3m57s
Build on local RHEL8 / build (push) Successful in 2m41s
With C++20 `fmt::print(s)` expects a compile time format string and
otherwise fails complaining about consteval. To get runtime formatting
use `fmt::print(fmt::runtime(s))`
2026-06-11 08:01:03 +02:00
hinger_v e70392aafe Merge branch 'main' into dev/strixels/remap_simple
Build on RHEL9 / build (push) Successful in 2m51s
Build on RHEL8 / build (push) Successful in 3m13s
Run tests using data on local RHEL8 / build (push) Successful in 4m2s
2026-06-10 13:33:46 +02:00