Lamni minor fixes #290

2026-07-31T13:40:02+02:00

holler commented

2026-07-31 13:40:02 +02:00

No description provided.

holler added 8 commits 2026-07-31 13:40:02 +02:00

fix(lamni): drop redundant 45deg detour in smear verification sweep, widen GUI retry budget

CI for csaxs_bec / test (push) Successful in 1m51s

Details

1db9c18e0a

find_rotation_center_smear_experimental() rotated 45->0 for its post-shift
verification sweep, needlessly re-treading ground the preceding full smear
sweep already covered and adding a long extra blocking move that could
starve the GUI heartbeat past _gui_call_with_retry's budget, surfacing as
RuntimeError: GUI is not alive. Sweep straight back to 0 instead, and widen
the retry budget (8x1.5s -> 25x2.0s) so update_frame() can ride out long
blocking moves on slower hardware.

Also tidy a stray comment-block artifact in ptycho_lamni.yaml and update
lamni.md docs for the current xrayeye_rotation_center_calibration_* API.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

feat(lamni): check measurement configuration before tomo_scan() 7caf57cff6

Flomni's tomo_scan() warns and prompts if the X-ray eye isn't out and
the FZP/OSA optics aren't in before scanning; LamNI had no equivalent,
letting a tomogram start with the eye still in the beam or the optics
retracted. Ports the same check, wired into the existing
force/interactive gating so it never blocks on input() during
unattended/queued runs.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

fix(lamni,flomni): suppress spurious 0-deg damage-estimation shot on golden-ratio resume

CI for csaxs_bec / test (push) Successful in 1m48s

Details

48b9f893ab

previous_subtomo_number resets to -1 on every tomo_scan() call in the
golden-ratio branches (tomo_type 2/3), including a resume. That makes
the first loop iteration look like a genuine sub-tomogram transition,
firing the 0-deg reference shot before the actual resume angle even
though the rotation isn't passing through 0 deg at that moment.

Mirrors tomo_type 1's existing start_angle-is-None resume guard:
suppress the shot only for the first, possibly-spurious transition
right after a resume, then let later genuine transitions in the same
call fire normally. Same fix applied to both lamni.py and flomni.py,
which share byte-for-byte identical golden-ratio logic here.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

docs update 171481928a

docs update 59c7906ba7

remove sample name querry, already done at coarse align a082a8cffa

fix(lamni,flomni,omny): re-issue rotation after an interrupted move instead of skipping

CI for csaxs_bec / test (push) Successful in 1m52s

Details

badbb82ba4

A Ctrl+C during lsamrot/fsamroy/osamroy rotation leaves the cached
user_setpoint at the target even though the axis never finished moving
(stop() halts the motor mid-move). The next scan then wrongly concluded
"no rotation required" from setpoint equality alone, leaving LamNI's
air bearings unclamped (confirmed via galil show all) and the beamline
unable to scan until the setpoint was nudged manually.

lamni_rotation() now also requires
lgalil_is_air_off_and_orchestra_enabled() before skipping, since that
flag only goes true once the Galil #CENROT sequence (air-clamp plus
centering) has fully completed. flomni_rotation()/omny_rotation() use
a readback-vs-tolerance check instead, since those axes have no
air-bearing clamp step.

Along the way, fixed lgalil_is_air_off_and_orchestra_enabled() itself:
it did bool(socket_put_and_receive(...)) directly on the raw Galil
reply string, which is always truthy, so it could never report
anything but True. Confirmed via HW testing in LamNI.

fix(lamni,flomni,omny): stop force-opening tomo-queue panel of running job

CI for csaxs_bec / test (pull_request) Successful in 1m49s

Details

Read the Docs Deploy Trigger / trigger-rtd-webhook (push) Successful in 2s

Details

CI for csaxs_bec / test (push) Successful in 1m47s

Details

0e7ef10eee

The status webpage's tomo-queue accordion auto-expanded a job's details
panel as soon as its status became "running", overriding whatever
open/closed state the user had selected. Panel state now depends only
on the existing DOM snapshot of user selections.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

holler merged commit 0e7ef10eee into main

2026-07-31 13:43:48 +02:00

holler deleted branch lamni_minor_fixes

2026-07-31 13:43:48 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bec/csaxs_bec#290