Fix/lamni fermat fov check comment #288

Merged

holler merged 2 commits from fix/lamni-fermat-fov-check-comment into main

2026-07-30 15:32:05 +02:00

Author	SHA1	Message	Date
x01dcandClaude Sonnet 5	fa322bfd43	fix(lamni): allow entering 0 to disable circular FOV in Tomo Params GUI CI for csaxs_bec / test (pull_request) Successful in 1m50s Details Read the Docs Deploy Trigger / trigger-rtd-webhook (push) Successful in 2s Details CI for csaxs_bec / test (push) Successful in 1m51s Details The scan already treats fov_circular==0 as "disabled" and defaults to it, but the GUI spinbox floor of 0.1 made 0 unreachable. Lower the floor to 0.0 and label the field so the meaning is explicit. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-07-30 15:28:48 +02:00
x01dcandClaude Sonnet 5	40cbb17746	docs(lamni): explain fov check axis mapping instead of FIXME CI for csaxs_bec / test (push) Successful in 2m15s Details The stage_x_rot/fovy and stage_y_rot/fovx comparisons look swapped, but are correct: alpha bakes in a fixed ~90 deg mechanical offset between the piezo axes and the angle=0 beam frame that fovx/fovy are defined in, so stage_x_rot actually tracks the beam-frame y-extent. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-07-30 15:15:10 +02:00

Author

SHA1

Message

Date

x01dcandClaude Sonnet 5

fa322bfd43

fix(lamni): allow entering 0 to disable circular FOV in Tomo Params GUI

CI for csaxs_bec / test (pull_request) Successful in 1m50s

Details

Read the Docs Deploy Trigger / trigger-rtd-webhook (push) Successful in 2s

Details

CI for csaxs_bec / test (push) Successful in 1m51s

Details

The scan already treats fov_circular==0 as "disabled" and defaults to
it, but the GUI spinbox floor of 0.1 made 0 unreachable. Lower the
floor to 0.0 and label the field so the meaning is explicit.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

2026-07-30 15:28:48 +02:00

x01dcandClaude Sonnet 5

40cbb17746

docs(lamni): explain fov check axis mapping instead of FIXME

CI for csaxs_bec / test (push) Successful in 2m15s

Details

The stage_x_rot/fovy and stage_y_rot/fovx comparisons look swapped,
but are correct: alpha bakes in a fixed ~90 deg mechanical offset
between the piezo axes and the angle=0 beam frame that fovx/fovy are
defined in, so stage_x_rot actually tracks the beam-frame y-extent.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

2026-07-30 15:15:10 +02:00