bec/csaxs_bec
0
0
Fork 2
Code Issues 17 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

docs(lamni): explain fov check axis mapping instead of FIXME
CI for csaxs_bec / test (push) Successful in 2m15s
Details

Browse Source 
The stage_x_rot/fovy and stage_y_rot/fovx comparisons look swapped,
but are correct: alpha bakes in a fixed ~90 deg mechanical offset
between the piezo axes and the angle=0 beam frame that fovx/fovy are
defined in, so stage_x_rot actually tracks the beam-frame y-extent.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
x01dc
2026-07-30 15:15:10 +02:00
co-authored by Claude Sonnet 5
parent 771ee01a57
commit 40cbb17746
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
csaxs_bec/scans/lamni_fermat_scan.py
+4 -2
View File
@@ -461,8 +461,10 @@ class LamniFermatScan(ScanBase):
-np.sin(alpha) * stage_x_with_stitch + np.cos(alpha) * stage_y_with_stitch
)
# FIXME: We are checking stage_x_rot vs fovy. This needs to be clarified if this is correct
# once LamNI is back in operation. We keep it like this for now.
# stage_x_rot is checked against fovy (and stage_y_rot against fovx) because alpha
# includes a fixed ~90 deg mechanical offset (-300+30.5 deg) between the piezo's
# physical axes and the angle=0 sample/beam frame that fovx/fovy are defined in.
# So stage_x_rot tracks the beam-frame y-extent, and stage_y_rot the x-extent.
return (
np.abs(stage_x_rot) <= (fovy / 2)
and np.abs(stage_y_rot) <= (fovx / 2)