bec/csaxs_bec
0
0
Fork 2
Code Issues 17 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(LamNI): skip 22.5 deg approach rotation when shutter is closed #284

Merged
holler merged 2 commits from fix/lamni-xrayeye-approach-angle-shutter into main 2026-07-28 13:35:05 +02:00
Conversation 0 Commits 2 Files Changed 2
+18 -12
holler commented 2026-07-28 13:24:29 +02:00
Member
Copy Link
Copy Source

The k=2..8 alignment steps always rotated via a halfway "approach"
angle before the 45 deg target, to let the operator watch the sample
sweep through in live view. That's only useful when keep_shutter_open
is True; with the shutter closed nobody sees the intermediate move, so
just rotate straight to the target angle in that case.

Also bump the OMNY/FlOMNI post-fshopen() freeze-frame delay in
update_frame() from 0.5s to 1s to match LamNI's, for consistent
behavior between the two plugins.

The k=2..8 alignment steps always rotated via a halfway "approach" angle before the 45 deg target, to let the operator watch the sample sweep through in live view. That's only useful when keep_shutter_open is True; with the shutter closed nobody sees the intermediate move, so just rotate straight to the target angle in that case. Also bump the OMNY/FlOMNI post-fshopen() freeze-frame delay in update_frame() from 0.5s to 1s to match LamNI's, for consistent behavior between the two plugins.
holler added 1 commit 2026-07-28 13:24:29 +02:00
fix(LamNI): skip 22.5 deg approach rotation when shutter is closed
CI for csaxs_bec / test (push) Successful in 1m50s
Details
CI for csaxs_bec / test (pull_request) Successful in 1m50s
Details
0534f6ed79 
The k=2..8 alignment steps always rotated via a halfway "approach"
angle before the 45 deg target, to let the operator watch the sample
sweep through in live view. That's only useful when keep_shutter_open
is True; with the shutter closed nobody sees the intermediate move, so
just rotate straight to the target angle in that case.

Also bump the OMNY/FlOMNI post-fshopen() freeze-frame delay in
update_frame() from 0.5s to 1s to match LamNI's, for consistent
behavior between the two plugins.
holler added 1 commit 2026-07-28 13:30:29 +02:00
Merge branch 'main' into fix/lamni-xrayeye-approach-angle-shutter
CI for csaxs_bec / test (push) Successful in 1m51s
Details
CI for csaxs_bec / test (pull_request) Successful in 1m48s
Details
2abfc3b6e5
holler merged commit 2aca187c86 into main 2026-07-28 13:35:05 +02:00
holler deleted branch fix/lamni-xrayeye-approach-angle-shutter 2026-07-28 13:35:05 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#284