bec/csaxs_bec
0
0
Fork 1
Code Issues 16 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

fix: remove .wait() from omny_xray_gui in on_dap_params in gui #209

Open
wyzula_j wants to merge 4 commits from fix/dap-recursion into main
pull from: fix/dap-recursion
merge into: :main
Conversation 0 Commits 4 Files Changed 3
+140 -7
wyzula_j commented 2026-05-18 11:36:31 +02:00
Owner
Copy Link
Copy Source

Summary

Limit XRayEye DAP parameter forwarding to the active alignment procedure.

Previously, waveform_x/y.dap_params_update were connected for the full widget lifetime. Since the embedded waveform widgets react to scan progress, DAP parameter updates could be triggered repeatedly during subsequent scan activity, potentially causing RPC timeouts, GUI unresponsiveness, and scan queue blocking.

This adds an explicit set_dap_params_forwarding(enabled: bool) RPC switch. The alignment script enables DAP parameter forwarding at the start of the XRayEye alignment and disables it in a finally block when the procedure exits.

## Summary Limit XRayEye DAP parameter forwarding to the active alignment procedure. Previously, `waveform_x/y.dap_params_update` were connected for the full widget lifetime. Since the embedded waveform widgets react to scan progress, DAP parameter updates could be triggered repeatedly during subsequent scan activity, potentially causing RPC timeouts, GUI unresponsiveness, and scan queue blocking. This adds an explicit `set_dap_params_forwarding(enabled: bool)` RPC switch. The alignment script enables DAP parameter forwarding at the start of the XRayEye alignment and disables it in a `finally` block when the procedure exits.
wyzula_j requested review from appel_c 2026-05-18 11:36:46 +02:00
wyzula_j requested review from holler 2026-05-18 11:36:46 +02:00
wyzula_j requested review from perl_d 2026-05-18 11:36:46 +02:00
wyzula_j requested review from wakonig_k 2026-05-18 11:36:46 +02:00
wyzula_j self-assigned this 2026-05-18 11:36:50 +02:00
wyzula_j force-pushed fix/dap-recursion from d85b2eb699 to d7c365c2d2 2026-05-18 13:01:44 +02:00 Compare
wyzula_j force-pushed fix/dap-recursion from d7c365c2d2 to 2fcca9bb14 2026-05-19 10:13:53 +02:00 Compare
wyzula_j added 3 commits 2026-05-19 13:35:09 +02:00
fix: remove .wait() from omny_xray_gui in on_dap_params in gui 5373dba22f
fix: subscribe dap updates before align and unsubscribe after align is done 6f2fc7f35a
fix: disable controls for device input and toggles
CI for csaxs_bec / test (pull_request) Successful in 1m36s
Details
CI for csaxs_bec / test (push) Successful in 1m40s
Details
99566d6aa3
wyzula_j force-pushed fix/dap-recursion from 2fcca9bb14 to 99566d6aa3 2026-05-19 13:35:09 +02:00 Compare
wyzula_j added 1 commit 2026-05-19 15:36:46 +02:00
fix: fetch the status of the queue in next event loop
CI for csaxs_bec / test (pull_request) Successful in 1m33s
Details
CI for csaxs_bec / test (push) Successful in 1m33s
Details
ad6ebfa60f
All checks were successful
CI for csaxs_bec / test (pull_request) Successful in 1m33s
Required
Details
CI for csaxs_bec / test (push) Successful in 1m33s
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/dap-recursion:fix/dap-recursion
git checkout fix/dap-recursion
Sign in to join this conversation.
Reviewers
No Reviewers
appel_c
holler
perl_d
wakonig_k
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees wyzula_j
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#209
Delete Branch "fix/dap-recursion"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?