bec/csaxs_bec
0
0
Fork 2
Code Issues 17 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

fix(flomni): avoid XRayEye GUI RPC timeouts #208

Closed
wyzula_j wants to merge 2 commits from fix/temp-xray-eye-timeout-fix into main
pull from: fix/temp-xray-eye-timeout-fix
merge into: :main
Conversation 1 Commits 2 Files Changed 1
+354 -55
wyzula_j commented 2026-05-17 21:29:05 +02:00
Owner
Copy Link
Copy Source

Description

Hotfix for XRayEye GUI/RPC timeouts during flOMNI alignment, rebased on top of fix/dap-recursion.

This keeps the DAP forwarding changes from fix/dap-recursion and adds the XRayEye async rpc device execution on top from gui:

  • Move potentially blocking BEC/device actions from GUI callbacks to a small background thread path.
  • Keep widget construction lighter by deferring live-view setup and Fit tab initialization.
  • Use cached/readback state for XRayEye submit instead of doing blocking reads from the Qt thread.
  • Fetch the current scan queue status when XRayEye is created, not only on later queue updates.
  • Disable the user-facing XRayEye toggle switches while the scan queue is busy, with a short delayed re-enable to avoid flicker.
  • Keep RPC/script calls functional while preventing manual toggle interaction from adding device instructions behind an active scan.

Additional Comments

This is still a beamline hotfix, not the final architecture. The background thread reduces immediate GUI/RPC timeout risk, but running device calls cannot be forcibly interrupted and shutdown only waits briefly for them. The proper long-term solution should come from the upcoming bec_widgets worker/thread infrastructure.

## Description Hotfix for XRayEye GUI/RPC timeouts during flOMNI alignment, rebased on top of `fix/dap-recursion`. This keeps the DAP forwarding changes from `fix/dap-recursion` and adds the XRayEye async rpc device execution on top from gui: - Move potentially blocking BEC/device actions from GUI callbacks to a small background thread path. - Keep widget construction lighter by deferring live-view setup and Fit tab initialization. - Use cached/readback state for XRayEye submit instead of doing blocking reads from the Qt thread. - Fetch the current scan queue status when XRayEye is created, not only on later queue updates. - Disable the user-facing XRayEye toggle switches while the scan queue is busy, with a short delayed re-enable to avoid flicker. - Keep RPC/script calls functional while preventing manual toggle interaction from adding device instructions behind an active scan. ## Additional Comments This is still a beamline hotfix, not the final architecture. The background thread reduces immediate GUI/RPC timeout risk, but running device calls cannot be forcibly interrupted and shutdown only waits briefly for them. The proper long-term solution should come from the upcoming `bec_widgets` worker/thread infrastructure.
wyzula_j self-assigned this 2026-05-17 21:29:16 +02:00
wyzula_j requested review from appel_c 2026-05-17 21:29:30 +02:00
wyzula_j requested review from holler 2026-05-17 21:29:30 +02:00
wyzula_j requested review from perl_d 2026-05-17 21:29:30 +02:00
wyzula_j requested review from wakonig_k 2026-05-17 21:29:30 +02:00
wyzula_j force-pushed fix/temp-xray-eye-timeout-fix from 9321ef4c8e to 81cf4fba4f 2026-05-19 14:14:42 +02:00 Compare
wyzula_j force-pushed fix/temp-xray-eye-timeout-fix from d8d7eed3a9 to fcc9df1cbf 2026-05-19 15:43:14 +02:00 Compare
wyzula_j force-pushed fix/temp-xray-eye-timeout-fix from fcc9df1cbf to 0f130aae37 2026-05-19 16:02:46 +02:00 Compare
wyzula_j added 6 commits 2026-05-21 10:23:15 +02:00
fix: remove .wait() from omny_xray_gui in on_dap_params in gui 480ff259dc
fix: subscribe dap updates before align and unsubscribe after align is done 32034a7c59
fix: disable controls for device input and toggles a568656389
fix: fetch the status of the queue in next event loop 71946e1c79
fix(x_ray_eye): disabled cleanup turn off the live mode
CI for csaxs_bec / test (pull_request) Successful in 1m30s
Details
Read the Docs Deploy Trigger / trigger-rtd-webhook (push) Successful in 2s
Details
CI for csaxs_bec / test (push) Successful in 1m36s
Details
541c3829b1
fix(x_ray_eye): async device call execution
CI for csaxs_bec / test (pull_request) Successful in 1m30s
Details
CI for csaxs_bec / test (push) Successful in 1m36s
Details
5e6cda1bf2
wyzula_j force-pushed fix/temp-xray-eye-timeout-fix from 0f130aae37 to 5e6cda1bf2 2026-05-21 10:23:15 +02:00 Compare
wyzula_j added 1 commit 2026-05-21 10:35:41 +02:00
fix(x_ray_eye): remove camera shutdown during cleanup
CI for csaxs_bec / test (push) Successful in 1m30s
Details
CI for csaxs_bec / test (pull_request) Successful in 1m29s
Details
a072e300d9
wyzula_j commented 2026-05-21 13:37:36 +02:00
Author
Owner
Copy Link
Copy Source

closed in favor of minimal fix here: #209

closed in favor of minimal fix here: https://gitea.psi.ch/bec/csaxs_bec/pulls/209
wyzula_j closed this pull request 2026-05-21 13:37:36 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
appel_c
wakonig_k
holler
perl_d
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees wyzula_j
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#208