bec/csaxs_bec
0
0
Fork 1
Code Issues 16 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

fix(flomni): avoid XRayEye GUI RPC timeouts #208

Open
wyzula_j wants to merge 1 commits from fix/temp-xray-eye-timeout-fix into main
pull from: fix/temp-xray-eye-timeout-fix
merge into: :main
Conversation 0 Commits 1 Files Changed 1
+221 -49
wyzula_j commented 2026-05-17 21:29:05 +02:00
Owner
Copy Link
Copy Source

##Description
This is a narrow hotfix for RPC timeouts seen during flOMNI XRayEye alignment gui.

XRayEye now avoids doing potentially blocking BEC/device operations directly on the Qt GUI thread. Those operations are moved to a small background thread path, while the GUI-facing methods return faster to the RPC caller. Live-view setup and Fit tab initialization are also deferred so widget construction and common alignment calls are less likely to block the GUI event loop.

Additional Comments

This is not the final architecture. The new background thread reduces the immediate beamline timeout risk, but it still has lifecycle limitations: running device calls cannot be forcibly interrupted, and shutdown can only wait briefly for them to finish. The proper fix should come from the upcoming bec_widgets worker/thread infrastructure.

##Description This is a narrow hotfix for RPC timeouts seen during flOMNI XRayEye alignment gui. XRayEye now avoids doing potentially blocking BEC/device operations directly on the Qt GUI thread. Those operations are moved to a small background thread path, while the GUI-facing methods return faster to the RPC caller. Live-view setup and Fit tab initialization are also deferred so widget construction and common alignment calls are less likely to block the GUI event loop. ## Additional Comments This is not the final architecture. The new background thread reduces the immediate beamline timeout risk, but it still has lifecycle limitations: running device calls cannot be forcibly interrupted, and shutdown can only wait briefly for them to finish. The proper fix should come from the upcoming `bec_widgets` worker/thread infrastructure.
wyzula_j added 1 commit 2026-05-17 21:29:05 +02:00
fix(flomni): avoid XRayEye GUI RPC timeouts
CI for csaxs_bec / test (push) Successful in 1m36s
Details
CI for csaxs_bec / test (pull_request) Successful in 1m32s
Details
9321ef4c8e
wyzula_j self-assigned this 2026-05-17 21:29:16 +02:00
wyzula_j requested review from appel_c 2026-05-17 21:29:30 +02:00
wyzula_j requested review from holler 2026-05-17 21:29:30 +02:00
wyzula_j requested review from perl_d 2026-05-17 21:29:30 +02:00
wyzula_j requested review from wakonig_k 2026-05-17 21:29:30 +02:00
All checks were successful
CI for csaxs_bec / test (push) Successful in 1m36s
Details
CI for csaxs_bec / test (pull_request) Successful in 1m32s
Required
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/temp-xray-eye-timeout-fix:fix/temp-xray-eye-timeout-fix
git checkout fix/temp-xray-eye-timeout-fix
Sign in to join this conversation.
Reviewers
No Reviewers
perl_d
appel_c
wakonig_k
holler
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees wyzula_j
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#208
Delete Branch "fix/temp-xray-eye-timeout-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?