bec/csaxs_bec
0
0
Fork 1
Code Issues 16 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

feat: removed old and introduced new structure #19

Merged
appel_c merged 4 commits from feat/transition_to_new_plugin_structure into main 2024-04-19 17:56:43 +02:00
Conversation 18 Commits 4 Files Changed 130
+21731 -12449
appel_c commented 2024-04-18 09:38:47 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

This MR transitions cSAXS plugins to the new plugin structure

This MR transitions cSAXS plugins to the new plugin structure
appel_c commented 2024-04-18 09:38:48 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

assigned to @appel_c

assigned to @appel_c
appel_c commented 2024-04-19 14:03:03 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

added 1 commit

  • f9818d89 - feat: populated csaxs_bec from ophyd and bec

Compare with previous version

added 1 commit <ul><li>f9818d89 - feat: populated csaxs_bec from ophyd and bec</li></ul> [Compare with previous version](/bec/csaxs-bec/-/merge_requests/7/diffs?diff_id=24818&start_sha=96921da618e44efc53d173e420b9e2a6b2d6ca5d)
appel_c commented 2024-04-19 14:04:20 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

added 1 commit

  • 57e068a6 - refactor: updated configs, minor improvements, formatting

Compare with previous version

added 1 commit <ul><li>57e068a6 - refactor: updated configs, minor improvements, formatting</li></ul> [Compare with previous version](/bec/csaxs-bec/-/merge_requests/7/diffs?diff_id=24819&start_sha=f9818d898676b610054e3a64269e8e6854ffa4ac)
appel_c commented 2024-04-19 15:18:16 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

added 1 commit

  • 8b59ace6 - fix: add ci file

Compare with previous version

added 1 commit <ul><li>8b59ace6 - fix: add ci file</li></ul> [Compare with previous version](/bec/csaxs-bec/-/merge_requests/7/diffs?diff_id=24838&start_sha=57e068a6d32f09ae9860ab933f1b404875608c26)
appel_c commented 2024-04-19 15:43:12 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

added 2 commits

  • c8595417 - ci: add configtest to ci pipeline
  • f73b652b - wip

Compare with previous version

added 2 commits <ul><li>c8595417 - ci: add configtest to ci pipeline</li><li>f73b652b - wip</li></ul> [Compare with previous version](/bec/csaxs-bec/-/merge_requests/7/diffs?diff_id=24850&start_sha=8b59ace6e9141ec286c43a8b576a688724a4eb0f)
appel_c commented 2024-04-19 15:47:15 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

added 1 commit

  • 9661f7c5 - ci: fix bug

Compare with previous version

added 1 commit <ul><li>9661f7c5 - ci: fix bug</li></ul> [Compare with previous version](/bec/csaxs-bec/-/merge_requests/7/diffs?diff_id=24852&start_sha=f73b652bba8d4c2a2af9ce7987475a24097c0083)
appel_c commented 2024-04-19 16:00:17 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

added 1 commit

  • 604f7a82 - wip

Compare with previous version

added 1 commit <ul><li>604f7a82 - wip</li></ul> [Compare with previous version](/bec/csaxs-bec/-/merge_requests/7/diffs?diff_id=24854&start_sha=9661f7c50b9699f48c2b1ff5736491175ca81c17)
appel_c commented 2024-04-19 16:06:17 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

added 1 commit

  • 6837312b - wip

Compare with previous version

added 1 commit <ul><li>6837312b - wip</li></ul> [Compare with previous version](/bec/csaxs-bec/-/merge_requests/7/diffs?diff_id=24858&start_sha=604f7a826dcc3917135b7b761050cec96eff4889)
appel_c commented 2024-04-19 16:13:10 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

added 2 commits

  • aebb432b - refactor: updated configs, minor improvements, formatting
  • c8d39204 - ci: add ci file

Compare with previous version

added 2 commits <ul><li>aebb432b - refactor: updated configs, minor improvements, formatting</li><li>c8d39204 - ci: add ci file</li></ul> [Compare with previous version](/bec/csaxs-bec/-/merge_requests/7/diffs?diff_id=24860&start_sha=6837312b87b487945894c1dde675cff7798b580f)
appel_c commented 2024-04-19 16:17:17 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

added 2 commits

  • 6378636b - refactor: updated configs, minor improvements, formatting
  • 44cdad55 - ci: add ci file

Compare with previous version

added 2 commits <ul><li>6378636b - refactor: updated configs, minor improvements, formatting</li><li>44cdad55 - ci: add ci file</li></ul> [Compare with previous version](/bec/csaxs-bec/-/merge_requests/7/diffs?diff_id=24862&start_sha=c8d39204a5b7fc444552dca9213a501a8225d128)
appel_c commented 2024-04-19 16:23:52 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

added 2 commits

  • 998b297e - refactor: updated configs, minor improvements, formatting
  • a44104ef - ci: add ci file

Compare with previous version

added 2 commits <ul><li>998b297e - refactor: updated configs, minor improvements, formatting</li><li>a44104ef - ci: add ci file</li></ul> [Compare with previous version](/bec/csaxs-bec/-/merge_requests/7/diffs?diff_id=24864&start_sha=44cdad55dd40521a9b0d0dcc29b7aa8eb9c6847f)
appel_c commented 2024-04-19 16:53:40 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

marked this merge request as ready

marked this merge request as **ready**
appel_c commented 2024-04-19 16:53:40 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

requested review from @wakonig_k and @holler

requested review from @wakonig_k and @holler
appel_c commented 2024-04-19 17:02:43 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

@holler I have separated the commit in which I adapted the old config files from the one where I copy them into the plugins. The actual changes in the config are visible in this commit https://gitlab.psi.ch/bec/csaxs-bec/-/merge_requests/7/diffs?commit_id=998b297ed4aaec2256b0e7b52de52bd1b4a614d7.
It would still be good to proceed with caution when this is first tested with flomni and lamni.

@holler I have separated the commit in which I adapted the old config files from the one where I copy them into the plugins. The actual changes in the config are visible in this commit https://gitlab.psi.ch/bec/csaxs-bec/-/merge_requests/7/diffs?commit_id=998b297ed4aaec2256b0e7b52de52bd1b4a614d7. It would still be good to proceed with caution when this is first tested with flomni and lamni.
wakonig_k commented 2024-04-19 17:25:24 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

mentioned in merge request ophyd_devices!129

mentioned in merge request ophyd_devices!129
appel_c commented 2024-04-19 17:27:17 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

added 3 commits

  • 52d41a7a - feat: populated csaxs_bec from ophyd and bec
  • b76137f7 - refactor: updated configs, minor improvements, formatting
  • 93de8aec - ci: add ci file

Compare with previous version

added 3 commits <ul><li>52d41a7a - feat: populated csaxs_bec from ophyd and bec</li><li>b76137f7 - refactor: updated configs, minor improvements, formatting</li><li>93de8aec - ci: add ci file</li></ul> [Compare with previous version](/bec/csaxs-bec/-/merge_requests/7/diffs?diff_id=24887&start_sha=a44104ef8babe6cc22d13ae729b850b7a32ccdb8)
appel_c commented 2024-04-19 17:49:14 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

added 3 commits

  • c109abce - feat: populated csaxs_bec from ophyd and bec
  • daf1ec03 - refactor: updated configs, minor improvements, formatting
  • 4326c5b4 - ci: add ci file

Compare with previous version

added 3 commits <ul><li>c109abce - feat: populated csaxs_bec from ophyd and bec</li><li>daf1ec03 - refactor: updated configs, minor improvements, formatting</li><li>4326c5b4 - ci: add ci file</li></ul> [Compare with previous version](/bec/csaxs-bec/-/merge_requests/7/diffs?diff_id=24889&start_sha=93de8aece4e49292ddc5194c8c6f682180a8f589)
appel_c commented 2024-04-19 17:56:43 +02:00 (Migrated from gitlab.psi.ch)
Copy Link
Copy Source

mentioned in commit 140ceb7359

mentioned in commit 140ceb7359a7b8b63122c0ea4b5176b031ca1ee3
appel_c (Migrated from gitlab.psi.ch) merged commit 140ceb7359 into main 2024-04-19 17:56:44 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#19
Delete Branch "feat/transition_to_new_plugin_structure"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?