bec/csaxs_bec
0
0
Fork 1
Code Issues 13 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Add Digital Out signals to GalilRIO #138

Merged
appel_c merged 6 commits from add/rio-galil-set-gain into main 2026-02-16 17:51:37 +01:00
Conversation 1 Commits 6 Files Changed 5 +237 -126
appel_c commented 2026-02-11 08:36:51 +01:00
Owner
Copy Link

PR to add DigitalOUT signals to flip the dig_out bits on the PLC.
Requires (https://github.com/bec-project/ophyd_devices/pull/174) to be merged first.

PR to add DigitalOUT signals to flip the dig_out bits on the PLC. Requires (https://github.com/bec-project/ophyd_devices/pull/174) to be merged first.
appel_c added 17 commits 2026-02-11 08:36:52 +01:00
feat(galil-rio): Add di_out channels to GalilRIO
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m27s
Details
f42f8e207c
w
Some checks failed
CI for csaxs_bec / test (push) Has been cancelled
Details
b6ac8eaae1
w
Some checks failed
CI for csaxs_bec / test (push) Has been cancelled
Details
89274cfcb7
w
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m27s
Details
a92beac12b
w
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m27s
Details
4ec38fa254
w 7114104f9c
w
Some checks failed
CI for csaxs_bec / test (push) Has been cancelled
Details
4375f550dd
w
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m34s
Details
213f9ab8b1
w
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m37s
Details
4cf0fb3c30
w
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m26s
Details
be701e97d3
w
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m28s
Details
faab59c3a5
w
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m27s
Details
a935dbf496
W
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m28s
Details
136d5b160c
w
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m28s
Details
d44022eeac
w
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m30s
Details
e36f48eccc
w c489236181
tests: fix tests after refactoring
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m32s
Details
CI for csaxs_bec / test (pull_request) Failing after 1m28s
Details
87e18c3264
appel_c force-pushed add/rio-galil-set-gain from 87e18c3264 to 27befc5703 2026-02-11 08:40:08 +01:00 Compare
appel_c added 1 commit 2026-02-11 09:44:40 +01:00
fix(galilsignalbase): fix root access for controller from parent.
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m27s
Details
CI for csaxs_bec / test (pull_request) Failing after 1m29s
Details
1cbc9c0a79
appel_c requested review from holler 2026-02-11 11:53:33 +01:00
appel_c requested review from wakonig_k 2026-02-11 11:53:33 +01:00
holler approved these changes 2026-02-11 13:22:56 +01:00
holler left a comment
Member
Copy Link

Looks great. I wonder if we should set number of digital out channels to 16. Then it is compatible with other (smaller) RIO devices.
I think for now the implementation is sufficient. It contains all functionality the beamline will use from the RIO devices at this moment.

Looks great. I wonder if we should set number of digital out channels to 16. Then it is compatible with other (smaller) RIO devices. I think for now the implementation is sufficient. It contains all functionality the beamline will use from the RIO devices at this moment.
appel_c force-pushed add/rio-galil-set-gain from 1cbc9c0a79 to f925a7c1db 2026-02-16 14:57:16 +01:00 Compare
appel_c added 1 commit 2026-02-16 15:14:54 +01:00
refactor(galil-rio): fix socket-signal cached readings
Some checks failed
CI for csaxs_bec / test (pull_request) Failing after 32s
Details
CI for csaxs_bec / test (push) Failing after 35s
Details
14dcc86685
appel_c added 1 commit 2026-02-16 15:26:40 +01:00
w
Some checks failed
CI for csaxs_bec / test (push) Failing after 32s
Details
CI for csaxs_bec / test (pull_request) Failing after 34s
Details
99df973c79
appel_c force-pushed add/rio-galil-set-gain from 99df973c79 to 93384b87e0 2026-02-16 17:38:25 +01:00 Compare
appel_c added 1 commit 2026-02-16 17:48:40 +01:00
refactor(galil-rio): Improve docstring and general integration
All checks were successful
CI for csaxs_bec / test (pull_request) Successful in 1m31s
Details
CI for csaxs_bec / test (push) Successful in 1m32s
Details
5d97913956
appel_c merged commit 5d97913956 into main 2026-02-16 17:51:37 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
wakonig_k
holler
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c bec_bl_push-gitea bec-gitea celcer_t debenjak_l diaz divall_e guizar_m holler lombosi_c menzel perl_d stubbs_s usov_i wakonig_k wang_x1 wyzula_j zamofing_t
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#138
Delete Branch "add/rio-galil-set-gain"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?