bec/csaxs_bec
0
0
Fork 1
Code Issues 13 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Fix controller off call in destroy #130

Merged
appel_c merged 2 commits from fix/controller_destroy into main 2026-01-26 07:45:01 +01:00
Conversation 2 Commits 2 Files Changed 11 +69 -10
appel_c commented 2026-01-22 08:47:38 +01:00
Owner
Copy Link

After refactoring the BEC server, we have removed any controller specific logic on the device server. This means that any device needs to fully implement its own logic in the wait_for_connection and destroy methods of ophyd. This PR adds the controller.off call to the destroy method for all Galil ophyd implementations.

This should resolve the reported issue with enable/disable for Flomni.

After refactoring the BEC server, we have removed any controller specific logic on the device server. This means that any device needs to fully implement its own logic in the `wait_for_connection` and `destroy` methods of ophyd. This PR adds the `controller.off` call to the destroy method for all Galil ophyd implementations. This should resolve the reported issue with enable/disable for Flomni.
appel_c added 2 commits 2026-01-22 08:47:38 +01:00
fix(controller): Ensure that destroy calls controller.off 13dbd17f0f
test: add test for controller to call destroy controller.off
All checks were successful
CI for csaxs_bec / test (push) Successful in 1m17s
Details
CI for csaxs_bec / test (pull_request) Successful in 1m18s
Details
3b3e516a98
appel_c force-pushed fix/controller_destroy from 3b3e516a98 to 5c5a5c3d98 2026-01-22 08:50:27 +01:00 Compare
appel_c requested review from holler 2026-01-22 08:51:27 +01:00
appel_c requested review from wakonig_k 2026-01-22 08:51:27 +01:00
appel_c self-assigned this 2026-01-22 08:51:30 +01:00
wakonig_k approved these changes 2026-01-22 09:27:01 +01:00
holler approved these changes 2026-01-22 15:02:42 +01:00
appel_c merged commit 153e6a89a4 into main 2026-01-26 07:45:01 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
wakonig_k
holler
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c bec_bl_push-gitea bec-gitea celcer_t debenjak_l diaz divall_e guizar_m holler lombosi_c menzel perl_d stubbs_s usov_i wakonig_k wang_x1 wyzula_j zamofing_t
No Assignees appel_c
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#130
Delete Branch "fix/controller_destroy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?