fix/controller-migration #112

Merged

appel_c merged 5 commits from fix/controller-migration into main 2025-12-11 07:46:36 +01:00

Conversation 2 Commits 5 Files Changed 18

+532 -432

appel_c commented 2025-12-05 17:08:11 +01:00

Owner

Copy Link

Copy Source

Fix controller migration after merge in ophyd_devices. To be tested again briefly with flomni if possible.

Fix controller migration after merge in ophyd_devices. To be tested again briefly with flomni if possible.

appel_c added 4 commits 2025-12-05 17:08:11 +01:00

fix(controller): fix controller init for all controller instances, fix formatting 525f40dd8d

refactor(controller): refactor set_device_enable method from controller to set_device_read_write 190601f08a

fix(controller): add controller.on to wait_for_connection for devices with socket controllers 3a41c2130a

fix(controller): deprecate get_device_manager() in favor of dm a9b51c3465

appel_c requested review from holler 2025-12-05 17:08:21 +01:00

holler approved these changes 2025-12-08 11:46:02 +01:00

appel_c force-pushed fix/controller-migration from a9b51c3465 to 0f41648053 2025-12-09 16:51:39 +01:00 Compare

appel_c requested review from wakonig_k 2025-12-10 15:41:14 +01:00

wakonig_k approved these changes 2025-12-10 21:04:35 +01:00

appel_c merged commit 0f41648053 into main 2025-12-11 07:46:36 +01:00

appel_c referenced this pull request 2025-12-11 07:47:00 +01:00

Fix SocketController usage after ophyd_devices refactoring #109

Sign in to join this conversation.

Reviewers

No Reviewers

holler

wakonig_k

Labels

Clear labels

issue::not confirmed

Used if an issue has not yet been confirmed by a developer

issue::not reproducible

Used if an issue is not reproducible

issue::reproducible

Used if a developer was able to reproduce the issue

priority::critical

Should be done as soon as possible

priority::needed

An important update to the code base

priority::nice to have

Not really needed but a good improvement

scope::backend

An issue regarding the backend services

scope::frontend

An issue regarding the user-facing services

stage::in development

This issue is currently being worked on

stage::on hold

Something is blocking the development

stage::pre_release

For issues that have been merged into a pre-release branch and are waiting for their release.

stage::ready for review

For issues that have been resolved and are ready for review

stage::selected for development

This issue has been selected for development but has not been scheduled yet

stage::weekly backlog

This issue has been selected for development for the next development cycle

type::bug

It's a bug!

type::discussion

A discussion is wanted/needed

type::doc

Improvements to the documentation

type::feature

A new feature

type::improvement

Neither a feature nor a bug but an improvement to the code base

type::test

Missing tests or improvements to the test suite

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

acerbo_a (acerbo_a) appel_c (appel_c) bec-gitea celcer_t (celcer_t) debenjak_l (debenjak_l) diaz (diaz) divall_e (divall_e) guizar_m (guizar_m) haghta_s (haghta_s) holler (holler) lombosi_c (lombosi_c) menzel (menzel) perl_d (perl_d) usov_i (usov_i) wakonig_k (wakonig_k) wang_x1 (wang_x1) wyzula_j (wyzula_j) zamofing_t (zamofing_t)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bec/csaxs_bec#112