bec/csaxs_bec
0
0
Fork 1
Code Issues 13 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Fix SocketController usage after ophyd_devices refactoring #109

Closed
appel_c wants to merge 5 commits from fix/refactor_controller_ophyd_devices into main
pull from: fix/refactor_controller_ophyd_devices
merge into: bec:main
Conversation 1 Commits 5 Files Changed 21 +709 -483
appel_c commented 2025-11-25 16:35:42 +01:00
Owner
Copy Link

This PR fixes the usage of the SocketController for the integrations at cSAXS. Most relevant changes are renaming the set_device_enable method to change_device_read_write, adding that the device_manager is passed to the controller, and adding the wait_for_connection method for all devices with a controller such that wait_for_connection(timeout=timeout) calls controller.on(timeout=timeout) with the specified timeout.

This PR fixes the usage of the SocketController for the integrations at cSAXS. Most relevant changes are renaming the `set_device_enable` method to `change_device_read_write`, adding that the device_manager is passed to the controller, and adding the `wait_for_connection` method for all devices with a controller such that `wait_for_connection(timeout=timeout)` calls `controller.on(timeout=timeout)` with the specified timeout.
appel_c added 3 commits 2025-11-25 16:35:43 +01:00
fix(controller): fix controller init for all controller instances, fix formatting 525f40dd8d
refactor(controller): refactor set_device_enable method from controller to set_device_read_write 190601f08a
fix(controller): add controller.on to wait_for_connection for devices with socket controllers
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m11s
Details
CI for csaxs_bec / test (pull_request) Failing after 1m50s
Details
3a41c2130a
appel_c requested review from wakonig_k 2025-11-25 16:35:51 +01:00
wakonig_k added 1 commit 2025-11-25 17:45:38 +01:00
wip - rt flyer
Some checks failed
CI for csaxs_bec / test (push) Failing after 11m42s
Details
CI for csaxs_bec / test (pull_request) Failing after 12m8s
Details
28da69a38c
bec_bl_push-gitea added 1 commit 2025-11-28 17:27:54 +01:00
wip changes from the beamline
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m8s
Details
CI for csaxs_bec / test (pull_request) Failing after 1m15s
Details
5d87b03018
appel_c commented 2025-12-11 07:47:00 +01:00
Author
Owner
Copy Link

closed in favor of #112

closed in favor of #112
appel_c closed this pull request 2025-12-11 07:47:00 +01:00
Some checks failed
CI for csaxs_bec / test (push) Failing after 1m8s
Details
CI for csaxs_bec / test (pull_request) Failing after 1m15s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
wakonig_k
Labels
Clear labels
issue::not confirmed
Used if an issue has not yet been confirmed by a developer
 issue::not reproducible
Used if an issue is not reproducible
 issue::reproducible
Used if a developer was able to reproduce the issue
 priority::critical
Should be done as soon as possible
 priority::needed
An important update to the code base
 priority::nice to have
Not really needed but a good improvement
 scope::backend
An issue regarding the backend services
 scope::frontend
An issue regarding the user-facing services
 stage::in development
This issue is currently being worked on
 stage::on hold
Something is blocking the development
 stage::pre_release
For issues that have been merged into a pre-release branch and are waiting for their release.
stage::ready for review
For issues that have been resolved and are ready for review
 stage::selected for development
This issue has been selected for development but has not been scheduled yet
 stage::weekly backlog
This issue has been selected for development for the next development cycle
 type::bug
It's a bug!
 type::discussion
A discussion is wanted/needed
 type::doc
Improvements to the documentation
 type::feature
A new feature
 type::improvement
Neither a feature nor a bug but an improvement to the code base
 type::test
Missing tests or improvements to the test suite
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
acerbo_a appel_c bec_bl_push-gitea bec-gitea celcer_t debenjak_l diaz divall_e guizar_m holler lombosi_c menzel perl_d stubbs_s usov_i wakonig_k wang_x1 wyzula_j zamofing_t
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bec/csaxs_bec#109
Delete Branch "fix/refactor_controller_ophyd_devices"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?