2 Commits

Include renames

Author	SHA1	Message	Date
x01dcandClaude Sonnet 5	437d9e7559	feat(flomni): fix tomo-queue move allow-list, drop idgap stub, add foptz+shift action ... Queue-control "command job" changes: - Remove the "optimize_idgap" stub action (not commissioned, always a no-op) from both Flomni's and LamNI's action registry, and delete the now-dead TomoQueueMixin.optimize_idgap() method. - Fix the "move" action's device allow-list: "mokev" doesn't exist in the current device config at all -- the real energy device is "ccm_energy" (LamNI's copy already had this right). Also drop "ftray" (sample transfer tray), which was only ever there as a sim-testable move target. - Add a new "move_foptz_with_shift" action: moves foptz (the FZP optics-Z stage) and sets the compensating manual_shift_x/manual_shift_y in one atomic step. foptz is deliberately NOT in the plain move allow-list -- moving it shifts the aligned scan center (interferometer mirrors aren't perfectly parallel to the beam), so this is the only way to queue a foptz move, specifically so the compensating shift can never be forgotten. - The foptz target is validated against the device's real, live limits (not a hand-duplicated static number) both in the GUI spinbox's range and in the CLI's add-time validation, so a queued job can't raise when it executes unattended later; a defense-in-depth check also exists at execution time. Retargeted the e2e command-job tests from ftray to foptz (now the only sim-testable move-adjacent path) and updated the AI_docs testing/GUI-testing notes to match the new action set. Also fixes a pre-existing, unrelated broken import (plugins.omny.omny_general_tools -> plugins.OMNY_shared.omny_general_tools, already broken on main) in _bootstrap.py/test_tomo_queue.py/ test_tomo_queue_command_jobs.py that was blocking omny_e2e_tests collection entirely, needed to actually verify this change's own test rewrites. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPZ9gzN2rt3wgiMnTKyrug	2026-10-01 15:11:49 +02:00
Mirko Holler	30b5119a2f	feat(flomni): add command jobs to the tomo queue ... Type-tags queue jobs with a "kind" field (back-compat: missing kind defaults to "tomo"), and adds "command" jobs that reconfigure the beamline (currently: absolute moves on an allow-listed device, plus an optimize_idgap stub) between tomograms instead of running a scan. Command jobs are added via tomo_queue_add_command() against a curated named-action registry (_TOMO_QUEUE_ACTIONS) - not arbitrary code - so every queued action is auditable and safe to persist across a kernel restart. Validation is two-layer: schema checks at add time, and each action re-checks its own arguments against live hardware at execution time, which is the actual safety boundary. Crash-resume for a command job re-runs the whole step sequence from the top if every step is idempotent, or prompts the operator otherwise. flomni_webpage_generator.py is guarded against command jobs, which have no "params" key. See AI_docs/TOMO_QUEUE_COMMAND_JOBS_PLAN.md for the full design.	2026-07-13 09:05:29 +02:00