Merge pull request #166 from tiqi-group/fix/logging_settings

fix: removes basic configuration of logging system in task module

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "pydase"
-version = "0.10.3"
+version = "0.10.5"
 description = "A flexible and robust Python library for creating, managing, and interacting with data services, with built-in support for web and RPC servers, and customizable features for diverse use cases."
 authors = ["Mose Mueller <mosmuell@ethz.ch>"]
 readme = "README.md"

src/pydase/client/client.py

@@ -8,7 +8,6 @@ import socketio  # type: ignore
 
 import pydase.components
 from pydase.client.proxy_loader import ProxyClassMixin, ProxyLoader
-from pydase.utils.helpers import current_event_loop_exists
 from pydase.utils.serialization.deserializer import loads
 from pydase.utils.serialization.types import SerializedDataService, SerializedObject
 
@@ -32,10 +31,7 @@ class NotifyDict(TypedDict):
 
 def asyncio_loop_thread(loop: asyncio.AbstractEventLoop) -> None:
     asyncio.set_event_loop(loop)
-    try:
-        loop.run_forever()
-    except RuntimeError:
-        logger.debug("Tried starting even loop, but it is running already")
+    loop.run_forever()
 
 
 class ProxyClass(ProxyClassMixin, pydase.components.DeviceConnection):
@@ -109,11 +105,7 @@ class Client:
     ):
         self._url = url
         self._sio = socketio.AsyncClient()
-        if not current_event_loop_exists():
-            self._loop = asyncio.new_event_loop()
-            asyncio.set_event_loop(self._loop)
-        else:
-            self._loop = asyncio.get_event_loop()
+        self._loop = asyncio.new_event_loop()
         self.proxy = ProxyClass(sio_client=self._sio, loop=self._loop)
         """A proxy object representing the remote service, facilitating interaction as
         if it were local."""

src/pydase/data_service/data_service.py

@@ -10,6 +10,7 @@ from pydase.observer_pattern.observable.observable import (
 )
 from pydase.utils.helpers import (
     get_class_and_instance_attributes,
+    is_descriptor,
     is_property_attribute,
 )
 from pydase.utils.serialization.serializer import (
@@ -68,7 +69,7 @@ class DataService(AbstractDataService):
         if not issubclass(
             value_class,
             (int | float | bool | str | list | dict | Enum | u.Quantity | Observable),
-        ):
+        ) and not is_descriptor(__value):
             logger.warning(
                 "Class '%s' does not inherit from DataService. This may lead to"
                 " unexpected behaviour!",

src/pydase/task/task.py

@@ -1,24 +1,16 @@
 import asyncio
 import inspect
 import logging
-import sys
 from collections.abc import Callable, Coroutine
 from typing import (
     Generic,
     TypeVar,
 )
 
-from pydase.task.task_status import TaskStatus
-
-if sys.version_info < (3, 11):
-    pass
-else:
-    pass
-
 import pydase.data_service.data_service
+from pydase.task.task_status import TaskStatus
 from pydase.utils.helpers import current_event_loop_exists
 
-logging.basicConfig(level=logging.DEBUG)
 logger = logging.getLogger(__name__)
 
 R = TypeVar("R")