zebra/pyzebra
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

peak fitting #68

Merged
usov_i merged 6 commits from JakHolzer-fit_peak into det1d 2020-09-15 14:23:49 +02:00
Conversation 8 Commits 6 Files Changed 1 +156
usov_i commented 2020-09-10 15:28:35 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Created by: JakHolzer

Fit one peak from ccl as combination of gaussian, lorentian and backgroud

*Created by: JakHolzer* Fit one peak from ccl as combination of gaussian, lorentian and backgroud
usov_i commented 2020-09-11 11:16:26 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Created by: ivan-usov

Same with the guard clause. For long functions it's better to do the early exit, rather than indent the entire function.

*Created by: ivan-usov* Same with the guard clause. For long functions it's better to do the early exit, rather than indent the entire function.
usov_i commented 2020-09-11 11:18:15 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Created by: ivan-usov

Fitting and plotting needs to be separated into different functions. Otherwise, I won't be able to use only fitting in the web app, since the plotting part will be different.

*Created by: ivan-usov* Fitting and plotting needs to be separated into different functions. Otherwise, I won't be able to use only fitting in the web app, since the plotting part will be different.
usov_i commented 2020-09-11 13:37:21 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Created by: JakHolzer

The plotting is not integral part to the function - I used to see what are the results and though it might help you to get the right data without having to search the dictionary. Therefore, it can be deleted or commented

*Created by: JakHolzer* The plotting is not integral part to the function - I used to see what are the results and though it might help you to get the right data without having to search the dictionary. Therefore, it can be deleted or commented
usov_i commented 2020-09-11 14:18:24 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Created by: ivan-usov

I would delete it then. However, it might be useful as a separate utility function in case of using jupyter notebook directly. Feel free to extract it, or remove the lines completely.

*Created by: ivan-usov* I would delete it then. However, it might be useful as a separate utility function in case of using jupyter notebook directly. Feel free to extract it, or remove the lines completely.
usov_i commented 2020-09-11 15:06:56 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Created by: JakHolzer

I removed it, but still have the original file which I use to verification, so if it would be useful or if you would like to call it as s function, let me know.

*Created by: JakHolzer* I removed it, but still have the original file which I use to verification, so if it would be useful or if you would like to call it as s function, let me know.
usov_i commented 2020-09-11 15:46:09 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Created by: JakHolzer

done 👍

*Created by: JakHolzer* done 👍
usov_i commented 2020-09-15 14:23:19 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Created by: ivan-usov

Review: Approved

*Created by: ivan-usov* **Review:** Approved
usov_i commented 2020-09-15 14:23:49 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Merged by: ivan-usov at 2020-09-15 12:23:49 UTC

*Merged by: ivan-usov at 2020-09-15 12:23:49 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
sibille_r usov_i zaharko
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zebra/pyzebra#68
No description provided.
Delete Branch "JakHolzer-fit_peak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?