Updated load_1D.py #63

2020-09-10T15:09:38+02:00

usov_i commented

2020-09-10 15:09:38 +02:00

(Migrated from gitlab.psi.ch)

Created by: JakHolzer

Try, except deleted.
Added one if/elif loop to tell apart zebra mode (bi, nb) and different angles saved

*Created by: JakHolzer* Try, except deleted. Added one if/elif loop to tell apart zebra mode (bi, nb) and different angles saved

usov_i commented

2020-09-11 14:06:44 +02:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

@JakHolzer , how about to use is_integer() (https://docs.python.org/3/library/stdtypes.html#float.is_integer) instead? I don't think that complicated logic with Decimal is needed.

*Created by: ivan-usov* @JakHolzer , how about to use `is_integer()` (https://docs.python.org/3/library/stdtypes.html#float.is_integer) instead? I don't think that complicated logic with `Decimal` is needed.

usov_i commented

2020-09-11 15:24:41 +02:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

Reading 'dat' files breaks at this line.

*Created by: ivan-usov* Reading 'dat' files breaks at this line.

usov_i commented

2020-09-11 18:02:14 +02:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

Review: Changes requested

I left a few comments, but not sure they didn't result in a review.

*Created by: ivan-usov* **Review:** Changes requested I left a few comments, but not sure they didn't result in a review.

usov_i commented

2020-09-15 14:25:11 +02:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

Review: Approved

*Created by: ivan-usov* **Review:** Approved

usov_i commented

2020-09-15 14:25:25 +02:00

(Migrated from gitlab.psi.ch)

Merged by: ivan-usov at 2020-09-15 12:25:25 UTC

*Merged by: ivan-usov at 2020-09-15 12:25:25 UTC*

usov_i commented

2020-09-15 15:11:47 +02:00

(Migrated from gitlab.psi.ch)

Created by: JakHolzer

The reason is that the hkl are in ccl in float format even for hkl, they
are for example -1.000 1.000 0.000, therefore they will be evaluated as
floats, not integer if I'm not mistaken. The decimal checks if there are
some numbers except zeros after decimal points which is only way how to
separate hkl from real indices.

pá 11. 9. 2020 v 14:07 odesílatel Ivan Usov notifications@github.com
napsal:

@JakHolzer https://github.com/JakHolzer , how about to use is_integer()
(https://docs.python.org/3/library/stdtypes.html#float.is_integer)
instead? I don't think that complicated logic with Decimal is needed.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/paulscherrerinstitute/pyzebra/pull/5#issuecomment-691054453,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM2BBRWB7B7CNYHZJWBNVRTSFIHGJANCNFSM4RFAMJOA
.

*Created by: JakHolzer* The reason is that the hkl are in ccl in float format even for hkl, they are for example -1.000 1.000 0.000, therefore they will be evaluated as floats, not integer if I'm not mistaken. The decimal checks if there are some numbers except zeros after decimal points which is only way how to separate hkl from real indices. pá 11. 9. 2020 v 14:07 odesílatel Ivan Usov <notifications@github.com> napsal: > @JakHolzer <https://github.com/JakHolzer> , how about to use is_integer() > (https://docs.python.org/3/library/stdtypes.html#float.is_integer) > instead? I don't think that complicated logic with Decimal is needed. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/paulscherrerinstitute/pyzebra/pull/5#issuecomment-691054453>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AM2BBRWB7B7CNYHZJWBNVRTSFIHGJANCNFSM4RFAMJOA> > . >

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zebra/pyzebra#63