zebra/pyzebra
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add files via upload #62

Closed
usov_i wants to merge 1 commits from JakHolzer-improved-load1D-data into master
pull from: JakHolzer-improved-load1D-data
merge into: zebra:master
Conversation 3 Commits 1 Files Changed 1 +108
usov_i commented 2020-09-03 14:16:00 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Created by: JakHolzer

*Created by: JakHolzer*
usov_i commented 2020-09-07 10:36:03 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Created by: ivan-usov

I would omit try, except here, because it doesn't improve the error message. Compare, with the situation without this try, except:

FileNotFoundError: [Errno 2] No such file or directory: 'test'
*Created by: ivan-usov* I would omit `try, except` here, because it doesn't improve the error message. Compare, with the situation without this `try, except`: ``` FileNotFoundError: [Errno 2] No such file or directory: 'test' ```
usov_i commented 2020-09-07 10:51:52 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Created by: ivan-usov

Review: Changes requested

@JakHolzer , great improvement over the prev version! Just one more comment, make sure to place the new file inside pyzebra folder.

*Created by: ivan-usov* **Review:** Changes requested @JakHolzer , great improvement over the prev version! Just one more comment, make sure to place the new file inside pyzebra folder.
usov_i commented 2020-09-10 14:58:34 +02:00 (Migrated from gitlab.psi.ch)
Copy Link

Created by: JakHolzer

Alright, try, except deleted. I put those there to go around exceptions which I'm not yet sure how to solve so it doesent crash the execution of modules.

*Created by: JakHolzer* Alright, try, except deleted. I put those there to go around exceptions which I'm not yet sure how to solve so it doesent crash the execution of modules.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
sibille_r usov_i zaharko
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zebra/pyzebra#62
No description provided.
Delete Branch "JakHolzer-improved-load1D-data"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?