Add files via upload #62

2020-09-03T14:16:00+02:00

usov_i commented

2020-09-03 14:16:00 +02:00

(Migrated from gitlab.psi.ch)

Created by: JakHolzer

*Created by: JakHolzer*

usov_i commented

2020-09-07 10:36:03 +02:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

I would omit try, except here, because it doesn't improve the error message. Compare, with the situation without this try, except:

FileNotFoundError: [Errno 2] No such file or directory: 'test'

*Created by: ivan-usov* I would omit `try, except` here, because it doesn't improve the error message. Compare, with the situation without this `try, except`: ``` FileNotFoundError: [Errno 2] No such file or directory: 'test' ```

usov_i commented

2020-09-07 10:51:52 +02:00

(Migrated from gitlab.psi.ch)

Created by: ivan-usov

Review: Changes requested

@JakHolzer , great improvement over the prev version! Just one more comment, make sure to place the new file inside pyzebra folder.

*Created by: ivan-usov* **Review:** Changes requested @JakHolzer , great improvement over the prev version! Just one more comment, make sure to place the new file inside pyzebra folder.

usov_i commented

2020-09-10 14:58:34 +02:00

(Migrated from gitlab.psi.ch)

Created by: JakHolzer

Alright, try, except deleted. I put those there to go around exceptions which I'm not yet sure how to solve so it doesent crash the execution of modules.

*Created by: JakHolzer* Alright, try, except deleted. I put those there to go around exceptions which I'm not yet sure how to solve so it doesent crash the execution of modules.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: zebra/pyzebra#62