tligui_y/slic
0
0
Fork 0
forked from slic/slic
Code Pull Requests Actions Wiki Activity

CI: update test report and coverage files

Browse Source
This commit is contained in:
ci-bot
2025-08-17 15:03:27 +00:00
parent be6e13e67d
commit e4cce9ed2f
3 changed files with 310 additions and 130 deletions
Download Patch File Download Diff File Expand all files Collapse all files
markdown/TEST-REPORT.md
+82 -129
View File
@@ -1,21 +1,20 @@
# 🧪 Test Report
*Generated on 2025-08-17 16:51:38 CEST*
*Generated on 2025-08-17 17:03:27 CEST*
## 🧾 General Info
- **duration**: 6.380007743835449
- **duration**: 5.5131516456604
- **root**: /workspace/tligui_y/slic
- **environment**: {}
## 📋 Summary
- **Passed**: 6
- **Failed**: 1
- **Passed**: 7
- **Total**: 7
- **Collected**: 7
## 🔎 Tests
<details>
<summary>✅ Passed (6)</summary>
<summary>✅ Passed (7)</summary>
- <details>
<summary>📄 <span style="color: #00695C; font-weight: bold">test_utils_dbusnotify.py</span></summary>
@@ -29,7 +28,7 @@
**duration:**
```python
0.33088933303952217
4.188622790388763
```
**outcome:**
@@ -43,7 +42,7 @@
**duration:**
```python
0.0012313690967857838
0.001798082608729601
```
**outcome:**
@@ -57,7 +56,7 @@
**duration:**
```python
0.000427046325057745
0.0003997618332505226
```
**outcome:**
@@ -75,7 +74,7 @@
**duration:**
```python
0.000694718211889267
0.0011017806828022003
```
**outcome:**
@@ -89,7 +88,7 @@
**duration:**
```python
0.0018895906396210194
0.002093132119625807
```
**outcome:**
@@ -103,7 +102,7 @@
**duration:**
```python
0.00017344392836093903
0.00019209226593375206
```
**outcome:**
@@ -121,7 +120,7 @@
**duration:**
```python
0.0006543160416185856
0.0007618078961968422
```
**outcome:**
@@ -135,7 +134,7 @@
**duration:**
```python
0.0015476769767701626
0.0016790172085165977
```
**outcome:**
@@ -149,7 +148,7 @@
**duration:**
```python
0.0001646578311920166
0.0001872270368039608
```
**outcome:**
@@ -167,7 +166,7 @@
**duration:**
```python
0.0007836646400392056
0.0007783346809446812
```
**outcome:**
@@ -181,7 +180,7 @@
**duration:**
```python
0.0015498041175305843
0.0016563357785344124
```
**outcome:**
@@ -195,7 +194,53 @@
**duration:**
```python
0.00017047440633177757
0.00018892064690589905
```
**outcome:**
```python
passed
```
</details>
↳ <span style="color: #009688; font-weight: bold">Function: </span> test_notify_and_close
- <details>
<summary>✅ Test 5</summary>
**_*📌 Setup phase*_**
**duration:**
```python
0.0007985159754753113
```
**outcome:**
```python
passed
```
**_*📌 Call phase*_**
**duration:**
```python
0.20301012229174376
```
**outcome:**
```python
passed
```
**_*📌 Teardown phase*_**
**duration:**
```python
0.00031158654019236565
```
**outcome:**
@@ -213,7 +258,7 @@
**duration:**
```python
0.0023978836834430695
0.0011320789344608784
```
**outcome:**
@@ -227,7 +272,7 @@
**duration:**
```python
0.005033673252910376
0.0019580209627747536
```
**outcome:**
@@ -252,13 +297,13 @@
stack_info: None
lineno: 628
funcName: call_blocking
created: 1755442295.583168
msecs: 583.1680297851562
relativeCreated: 6947.3936557769775
thread: 140463779292672
created: 1755443004.3486133
msecs: 348.6132621765137
relativeCreated: 6181.563854217529
thread: 140242919970304
threadName: MainThread
processName: MainProcess
process: 1898
process: 1872
```
**_*📌 Teardown phase*_**
@@ -266,7 +311,7 @@
**duration:**
```python
0.0002107461914420128
0.0002026776783168316
```
**outcome:**
@@ -284,7 +329,7 @@
**duration:**
```python
0.00016166595742106438
0.00015785591676831245
```
**outcome:**
@@ -298,7 +343,7 @@
**duration:**
```python
0.00015959236770868301
0.0001720520667731762
```
**outcome:**
@@ -312,99 +357,7 @@
**duration:**
```python
0.00026617711409926414
```
**outcome:**
```python
passed
```
</details>
</details>
</details>
<details>
<summary>❌ Failed (1)</summary>
- <details>
<summary>📄 <span style="color: #00695C; font-weight: bold">test_utils_dbusnotify.py</span></summary>
↳ <span style="color: #009688; font-weight: bold">Function: </span> test_notify_and_close
- <details>
<summary>❌ Test 5</summary>
**_*📌 Setup phase*_**
**duration:**
```python
0.0006275693885982037
```
**outcome:**
```python
passed
```
**_*📌 Call phase*_**
**duration:**
```python
1.0044602882117033
```
**outcome:**
```python
failed
```
**crash:**
```python
path: /workspace/tligui_y/slic/tests/test_utils_dbusnotify.py
lineno: 123
message: TypeError: '_ProxyMethod' object is not iterable
```
**traceback:**
```python
- path: tests/test_utils_dbusnotify.py
lineno: 123
message: TypeError
```
**longrepr:**
```python
notifier = <slic.utils.dbusnotify.DBusNotify object at 0x7fbff0a53640>
def test_notify_and_close(notifier):
"""Test l'envoi d'une notification et sa fermeture."""
notification = notifier.notify("Test Close", "This notification will be closed.")
time.sleep(1)
notification.close()
printed_lines = notification.dbn.interface._prints
> assert not any(f"Notification {notification.nid} is still visible" in line for line in printed_lines), "Notification was not closed properly."
E TypeError: '_ProxyMethod' object is not iterable
tests/test_utils_dbusnotify.py:123: TypeError
```
**_*📌 Teardown phase*_**
**duration:**
```python
0.0002911030314862728
0.00025994284078478813
```
**outcome:**
@@ -451,25 +404,25 @@
type: UnitTestCase
- nodeid: tests/test_utils_dbusnotify.py::test_notify_create
type: Function
lineno: 68
lineno: 88
- nodeid: tests/test_utils_dbusnotify.py::test_notify_update
type: Function
lineno: 78
lineno: 98
- nodeid: tests/test_utils_dbusnotify.py::test_get_server_info
type: Function
lineno: 89
lineno: 107
- nodeid: tests/test_utils_dbusnotify.py::test_get_capabilities
type: Function
lineno: 99
lineno: 118
- nodeid: tests/test_utils_dbusnotify.py::test_notify_and_close
type: Function
lineno: 113
lineno: 134
- nodeid: tests/test_utils_dbusnotify.py::test_notify_invalid_value
type: Function
lineno: 124
lineno: 155
- nodeid: tests/test_utils_dbusnotify.py::test_convert_dbus_strings
type: Function
lineno: 128
lineno: 161
```
</details>
@@ -505,7 +458,7 @@
```python
message: invalid escape sequence \-
category: DeprecationWarning
when: collect
when: runtest
filename: /workspace/tligui_y/slic/.pixi/envs/default/lib/python3.8/site-packages/bsread/h5.py
lineno: 207
```
@@ -520,7 +473,7 @@ lineno: 207
```python
message: The module numpy.dual is deprecated. Instead of using dual, use the functions directly from numpy or scipy.
category: DeprecationWarning
when: collect
when: runtest
filename: /workspace/tligui_y/slic/.pixi/envs/default/lib/python3.8/site-packages/scipy/fft/__init__.py
lineno: 97
```
markdown/coverage-summary.md
+227
View File
@@ -49539,3 +49539,230 @@
| slic/utils/utils.py | 17 | 8 | 53% |
| slic/utils/xrange.py | 33 | 30 | 9% |
| **TOTAL** | **9984** | **7429** | **26%** |
| Name | Stmts | Miss | Cover |
|----------------------------------------------- | -------: | -------: | ------: |
| slic/\_\_init\_\_.py | 20 | 2 | 90% |
| slic/core/\_\_init\_\_.py | 5 | 0 | 100% |
| slic/core/acquisition/\_\_init\_\_.py | 7 | 0 | 100% |
| slic/core/acquisition/acquisition.py | 56 | 42 | 25% |
| slic/core/acquisition/baseacquisition.py | 5 | 1 | 80% |
| slic/core/acquisition/broker/\_\_init\_\_.py | 2 | 0 | 100% |
| slic/core/acquisition/broker/brokerclient.py | 104 | 80 | 23% |
| slic/core/acquisition/broker/brokerconfig.py | 102 | 87 | 15% |
| slic/core/acquisition/broker/pedestal.py | 66 | 57 | 14% |
| slic/core/acquisition/broker/pids.py | 17 | 12 | 29% |
| slic/core/acquisition/broker/post\_retrieve.py | 120 | 120 | 0% |
| slic/core/acquisition/broker/requeststatus.py | 77 | 73 | 5% |
| slic/core/acquisition/broker/restapi.py | 147 | 107 | 27% |
| slic/core/acquisition/broker/tools.py | 52 | 18 | 65% |
| slic/core/acquisition/bsacquisition.py | 10 | 3 | 70% |
| slic/core/acquisition/bschannels.py | 30 | 19 | 37% |
| slic/core/acquisition/channels.py | 51 | 30 | 41% |
| slic/core/acquisition/dbacquisition.py | 19 | 12 | 37% |
| slic/core/acquisition/detcfg.py | 82 | 35 | 57% |
| slic/core/acquisition/diaacquisition.py | 111 | 111 | 0% |
| slic/core/acquisition/diaconfig.py | 36 | 36 | 0% |
| slic/core/acquisition/dummyacquisition.py | 12 | 12 | 0% |
| slic/core/acquisition/fakeacquisition.py | 76 | 53 | 30% |
| slic/core/acquisition/pedestals.py | 69 | 69 | 0% |
| slic/core/acquisition/pvacquisition.py | 60 | 47 | 22% |
| slic/core/acquisition/pvchannels.py | 13 | 7 | 46% |
| slic/core/acquisition/sfacquisition.py | 159 | 129 | 19% |
| slic/core/acquisition/sfpaths.py | 23 | 19 | 17% |
| slic/core/acquisition/spreadsheet.py | 45 | 45 | 0% |
| slic/core/adjustable/\_\_init\_\_.py | 11 | 0 | 100% |
| slic/core/adjustable/adjustable.py | 50 | 30 | 40% |
| slic/core/adjustable/baseadjustable.py | 28 | 18 | 36% |
| slic/core/adjustable/collection.py | 22 | 14 | 36% |
| slic/core/adjustable/combined.py | 15 | 8 | 47% |
| slic/core/adjustable/convenience.py | 35 | 20 | 43% |
| slic/core/adjustable/converted.py | 16 | 10 | 38% |
| slic/core/adjustable/dummyadjustable.py | 41 | 30 | 27% |
| slic/core/adjustable/error.py | 2 | 0 | 100% |
| slic/core/adjustable/genericadjustable.py | 32 | 24 | 25% |
| slic/core/adjustable/limited.py | 29 | 18 | 38% |
| slic/core/adjustable/linked.py | 22 | 15 | 32% |
| slic/core/adjustable/pvadjustable.py | 119 | 91 | 24% |
| slic/core/adjustable/pvchangemon.py | 77 | 56 | 27% |
| slic/core/adjustable/pvenumadjustable.py | 38 | 22 | 42% |
| slic/core/adjustable/scaler.py | 22 | 16 | 27% |
| slic/core/condition/\_\_init\_\_.py | 2 | 0 | 100% |
| slic/core/condition/basecondition.py | 8 | 2 | 75% |
| slic/core/condition/condition.py | 107 | 79 | 26% |
| slic/core/condition/pvcondition.py | 21 | 12 | 43% |
| slic/core/condition/valuecondition.py | 22 | 15 | 32% |
| slic/core/device/\_\_init\_\_.py | 2 | 0 | 100% |
| slic/core/device/auto.py | 12 | 12 | 0% |
| slic/core/device/basedevice.py | 2 | 0 | 100% |
| slic/core/device/device.py | 46 | 35 | 24% |
| slic/core/device/filtered.py | 23 | 23 | 0% |
| slic/core/device/simpledevice.py | 6 | 2 | 67% |
| slic/core/scanner/\_\_init\_\_.py | 1 | 0 | 100% |
| slic/core/scanner/runname.py | 36 | 23 | 36% |
| slic/core/scanner/scanbackend.py | 232 | 197 | 15% |
| slic/core/scanner/scaninfo.py | 45 | 35 | 22% |
| slic/core/scanner/scanner.py | 136 | 89 | 35% |
| slic/core/sensor/\_\_init\_\_.py | 8 | 0 | 100% |
| slic/core/sensor/basesensor.py | 12 | 3 | 75% |
| slic/core/sensor/bscombined.py | 9 | 5 | 44% |
| slic/core/sensor/bsmonitor.py | 102 | 73 | 28% |
| slic/core/sensor/bsnorm.py | 12 | 7 | 42% |
| slic/core/sensor/bssensor.py | 6 | 2 | 67% |
| slic/core/sensor/combined.py | 31 | 20 | 35% |
| slic/core/sensor/monitor.py | 62 | 51 | 18% |
| slic/core/sensor/norm.py | 9 | 5 | 44% |
| slic/core/sensor/pvsensor.py | 32 | 20 | 38% |
| slic/core/sensor/remoteplot.py | 15 | 10 | 33% |
| slic/core/sensor/sensor.py | 60 | 42 | 30% |
| slic/core/task/\_\_init\_\_.py | 4 | 0 | 100% |
| slic/core/task/basetask.py | 11 | 3 | 73% |
| slic/core/task/daqtask.py | 23 | 16 | 30% |
| slic/core/task/loop.py | 57 | 40 | 30% |
| slic/core/task/producer.py | 25 | 18 | 28% |
| slic/core/task/task.py | 62 | 46 | 26% |
| slic/devices/\_\_init\_\_.py | 7 | 0 | 100% |
| slic/devices/cameras/\_\_init\_\_.py | 4 | 0 | 100% |
| slic/devices/cameras/basler.py | 8 | 4 | 50% |
| slic/devices/cameras/camera\_bs.py | 13 | 8 | 38% |
| slic/devices/cameras/camera\_ca.py | 34 | 19 | 44% |
| slic/devices/cameras/camerabase.py | 17 | 12 | 29% |
| slic/devices/cameras/screenpanel.py | 31 | 21 | 32% |
| slic/devices/endstations/\_\_init\_\_.py | 3 | 0 | 100% |
| slic/devices/endstations/alvra\_flex.py | 10 | 5 | 50% |
| slic/devices/endstations/alvra\_huber.py | 8 | 4 | 50% |
| slic/devices/endstations/alvra\_prime.py | 48 | 34 | 29% |
| slic/devices/endstations/alvra\_xtg.py | 8 | 8 | 0% |
| slic/devices/endstations/bernina\_cameras.py | 33 | 33 | 0% |
| slic/devices/endstations/bernina\_platform.py | 46 | 46 | 0% |
| slic/devices/general/\_\_init\_\_.py | 4 | 0 | 100% |
| slic/devices/general/delay\_compensation.py | 13 | 13 | 0% |
| slic/devices/general/delay\_stage.py | 57 | 30 | 47% |
| slic/devices/general/detectors/\_\_init\_\_.py | 2 | 0 | 100% |
| slic/devices/general/detectors/buffer.py | 66 | 35 | 47% |
| slic/devices/general/detectors/digitizer.py | 13 | 7 | 46% |
| slic/devices/general/detectors/pvdatastream.py | 33 | 24 | 27% |
| slic/devices/general/detectors/timer.py | 15 | 9 | 40% |
| slic/devices/general/micosstage.py | 7 | 7 | 0% |
| slic/devices/general/motor.py | 128 | 88 | 31% |
| slic/devices/general/shutter.py | 22 | 12 | 45% |
| slic/devices/general/shutterctx.py | 18 | 7 | 61% |
| slic/devices/general/smaract.py | 169 | 125 | 26% |
| slic/devices/loptics/\_\_init\_\_.py | 2 | 0 | 100% |
| slic/devices/loptics/alvra\_explaser.py | 29 | 21 | 28% |
| slic/devices/loptics/bernina\_explaser.py | 28 | 28 | 0% |
| slic/devices/loptics/lasershutter.py | 22 | 14 | 36% |
| slic/devices/timing/\_\_init\_\_.py | 0 | 0 | 100% |
| slic/devices/timing/events/\_\_init\_\_.py | 3 | 3 | 0% |
| slic/devices/timing/events/codes.py | 5 | 5 | 0% |
| slic/devices/timing/events/ctaseq.py | 190 | 190 | 0% |
| slic/devices/timing/events/evr.py | 37 | 37 | 0% |
| slic/devices/timing/events/tma.py | 40 | 40 | 0% |
| slic/devices/timing/lasertiming.py | 253 | 184 | 27% |
| slic/devices/xdiagnostics/\_\_init\_\_.py | 2 | 0 | 100% |
| slic/devices/xdiagnostics/intensitymonitor.py | 124 | 92 | 26% |
| slic/devices/xdiagnostics/profilemonitor.py | 19 | 9 | 53% |
| slic/devices/xdiagnostics/timetools.py | 48 | 48 | 0% |
| slic/devices/xoptics/\_\_init\_\_.py | 7 | 0 | 100% |
| slic/devices/xoptics/aramis\_attenuator.py | 96 | 66 | 31% |
| slic/devices/xoptics/aramis\_reflaser.py | 23 | 15 | 35% |
| slic/devices/xoptics/dcm.py | 211 | 162 | 23% |
| slic/devices/xoptics/kb.py | 30 | 18 | 40% |
| slic/devices/xoptics/offsetmirrors.py | 9 | 5 | 44% |
| slic/devices/xoptics/pulsepicker.py | 56 | 34 | 39% |
| slic/devices/xoptics/slits/\_\_init\_\_.py | 5 | 0 | 100% |
| slic/devices/xoptics/slits/slitblades.py | 66 | 48 | 27% |
| slic/devices/xoptics/slits/slittwinunit.py | 12 | 6 | 50% |
| slic/devices/xoptics/slits/slitunit.py | 14 | 8 | 43% |
| slic/devices/xoptics/slits/slitunitcw.py | 7 | 3 | 57% |
| slic/devices/xoptics/slits/slitunitjj.py | 8 | 5 | 38% |
| slic/gui/\_\_init\_\_.py | 1 | 0 | 100% |
| slic/gui/daqframe.py | 75 | 54 | 28% |
| slic/gui/daqpanels/\_\_init\_\_.py | 6 | 0 | 100% |
| slic/gui/daqpanels/config.py | 98 | 80 | 18% |
| slic/gui/daqpanels/goto.py | 92 | 76 | 17% |
| slic/gui/daqpanels/run.py | 56 | 46 | 18% |
| slic/gui/daqpanels/scan2d.py | 77 | 66 | 14% |
| slic/gui/daqpanels/scan.py | 63 | 54 | 14% |
| slic/gui/daqpanels/sfx.py | 77 | 60 | 22% |
| slic/gui/daqpanels/special.py | 63 | 54 | 14% |
| slic/gui/daqpanels/static.py | 46 | 37 | 20% |
| slic/gui/daqpanels/tools.py | 140 | 114 | 19% |
| slic/gui/daqpanels/tweak.py | 149 | 127 | 15% |
| slic/gui/gui.py | 16 | 10 | 38% |
| slic/gui/icon.py | 8 | 2 | 75% |
| slic/gui/persist.py | 68 | 48 | 29% |
| slic/gui/widgets/\_\_init\_\_.py | 11 | 0 | 100% |
| slic/gui/widgets/alarm.py | 21 | 11 | 48% |
| slic/gui/widgets/alternative.py | 51 | 40 | 22% |
| slic/gui/widgets/boxes.py | 33 | 26 | 21% |
| slic/gui/widgets/checkbox.py | 8 | 4 | 50% |
| slic/gui/widgets/completers.py | 27 | 19 | 30% |
| slic/gui/widgets/dyncombo.py | 49 | 49 | 0% |
| slic/gui/widgets/entries.py | 253 | 195 | 23% |
| slic/gui/widgets/exc2warn.py | 15 | 13 | 13% |
| slic/gui/widgets/fname.py | 60 | 47 | 22% |
| slic/gui/widgets/jfcfg.py | 290 | 230 | 21% |
| slic/gui/widgets/jfmodcoords.py | 88 | 70 | 20% |
| slic/gui/widgets/labeled.py | 19 | 7 | 63% |
| slic/gui/widgets/lists.py | 96 | 73 | 24% |
| slic/gui/widgets/mods.py | 25 | 17 | 32% |
| slic/gui/widgets/nope.py | 26 | 19 | 27% |
| slic/gui/widgets/plotting.py | 68 | 47 | 31% |
| slic/gui/widgets/tools.py | 11 | 7 | 36% |
| slic/gui/widgets/twobuttons.py | 43 | 30 | 30% |
| slic/gui/wxdebug.py | 15 | 7 | 53% |
| slic/utils/\_\_init\_\_.py | 24 | 0 | 100% |
| slic/utils/argfwd.py | 53 | 14 | 74% |
| slic/utils/ask\_yes\_no.py | 27 | 20 | 26% |
| slic/utils/channels.py | 17 | 12 | 29% |
| slic/utils/config.py | 5 | 2 | 60% |
| slic/utils/cprint.py | 41 | 16 | 61% |
| slic/utils/dbusnotify.py | 40 | 0 | 100% |
| slic/utils/debug.py | 16 | 12 | 25% |
| slic/utils/dictext.py | 30 | 19 | 37% |
| slic/utils/dotdir.py | 10 | 1 | 90% |
| slic/utils/duo.py | 77 | 45 | 42% |
| slic/utils/elog.py | 31 | 21 | 32% |
| slic/utils/eval.py | 49 | 37 | 24% |
| slic/utils/exceptions.py | 22 | 14 | 36% |
| slic/utils/get\_adj.py | 17 | 11 | 35% |
| slic/utils/hastyepics.py | 37 | 25 | 32% |
| slic/utils/ioc/\_\_init\_\_.py | 1 | 1 | 0% |
| slic/utils/ioc/adjdrv.py | 31 | 31 | 0% |
| slic/utils/ioc/ioc.py | 63 | 63 | 0% |
| slic/utils/ipy.py | 22 | 15 | 32% |
| slic/utils/jsonext.py | 24 | 16 | 33% |
| slic/utils/lazypv.py | 12 | 12 | 0% |
| slic/utils/logbook.py | 442 | 442 | 0% |
| slic/utils/logbook\_exceptions.py | 13 | 13 | 0% |
| slic/utils/logcfg.py | 52 | 2 | 96% |
| slic/utils/logign.py | 22 | 14 | 36% |
| slic/utils/marker.py | 48 | 31 | 35% |
| slic/utils/metaclasses.py | 8 | 0 | 100% |
| slic/utils/namespace.py | 5 | 1 | 80% |
| slic/utils/npy.py | 71 | 56 | 21% |
| slic/utils/opmsg.py | 122 | 122 | 0% |
| slic/utils/path.py | 32 | 24 | 25% |
| slic/utils/picklio.py | 7 | 3 | 57% |
| slic/utils/printing.py | 77 | 61 | 21% |
| slic/utils/pv.py | 30 | 20 | 33% |
| slic/utils/pvpreload.py | 50 | 19 | 62% |
| slic/utils/pyepics.py | 64 | 39 | 39% |
| slic/utils/rangebar.py | 92 | 61 | 34% |
| slic/utils/readable.py | 12 | 9 | 25% |
| slic/utils/registry.py | 33 | 19 | 42% |
| slic/utils/reprate.py | 55 | 42 | 24% |
| slic/utils/richcfg.py | 21 | 11 | 48% |
| slic/utils/run\_later.py | 64 | 64 | 0% |
| slic/utils/screenshot.py | 30 | 21 | 30% |
| slic/utils/sendmail.py | 49 | 49 | 0% |
| slic/utils/sendsms.py | 5 | 5 | 0% |
| slic/utils/shortcut.py | 38 | 20 | 47% |
| slic/utils/snapshot.py | 6 | 3 | 50% |
| slic/utils/termtitle.py | 3 | 0 | 100% |
| slic/utils/tqdm\_mod.py | 28 | 18 | 36% |
| slic/utils/trinary.py | 4 | 2 | 50% |
| slic/utils/typecast.py | 19 | 19 | 0% |
| slic/utils/utils.py | 17 | 8 | 53% |
| slic/utils/xrange.py | 33 | 30 | 9% |
| **TOTAL** | **9984** | **7429** | **26%** |
markdown/pytest-report.json
+1 -1
View File
File diff suppressed because one or more lines are too long