added todo notes

This commit is contained in:
2024-08-02 12:18:56 +02:00
parent e9d187c712
commit 40c0a08d7c
2 changed files with 3 additions and 0 deletions

View File

@ -21,6 +21,7 @@ def calc_radial_integration(results, data, keep_pixels, pixel_mask_pf, center_ra
apply_threshold = results.get("apply_threshold", False)
#TODO: this is duplicated in calc_apply_threshold
if apply_threshold and all(k in results for k in ("threshold_min", "threshold_max")):
threshold_min = float(results["threshold_min"])
threshold_max = float(results["threshold_max"])

View File

@ -6,10 +6,12 @@ def calc_apply_threshold(results, data):
threshold_value_choice = results.get("threshold_value", "NaN")
threshold_value = 0 if threshold_value_choice == "0" else np.nan
#TODO: this is duplicated in calc_radial_integration
if apply_threshold and all(k in results for k in ("threshold_min", "threshold_max")):
threshold_min = float(results["threshold_min"])
threshold_max = float(results["threshold_max"])
data[data < threshold_min] = threshold_value
#TODO: skipping max is a guess, but not obvious/symmetric -- better to ensure the order min < max by switching them if needed
if threshold_max > threshold_min:
data[data > threshold_max] = threshold_value