commit bash-20080124 snapshot

CWRU/CWRU.chlog

@@ -15242,7 +15242,9 @@ lib/readline/{misc,readline,vi_mode,vi_keymap}.c
 builtins/read.def
 	- change timeout behavior when not reading from a tty device to save
 	  any partial input in the variable list, but still return failure.
-	  Fix inspired by Brian Craft <bcboy@thecraftstudio.com>
+	  This also causes variables specified as arguments to read to be
+	  set to null when there is no input available.  Fix inspired by
+	  Brian Craft <bcboy@thecraftstudio.com>
 
 				   1/21
 				   ----
@@ -15250,3 +15252,9 @@ builtins/fc.def
 	- change computation of last_hist to use remember_on_history instead
 	  of a hard-coded `1'.  This keeps fc -l -1 in PROMPT_COMMAND from
 	  looking too far back
+
+				   1/25
+				   ----
+lib/readline/complete.c
+	- fix fnwidth to use string[pos] instead of *string when testing the
+	  current character for a control character or rubout

CWRU/CWRU.chlog~

@@ -15242,4 +15242,13 @@ lib/readline/{misc,readline,vi_mode,vi_keymap}.c
 builtins/read.def
 	- change timeout behavior when not reading from a tty device to save
 	  any partial input in the variable list, but still return failure.
-	  Fix inspired by Brian Craft <bcboy@thecraftstudio.com>
+	  This also causes variables specified as arguments to read to be
+	  set to null when there is no input available.  Fix inspired by
+	  Brian Craft <bcboy@thecraftstudio.com>
+
+				   1/21
+				   ----
+builtins/fc.def
+	- change computation of last_hist to use remember_on_history instead
+	  of a hard-coded `1'.  This keeps fc -l -1 in PROMPT_COMMAND from
+	  looking too far back

lib/readline/complete.c

@@ -599,7 +599,7 @@ fnwidth (string)
   width = pos = 0;
   while (string[pos])
     {
-      if (CTRL_CHAR (*string) || *string == RUBOUT)
+      if (CTRL_CHAR (string[pos]) || string[pos] == RUBOUT)
 	{
 	  width += 2;
 	  pos++;

lib/readline/complete.c~

@@ -416,6 +416,7 @@ set_completion_defaults (what_to_do)
   rl_filename_quoting_desired = 1;
   rl_completion_type = what_to_do;
   rl_completion_suppress_append = rl_completion_suppress_quote = 0;
+  rl_completion_append_character = ' ';
 
   /* The completion entry function may optionally change this. */
   rl_completion_mark_symlink_dirs = _rl_complete_mark_symlink_dirs;
@@ -438,7 +439,7 @@ get_y_or_n (for_pager)
 	return (1);
       if (c == 'n' || c == 'N' || c == RUBOUT)
 	return (0);
-      if (c == ABORT_CHAR)
+      if (c == ABORT_CHAR || c < 0)
 	_rl_abort_internal ();
       if (for_pager && (c == NEWLINE || c == RETURN))
 	return (2);

tests/RUN-ONE-TEST

@@ -1,4 +1,4 @@
-BUILD_DIR=/usr/local/build/bash/bash-current
+BUILD_DIR=/usr/local/build/chet/bash/bash-current
 THIS_SH=$BUILD_DIR/bash
 PATH=$PATH:$BUILD_DIR
 

tests/read.right

@@ -34,12 +34,12 @@ a = xyz
 a = -xyz 123-
 a = abc
 1
-4
+
 1
-4
+
 ./read2.sub: line 13: read: -3: invalid timeout specification
 1
-4
+
 abcde
 ./read3.sub: line 4: read: -1: invalid number
 abc