Commit Graph

353 Commits

Author SHA1 Message Date
gsell 74db99c87e fixes for isses 52 to 55
- ignore multiple load commands (#52)
- do not print empty line if output to stderr is empty (#53)
- loading dependencies review (#54)
- rescan group in 'use' sub-command if newly created group is requested
2019-07-23 17:20:09 +02:00
gsell e09e89080b Merge branch '51-option-system-is-broken' into 'master'
Resolve "option --system is broken"

Closes #51

See merge request Pmodules/src!21
2019-07-19 17:18:45 +02:00
gsell 58359b837e review 'system' feature
- 'system' and 'OS' have different meaning now
  'system' defaults to a string derived from the Linux distribution
  (like rhel7) or on Mac to the macOS version (like macOS10.14)
- OS is equivalent to the output of 'uname -s'
- move dynamically created functions to new library libpbuild_dyn.bash
- do not set defaults in libpbuild.bash
- use the string returned by std::get_os_release() as system string
  if not passed as argument
-
2019-07-19 17:17:23 +02:00
gsell fb28efc834 function to get OS releases for Linux and macOS added to libstd 2019-07-19 17:01:15 +02:00
gsell eb488b2274 options for help command fixed 2019-07-11 17:55:42 +02:00
gsell 44da0d0391 Merge branch '50-bug-in-subcommand-load-text-which-should-be-displayed-on-the-terminal-must-be-redirected-to-stderr' into 'master'
Resolve "bug in subcommand load: text which should be displayed on the terminal must be redirected to stderr"

Closes #50

See merge request Pmodules/src!20
2019-07-10 17:36:27 +02:00
gsell 7e10814469 echo text to stderr in subcommand load 2019-07-10 17:35:56 +02:00
gsell b9ab9e7eba Merge branch '49-do-not-print-module-use-group-as-hint-for-hierarchical-groups' into 'master'
Resolve "do not print 'module use GROUP' as hint for hierarchical groups"

Closes #49

See merge request Pmodules/src!19
2019-06-17 17:39:33 +02:00
gsell 0bf87e3e66 do not output hierarchical groups as hint 2019-06-17 17:39:27 +02:00
gsell 6d4374951b Merge branch '48-output-group-in-load-hints' into 'master'
Resolve "output group in load hints"

Closes #48

See merge request Pmodules/src!18
2019-06-11 16:11:25 +02:00
gsell 04eea80f35 output group in load hints, if the user has to 'load' this group first 2019-06-11 16:11:15 +02:00
gsell bae1da6207 Merge branch '46-unpack-source-in-non-default-directory' into 'master'
Resolve "unpack source in non-default directory"

Closes #46

See merge request Pmodules/src!17
2019-05-29 17:25:58 +02:00
gsell 0cf32137b5 sources can be unpacked in user defined directories
- requires BASH >= 4 (associative arrays)
- pbuild::set_unpack_dir() added
- required changes to pbuild::prep() implemented
2019-05-29 17:25:57 +02:00
gsell 5997a64bef Merge branch '45-run-modbuild-with-bash-version-4' into 'master'
Resolve "run modbuild with bash version >= 4"

Closes #45

See merge request Pmodules/src!16
2019-05-29 17:16:53 +02:00
gsell c831cfbd36 call modbuild via /usr/bin/env in shebang, handle '--' argument 2019-05-29 17:14:48 +02:00
gsell 83fbc155dc Merge branch '43-in-modbuild-we-need-to-source-libpbuild-before-parsing-the-argument' into 'master'
Resolve "in modbuild we need to source libpbuild before parsing the arguments"

Closes #43

See merge request Pmodules/src!14
2019-05-27 17:53:22 +02:00
gsell 0b03915e39 source libpbuild before parsing the arguments 2019-05-27 17:50:14 +02:00
gsell 62ee41492f Merge branch '42-remove-rescan-of-groups' into 'master'
Resolve "remove rescan of groups"

Closes #42

See merge request Pmodules/src!13
2019-05-24 18:11:36 +02:00
gsell 59e343d8b9 modulefile.bash.in: rescanning of groups is not required, removed 2019-05-24 18:11:29 +02:00
gsell ead24beb9b Merge branch '41-cleanup' into 'master'
Resolve "cleanup"

Closes #41

See merge request Pmodules/src!12
2019-05-24 16:56:36 +02:00
gsell bbb122c86c modulecmd.bash.in: bugfix shell's != bash, cleanup
- we cannot write the output of the modulecmd using bash to stdout
  if another shell is requested
- rename 'g_shell' to 'Shell'
- export_env() uses now the global defined $Shell
2019-05-24 16:44:36 +02:00
gsell 597fad40b8 modulecmd.bash.in: fixes in sub-commands 'use' and 'unuse'
- adding/removing a group did not add/remove the directory to
  MODULEPATH
2019-05-24 16:02:34 +02:00
gsell a0c62dc92c modulecmd.bash.in: cleanup
- break long lines
- use common format for error messages
2019-05-24 15:42:33 +02:00
gsell c38aafdc52 modulecmd.bash.in: review/partially rewrite of sub-commands 'use', 'unuse' 2019-05-24 14:56:50 +02:00
gsell 2f454d3d07 modulecmd.bahs.in refactoring, better implementation of group handling
- scanning for groups and computation of their depth re-implemented
2019-05-24 13:03:51 +02:00
gsell 013af13633 modulecmd.bash.in: save_env() rewritten
- "typeset -p" is able to handle multiple variables!
2019-05-24 09:27:25 +02:00
gsell d4bc88c1dd modulecmd.bash.in: definition of PSI_LIBMODULES remove
- this environment variable was used in the past in modulefiles to load
  the required Tcl code for Pmodules
2019-05-24 09:02:45 +02:00
gsell bc951463a3 Merge branch '40-export-pmodules_env-after-content-changes-only' into 'master'
Resolve "export PMODULES_ENV after content changes only"

Closes #40

See merge request Pmodules/src!11
2019-05-24 08:52:36 +02:00
gsell ea5213d6ea trailing white-space removed in modulecmd.bash.in 2019-05-23 17:08:10 +02:00
gsell c417071956 cleanup and fixes in sub-commands 'use' and 'unuse' 2019-05-23 17:06:15 +02:00
gsell bc4cdbb25d export PMODULES_ENV only if content changed 2019-05-23 16:11:59 +02:00
gsell 8fae38b27d Merge branch '39-with-option-in-sub-command-search-should-accept-space-comma-or-colon-separated-list' into 'master'
Resolve "--with option in sub-command search should accept space, comma or colon separated list"

Closes #39

See merge request Pmodules/src!10
2019-05-22 11:21:58 +02:00
gsell 21beab1a78 --with option of sub-command now accepts lists of modules 2019-05-22 11:21:41 +02:00
gsell 54eeae4df3 Merge branch '38-implement-generic-print-help-function' into 'master'
Resolve "implement generic print help function"

Closes #38

See merge request Pmodules/src!9
2019-05-22 10:36:55 +02:00
gsell 6521632ac3 fixes in a comment 2019-05-22 10:35:20 +02:00
gsell 94bab4d302 several fixes in modulecmd.bash
- in sub-command 'load': print conflict message not just load failed
- in sub-command 'search': equal sign can now be used for options
  '--with' and '--release'
- sub-command options can now be specified on the LHS of the sub-command
2019-05-21 16:40:50 +02:00
gsell 54bf9c3d6c minor optimization in sub-command 'use', store usage text with key 'help 2019-05-19 20:55:45 +02:00
gsell 54d6aa5ff7 implementation of generic help function and better option handling 2019-05-17 19:12:52 +02:00
gsell 73740dbc68 Merge branch '37-switch-command-does-not-work' into 'master'
Resolve "switch command does not work"

Closes #37

See merge request Pmodules/src!8
2019-05-16 16:55:40 +02:00
gsell 0fe3048804 re-implementation of sub-command 'swap'
- sub-command 'swap' is now implemented via unload/load
- tmpfile variable in subcommand_load() cannot be read-only any more
2019-05-16 16:44:23 +02:00
gsell 41b6e2a26e cleanup in libmodules.tcl
- unused procedures removed
- implementation of the output of the .info file moved to modulecmd.bash
- swap is now implemented in modulecmd.bash as unload followed by a load
2019-05-16 16:42:05 +02:00
gsell e86930feee simplified module() function, do NOT loop over arguments
- all arguments are passed to modulemcd without being parsed/checked
2019-05-16 16:06:26 +02:00
gsell ab117e94fb better debug statements in libmodules.tcl 2019-05-16 14:40:17 +02:00
gsell df909d8640 Merge branch '36-sub-command-unload-must-eval-output-from-modulecmd-bin' into 'master'
Resolve "sub-command unload must eval output from modulecmd.bin"

Closes #36

See merge request Pmodules/src!7
2019-05-15 16:17:21 +02:00
gsell 05338d25b4 update of PMODULES_ENV fixed in subcommand 'unload'
Not all cached data has been updated while unloading a module amangst
other the list of used groups (UsedGroups)
2019-05-15 16:16:36 +02:00
gsell a1821a961b fixes 2019-05-15 15:01:48 +02:00
gsell 4f2558b524 Merge branch '35-path-must-be-initialized-in-profile-shell' into 'master'
Resolve "PATH must be initialized in profile.SHELL"

Closes #35

See merge request Pmodules/src!6
2019-05-15 10:41:41 +02:00
gsell 9d2974dd9c unset PMODULES_ENV during initialization 2019-05-14 14:54:46 +02:00
gsell 8b67fd45a3 cleanup double exports in profile.bash.in 2019-05-13 16:47:56 +02:00
gsell 6ef4dd3667 bugs in initialization of PATH fixed in modulecmd.bash.in
- prepend Pmodules bin directory to PATH
- export MANPATH
2019-05-13 16:47:17 +02:00