Files
Jungfraujoch/image_analysis/indexing/HarmonicContamination.cpp
T
leonarski_f a39fd29f77
Build Packages / XDS test (JFJoch plugin) (push) Successful in 11m4s
Build Packages / Unit tests (push) Skipped
Build Packages / build:windows:nocuda (push) Successful in 17m46s
Build Packages / build:windows:cuda (push) Successful in 20m20s
Build Packages / build:viewer-tgz:cpu (push) Successful in 15m56s
Build Packages / build:viewer-tgz:cuda (push) Successful in 17m57s
Build Packages / build:rugnux-tgz (x86_64) (push) Successful in 14m10s
Build Packages / build:rugnux:windows (push) Successful in 11m12s
Build Packages / build:rugnux:aarch64 (cross) (push) Successful in 7m14s
Build Packages / build:rpm (rocky8_nocuda) (push) Successful in 22m13s
Build Packages / build:rpm (rocky9_nocuda) (push) Successful in 19m17s
Build Packages / build:rpm (ubuntu2204_nocuda) (push) Successful in 21m21s
Build Packages / build:rpm (ubuntu2404_nocuda) (push) Successful in 17m26s
Build Packages / build:rpm (rocky8_sls9) (push) Successful in 23m56s
Build Packages / build:rpm (rocky9_sls9) (push) Successful in 20m48s
Build Packages / build:rpm (rocky8) (push) Successful in 23m43s
Build Packages / build:rpm (rocky9) (push) Successful in 20m38s
Build Packages / build:rpm (ubuntu2204) (push) Successful in 24m57s
Build Packages / build:rpm (ubuntu2404) (push) Successful in 20m58s
Build Packages / XDS test (durin plugin) (push) Successful in 10m43s
Build Packages / Generate python client (push) Successful in 47s
Build Packages / Build documentation (push) Successful in 1m5s
Build Packages / Create release (push) Skipped
Build Packages / XDS test (neggia plugin) (push) Successful in 8m57s
Build Packages / DIALS test (push) Successful in 18m40s
v1.0.0-rc.167 (#77)
* `rugnux --model` reports CC(model, data) - the correlation of the merged intensities with the placed, scaled model - by resolution shell, on the same shells as CC1/2, with the reflection count and a significance for each.
* `rugnux --model` fits the model's scale, anisotropic B and bulk-solvent parameters on the working reflections only, so the R-free it reports is measured against a model no free reflection helped scale.
* The bulk-solvent parameters of `rugnux --model` are searched over their physically meaningful range instead of being fitted without bounds, so a model is never scaled with a solvent term that has silently switched itself off.
* The rigid-body placement of `rugnux --model` uses the same bounded bulk solvent as the reported fit, so a model is no longer placed against a target carrying a solvent term with no physical meaning.
* `rugnux --model` puts the model into the data's own description of the lattice before placing it, so a model whose cell is written on other axes - I-centred where the run indexed C-centred, a different unique axis, a permuted orthorhombic cell - is placed rather than scored where it was read; `MODEL_CHANGE_OF_BASIS=` and `MODEL_SETTING_AS_READ=` report it when it happens.
* The rugnux results report opens with a summary - `VERDICT=` (`OK`, `WARNINGS`, `UNUSABLE`, `FAILED`), `VERDICT_TEXT=`, `PATHOLOGY_FLAGS=` with one closed-vocabulary code per condition that warned, and the `WARNING:` lines, which used to close the file - and the sections after it are renumbered 1-5 with no gaps.
* `rugnux --developer` writes the full results report - the pipeline-internal keys and the long explanations the default report now leaves out - and `--finalist-ledger` adds the evidence for every space group the search considered, not only the one it adopted.
* The results report warns when the merged data carry no usable signal and when too little of reciprocal space was measured inside the fitted resolution, and omits `FITTED_RESOLUTION` where the CC1/2 curve it is fitted on never falls off.
* rugnux detects translational pseudo-symmetry and reports it under the `PSEUDO_TRANSLATION` flag as `TNCS_DETECTED=` and the `TNCS_*` keys - a translation the merged data are exactly invariant under is reported as `UNDECLARED_LATTICE_TRANSLATION=` under `LATTICE_TRANSLATION` instead - and a detected pseudo-translation can no longer buy a false screw axis in the space-group search or hide a twin from the L-test (`L_TEST_VS_TNCS=`).
* The space-group search determines glide planes from zonal systematic absences, so a non-Sohncke space group such as P 2_1/c or Pbca is named where the run previously stopped at its Sohncke subgroup; `SOHNCKE_SPACE_GROUP=` carries the best Sohncke group beside it on every run that searched, and a centre of symmetry is never claimed.
* Where the cell metric carries more rotational symmetry than the Bravais class the indexer named, the extra rotations are put to the intensities and the space-group search is asked again on the metric's own cell - adopted only where the intensities confirm the higher symmetry - so a lattice that is nearly but not exactly hexagonal, or whose reduction landed in a sub-cell, still reaches its true point group.
* Systematic-absence calls rest on the evidence rather than on counts: a screw axis whose absent class the data show extinct is no longer refused because a handful of reflections in it read as present, and `SPACE_GROUP_ALTERNATIVES=` no longer drops a candidate that differs only on a zone the sweep never measured.
* A reference correlation measured on too few reflections is refused instead of scored zero, so a run given a reference MTZ is no longer reindexed on an operator that mapped almost everything outside the reference's coverage.
* A frame counts as indexed from 6 spots on its lattice rather than 9, so a weakly diffracting crystal whose frames cannot carry 9 is no longer refused the lattice it fits; `--min-indexed-spots` overrides it.
* `-C` accepts a known cell in any equivalent description - conventional or primitive, centred or not - instead of only the reduced primitive form, so a centred cell given the way it is published no longer makes the run report that it found no lattice.
* Each reflection is corrected for the sensor's quantum efficiency at the angle it meets the detector (attenuation lengths from the NIST tables, which also fixes the spot-width parallax term on CdTe) and for the attenuation of the flight path between the sample and its pixel; `--flight-path air|helium|vacuum` declares the medium - default air, since no file states it - and the report says what was assumed and what it was worth. The unmerged MTZ records the factors in new `QE` and `FLIGHT` columns beside `LP`, so raw counts are `I / LP * QE * FLIGHT`, and `_process.h5` in new optional `qe` and `flight` datasets.
* Rotation geometry post-refinement fits the crystal and the detector at once, against the observed spot positions and the observed rocking angles together, so the refined distance depends far less on how wrong the file's distance was.
* A coarsely sliced sweep integrates correctly: partials are joined into one rocking event by angle rather than by frame count, so two crossings of the Ewald sphere are no longer summed into one full, and at 0.5 degrees per image or coarser the per-frame geometry refinement accepts a spot whose miss the exposure's own rotation accounts for.
* `rugnux --mode scale` reports the detector tilt and direct beam of the geometry it re-scaled at, instead of zeros that read as a flat detector, and no longer warns that no image was indexed on a run whose lattice came from its input file.
* Every rotation run that determined a space group and merged reports what the mounting cost: `SPINDLE_LOST_UNIQUE_FRACTION=` is the fraction (0-1) of unique reflections the mounting made unmeasurable under the measured point group, also written to the master as `/entry/MX/spindleLostUniqueFraction` and what the mounting warning fires on; `SPINDLE_SYMMETRY_AXIS_ANGLE_DEG=` / `SPINDLE_SYMMETRY_AXIS_ORDER=` describe the mounting in the `--developer` report.
* Stills and grid scans carry a per-image `spindle_blind_fraction` - how much of a rotation sweep's blind cone this orientation would make unrecoverable, 0.5 and above calling for a second orientation - through the CBOR stream, HDF5 (`/entry/MX/spindleBlindFraction`), the plot and scan-result APIs, and the viewer and frontend plots; an absent value means the frame could not be assessed and is not a 0.
* The results report's `REPORT_VERSION` is 7.

Reviewed-on: #77
Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>
2026-09-09 07:25:13 +02:00

154 lines
6.6 KiB
C++

// SPDX-FileCopyrightText: 2026 Filip Leonarski, Paul Scherrer Institute <filip.leonarski@psi.ch>
// SPDX-License-Identifier: GPL-3.0-only
#include <algorithm>
#include <array>
#include <cmath>
#include "HarmonicContamination.h"
namespace {
// A frame's orientation as the map from a spot's reciprocal vector to its Miller indices, fitted
// by least squares on the spots the indexer took. Read from the spots rather than from the
// indexer's own matrix so that whatever per-frame refinement it applied is already in it, and so
// that no convention has to be shared with it.
struct Orientation {
std::array<Coord, 3> row; // hkl = {row[0]*q, row[1]*q, row[2]*q}
};
bool FitOrientation(const std::vector<SpotToSave> &spots, const DiffractionGeometry &geometry,
Orientation &fit) {
double n[3][3] = {}; // sum q q^T
double rhs[3][3] = {}; // sum q h, one column per Miller index
size_t used = 0;
for (const auto &s : spots) {
// The first lattice only: on a multi-lattice frame the other lattices' Miller indices
// belong to a different orientation and fitting one map through both gives neither.
if (!s.indexed || s.lattice > 0)
continue;
const Coord q = s.ReciprocalCoord(geometry);
const double h[3] = {static_cast<double>(s.h), static_cast<double>(s.k),
static_cast<double>(s.l)};
for (int i = 0; i < 3; i++) {
for (int j = 0; j < 3; j++)
n[i][j] += static_cast<double>(q[i]) * q[j];
for (int j = 0; j < 3; j++)
rhs[i][j] += static_cast<double>(q[i]) * h[j];
}
used++;
}
if (used < HARMONIC_MIN_INDEXED_SPOTS)
return false;
// Invert the 3x3 normal matrix by cofactors. It is singular when the frame's spots span fewer
// than three directions in reciprocal space, which no real frame does but a degenerate one can.
double c[3][3];
c[0][0] = n[1][1] * n[2][2] - n[1][2] * n[2][1];
c[0][1] = n[0][2] * n[2][1] - n[0][1] * n[2][2];
c[0][2] = n[0][1] * n[1][2] - n[0][2] * n[1][1];
c[1][0] = n[1][2] * n[2][0] - n[1][0] * n[2][2];
c[1][1] = n[0][0] * n[2][2] - n[0][2] * n[2][0];
c[1][2] = n[0][2] * n[1][0] - n[0][0] * n[1][2];
c[2][0] = n[1][0] * n[2][1] - n[1][1] * n[2][0];
c[2][1] = n[0][1] * n[2][0] - n[0][0] * n[2][1];
c[2][2] = n[0][0] * n[1][1] - n[0][1] * n[1][0];
const double det = n[0][0] * c[0][0] + n[0][1] * c[1][0] + n[0][2] * c[2][0];
const double scale = n[0][0] + n[1][1] + n[2][2];
if (!(std::fabs(det) > 1e-12 * scale * scale * scale))
return false;
for (int j = 0; j < 3; j++) {
float v[3];
for (int i = 0; i < 3; i++) {
double sum = 0;
for (int k = 0; k < 3; k++)
sum += c[i][k] * rhs[k][j];
v[i] = static_cast<float>(sum / det);
}
fit.row[j] = Coord(v[0], v[1], v[2]);
}
return true;
}
// How far the scaled spot is from the nearest lattice point, as the largest of the three Miller
// indices' distances to an integer.
float IndexResidual(const Orientation &fit, const Coord &q, float scale) {
float worst = 0;
for (int j = 0; j < 3; j++) {
const float f = scale * (fit.row[j] * q);
worst = std::max(worst, std::fabs(f - std::round(f)));
}
return worst;
}
}
void HarmonicEvidence::Add(const HarmonicEvidence &other) {
frames += other.frames;
tested += other.tested;
hits += other.hits;
null_hits += other.null_hits;
hit_d_sum_A += other.hit_d_sum_A;
indexed_d_sum_A += other.indexed_d_sum_A;
indexed += other.indexed;
}
void AddHarmonicEvidence(const std::vector<SpotToSave> &spots, const DiffractionGeometry &geometry,
HarmonicEvidence &evidence) {
Orientation fit;
if (!FitOrientation(spots, geometry, fit))
return;
evidence.frames++;
for (const auto &s : spots) {
const Coord q = s.ReciprocalCoord(geometry);
const float d_A = 1.0f / std::max(q.Length(), 1e-6f);
if (s.indexed) {
evidence.indexed++;
evidence.indexed_d_sum_A += d_A;
continue;
}
if (IndexResidual(fit, q, 1.0f) < HARMONIC_NEAR_MISS_TOLERANCE)
continue;
evidence.tested++;
if (IndexResidual(fit, q, HARMONIC_SCALE) < HARMONIC_INDEX_TOLERANCE) {
evidence.hits++;
evidence.hit_d_sum_A += d_A;
}
if (IndexResidual(fit, q, HARMONIC_SCALE_NULL) < HARMONIC_INDEX_TOLERANCE)
evidence.null_hits++;
}
}
HarmonicContaminationResult HarmonicFromEvidence(const HarmonicEvidence &evidence) {
HarmonicContaminationResult result;
result.frames = evidence.frames;
result.tested = evidence.tested;
result.hits = evidence.hits;
// Frames enough for the question to have been asked of this crystal at all. A run that indexed
// this much and found nothing left to test has answered it: there is no second population.
if (evidence.frames < 20 || evidence.indexed < 1000)
return result;
result.measurable = true;
if (evidence.tested > 0) {
result.fraction = 100.0f * static_cast<float>(evidence.hits)
/ static_cast<float>(evidence.tested);
result.null_fraction = 100.0f * static_cast<float>(evidence.null_hits)
/ static_cast<float>(evidence.tested);
}
if (evidence.hits > 0)
result.mean_d_A = static_cast<float>(evidence.hit_d_sum_A / static_cast<double>(evidence.hits));
if (evidence.indexed > 0)
result.mean_indexed_d_A = static_cast<float>(evidence.indexed_d_sum_A
/ static_cast<double>(evidence.indexed));
// Ten per cent of the tested spots, five times whatever the same test finds at a scale that is
// not a harmonic, and enough spots for the rate to be a rate. Measured over datasets with no
// reported contamination the harmonic rate runs at or below the null's own per cent or so, and
// on a set whose depositors reported a harmonic it is ninety.
result.detected = evidence.hits >= 200
&& result.fraction >= 10.0f
&& result.fraction >= 5.0f * std::max(result.null_fraction, 0.5f);
return result;
}