leonarski_fandClaude Opus 5
501ce1ba3d
The status bar, the resolution readout and the magnifier were all regenerated on every single mouse motion event. Each regeneration repaints, and on a remote X session a repaint uploads the whole window regardless of how little changed, so the pointer merely crossing the image saturates the link: measured with a counting relay in front of the X server, 50 motions over the image cost 273 MB, and a build with the hover work removed cost 18 KB. Rate-limit it. Two details matter: - The limit is applied inline, not from a timer. Running the update inside the mouse event keeps its damage in the same repaint as anything else that event triggers (a pan). A first attempt deferred the work to a timer instead, which split one repaint into two and made panning measurably worse. - The catch-up that reports the final position is debounced, not queued per skipped motion, so it fires once after the pointer stops rather than repeatedly mid-gesture. mouseHover() now takes the scene position and modifiers instead of the event, which also removes the identical mapToScene() from all four implementations. Hover traffic over 3 repeats: 173 MB mean -> 140 MB, and the run-to-run spread drops from +-14% to +-2%. The harness tops out near 30 motions/s, barely above the 15 Hz limit; a real mouse reports far faster, where the cap does more. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
115 lines
3.7 KiB
C++
115 lines
3.7 KiB
C++
// SPDX-FileCopyrightText: 2025 Filip Leonarski, Paul Scherrer Institute <filip.leonarski@psi.ch>
|
|
// SPDX-License-Identifier: GPL-3.0-only
|
|
|
|
#include "JFJochAzIntImage.h"
|
|
#include <QVBoxLayout>
|
|
|
|
#include "../../common/JFJochException.h"
|
|
#include "../../common/JFJochMath.h"
|
|
|
|
JFJochAzIntImage::JFJochAzIntImage(QWidget *parent)
|
|
: JFJochImage(parent) {
|
|
}
|
|
|
|
void JFJochAzIntImage::Clear() {
|
|
W = 0;
|
|
H = 0;
|
|
image_fp.clear();
|
|
if (scene())
|
|
scene()->clear();
|
|
resetScenePointers();
|
|
}
|
|
|
|
void JFJochAzIntImage::imageLoaded(std::shared_ptr<const JFJochReaderImage> in_image) {
|
|
if (!in_image) {
|
|
Clear();
|
|
CalcROI();
|
|
return;
|
|
}
|
|
|
|
const auto &profile = in_image->ImageData().az_int_profile;
|
|
const auto &ds = in_image->Dataset();
|
|
int az_bins = ds.azimuthal_bins;
|
|
int q_bins = ds.q_bins;
|
|
|
|
if (az_bins > 0 && q_bins > 0 && profile.size() == static_cast<size_t>(az_bins * q_bins)
|
|
&& ds.az_int_bin_to_phi.size() == profile.size() && ds.az_int_bin_to_q.size() == profile.size()) {
|
|
|
|
image = in_image;
|
|
float local_min = range_min, local_max = range_max;
|
|
if (auto_range) {
|
|
local_min = std::numeric_limits<float>::infinity();
|
|
local_max = -std::numeric_limits<float>::infinity();
|
|
for (float v : profile) {
|
|
if (std::isfinite(v)) {
|
|
if (v < local_min) local_min = v;
|
|
if (v > local_max) local_max = v;
|
|
}
|
|
}
|
|
if (!std::isfinite(local_min) || !std::isfinite(local_max) || local_max <= local_min) {
|
|
Clear();
|
|
return;
|
|
}
|
|
} else {
|
|
if (!(std::isfinite(local_min) && std::isfinite(local_max) && local_max > local_min)) {
|
|
Clear();
|
|
return;
|
|
}
|
|
}
|
|
|
|
// Update base class members
|
|
W = q_bins;
|
|
H = az_bins;
|
|
image_fp = profile;
|
|
|
|
// Update foreground/background for color mapping
|
|
background = local_min;
|
|
foreground = local_max;
|
|
emit backgroundChanged(background);
|
|
emit foregroundChanged(foreground);
|
|
|
|
// Render the image and redraw using base class functionality
|
|
RenderImage();
|
|
Redraw();
|
|
CalcROI();
|
|
} else {
|
|
Clear();
|
|
}
|
|
}
|
|
|
|
void JFJochAzIntImage::mouseHover(const QPointF &scenePos, Qt::KeyboardModifiers) {
|
|
if (!scene() || !image || W == 0 || H == 0) return;
|
|
|
|
int x = static_cast<int>(scenePos.x());
|
|
int y = static_cast<int>(scenePos.y());
|
|
|
|
if (x >= 0 && x < static_cast<int>(W) && y >= 0 && y < static_cast<int>(H)) {
|
|
size_t idx = y * W + x;
|
|
|
|
QString statusText = QString("Q: %1 Å^-1 phi: %2° value: %3")
|
|
.arg(QString::number(image->Dataset().az_int_bin_to_q[idx], 'f', 3))
|
|
.arg(QString::number(image->Dataset().az_int_bin_to_phi[idx], 'f', 3))
|
|
.arg(QString::number(image_fp[idx], 'f', 3));
|
|
|
|
emit writeStatusBar(statusText, 0);
|
|
}
|
|
}
|
|
|
|
void JFJochAzIntImage::mouseDoubleClickEvent(QMouseEvent *event) {
|
|
if (!scene() || !image || W == 0 || H == 0) return;
|
|
|
|
QPointF scenePos = mapToScene(event->pos());
|
|
int x = static_cast<int>(scenePos.x());
|
|
int y = static_cast<int>(scenePos.y());
|
|
|
|
if (x >= 0 && x < static_cast<int>(W) && y >= 0 && y < static_cast<int>(H)) {
|
|
size_t idx = y * W + x;
|
|
|
|
float q = image->Dataset().az_int_bin_to_q[idx];
|
|
float phi = image->Dataset().az_int_bin_to_phi[idx];
|
|
|
|
auto geom = image->Dataset().experiment.GetDiffractionGeometry();
|
|
auto coord = geom.ResPhiToPxl(2 * PI / q, phi / 180.0 * PI);
|
|
emit zoomOnBin(QPointF(coord.first, coord.second));
|
|
}
|
|
} |