Files
leonarski_f 4809c1622c
Build Packages / build:portable:linux-x86_64:nocuda (push) Successful in 16m43s
Build Packages / build:jfjoch:ubuntu2404:nocuda (push) Successful in 28m46s
Build Packages / build:jfjoch:rocky8:cuda-sls9 (push) Successful in 32m5s
Build Packages / build:jfjoch:rocky9:cuda (push) Successful in 39m44s
Build Packages / build:portable:macos-arm64:nocuda (push) Successful in 5m7s
Build Packages / Create release (push) Successful in 8s
Build Packages / Build documentation (push) Successful in 49s
Build Packages / build:portable:linux-x86_64:cuda (push) Successful in 22m30s
Build Packages / build:jfjoch:rocky8:nocuda (push) Successful in 31m54s
Build Packages / build:rugnux:linux-aarch64:cuda (push) Successful in 11m29s
Build Packages / build:portable:windows-x86_64:nocuda (push) Successful in 23m51s
Build Packages / build:jfjoch:ubuntu2204:nocuda (push) Successful in 26m7s
Build Packages / build:jfjoch:ubuntu2204:cuda (push) Successful in 29m38s
Build Packages / build:portable:windows-x86_64:cuda (push) Successful in 28m6s
Build Packages / HDF5 consumer tests (DIALS, XDS) (push) Successful in 29m44s
Build Packages / build:jfjoch:rocky9:nocuda (push) Successful in 33m22s
Build Packages / Generate python client (push) Successful in 47s
Build Packages / build:jfjoch:rocky9:cuda-sls9 (push) Successful in 34m6s
Build Packages / Unit tests (push) Successful in 1h2m47s
Build Packages / build:jfjoch:rocky8:cuda (push) Successful in 35m59s
Build Packages / build:jfjoch:ubuntu2404:cuda (push) Successful in 34m8s
Build Packages / Validation Battery (push) Successful in 38m31s
v1.0.0-rc.187 (#98)
* Rugnux: Refinement several times faster, one protocol on the CPU and the GPU, parts of it on the Apple GPU; its random draws are the same on every platform.
* Rugnux: Refinement follows common practice: the free set decides only the restraint weights and the displacement model (isotropic, TLS or anisotropic, by Hamilton's test), everything else is decided on the working set; lower R-free for placed and predicted models.
* Rugnux: Restraint dictionaries via `--restraints` (or among the inputs) and more built-in ligands; a model whose space group is a subgroup of the data's is refined in its own group; reflections plus a model select `--mode refine` on their own.
* Rugnux: `-C` fixes the crystal system on the axes as typed; `-S` alone fixes the space group only, the cell is still found and reduced; a space group or cell stored in the input file is ignored, with a line in the log.
* Rugnux: More reliable multi-sweep merging; `--mode scale` merges several stills runs as one; `_plot.txt` and the report name each input; a second crystal form is reported for stills given a cell.
* jfjoch_broker (experimental): Live Rugnux on FPGA detectors (JUNGFRAU) takes the same path as a DECTRIS stream, rotation and serial alike, model step included, with analysis threads per GPU; frames waiting for the analysis can be viewed; no host stage drops a frame - a source faster than the analysis is held at the card.
* jfjoch_broker: Summation of more than 256 frames per image is split between the card and the host (`summation_mode` is then `hybrid`), and live Rugnux runs on such collections; pedestal runs take a receiver of their own.
* jfjoch_broker (experimental): `stills_downsample` analyses 1 of every N serial images (chosen by a hash; the first 2000 all; the others written without analysis; reset to 1 by `/initialize`); `max_spot_count` left out means 250 for per-image indexing and up to 1000 for live stills; the live status gives the merge before the model work, the fitted resolution and the anomalous peak height of each unexplained blob.
* jfjoch_broker: Without a `pcie` entry the broker runs on a mock of the card instead of the HLS simulation; its spot, ROI and azimuthal results are zero then.
* Web frontend: Redesigned Rugnux live page; Vite 8, TypeScript 6, Mol* 5.13 and dependency security updates.
* Tools: `jfjoch_fpga_stills_test` measures live stills on the cards with a stored dataset; `jfjoch_fpga_test` loses the HLS-simulation option.
* Other: FFTW no longer fetched or linked (the CPU FFT indexer keeps the name `FFTW`); PCIe driver now GPL-2.0-or-later and third-party notices complete; several crash fixes.

Reviewed-on: #98
Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>
2026-11-19 20:49:28 +01:00

120 lines
5.3 KiB
C++

// SPDX-FileCopyrightText: 2025 Filip Leonarski, Paul Scherrer Institute <filip.leonarski@psi.ch>
// SPDX-License-Identifier: GPL-3.0-only
#include "FFTIndexerCPU.h"
#include <cmath>
#include <algorithm>
#include <stdexcept>
#include <cassert>
#include <vector>
#include "../../common/CpuFFT.h"
#include "../../common/ParallelFor.h"
static inline double dot_abs(const Coord& a, const Coord& b) {
return std::fabs(a.x * b.x + a.y * b.y + a.z * b.z);
}
FFTIndexerCPU::FFTIndexerCPU(const IndexingSettings& settings)
: FFTIndexer(settings) {
// Allocate host buffers
h_input_fft.resize(input_size, 0.0);
h_output_fft.resize(output_size);
// Validate allocations vs. expected sizes
if (h_input_fft.size() != input_size)
throw std::runtime_error("FFTIndexerCPU: input buffer size mismatch");
if (h_output_fft.size() != output_size)
throw std::runtime_error("FFTIndexerCPU: output buffer size mismatch");
}
void FFTIndexerCPU::ExecuteFFT(const std::vector<Coord> &coord, size_t nspots) {
// Build histograms: one per direction
const int H = static_cast<int>(histogram_size);
const int D = nDirections;
const int out_len = (H / 2) + 1;
std::fill(h_input_fft.begin(), h_input_fft.end(), 0.0);
// Every direction has a histogram and a spectrum of its own, so the directions are split over the
// refinement threads; each one is still filled and scanned in the same order.
const size_t nthreads = std::max(1u, refine_threads);
ParallelChunks(D, nthreads, [&](int d0, int d1) {
for (int d = d0; d < d1; ++d) {
float* hist = h_input_fft.data() + static_cast<size_t>(d) * H;
for (size_t i = 0; i < nspots; i++) {
const auto& r = coord[i];
double dot = dot_abs(direction_vectors[d], r);
long long bin = static_cast<long long>(dot / histogram_spacing);
if (bin >= 0 && bin < H) {
hist[bin] += 1.0;
}
}
}
});
// One real transform per direction, all in one call.
cpu_fft::R2C({static_cast<size_t>(D), static_cast<size_t>(H)}, {1}, h_input_fft.data(), h_output_fft.data());
// Post-process: pick the peak past min_length_A by PROMINENCE above a local background.
// The projected histogram has a broad low-frequency ENVELOPE (spots cluster near the
// origin) whose magnitude can exceed the true lattice peaks; a plain argmax|spec| then
// returns a short envelope vector (~10A) on weak/pink-beam frames and the real axes are
// lost. Subtracting a running-mean background of half-width BG_HALF bins removes that
// smooth envelope (it cancels to ~0) while sharp lattice peaks - fundamentals AND
// harmonics - keep their height. The prominence is also reported as the magnitude so
// FilterFFTResults ranks directions by real-peak strength, not by envelope.
const double len_coeff = 2.0 * static_cast<double>(max_length_A) / static_cast<double>(H);
// Background half-window ~15 A (in length, so it is independent of the histogram sizing);
// wide enough to span the envelope yet narrow enough not to smooth real peaks. Validated
// optimum on serial-still jet data (de-novo indexing improved markedly vs FFBIDX); a second dataset unchanged.
constexpr double BG_HALF_WIDTH_A = 15.0;
const int bg_half = std::max(1, static_cast<int>(std::lround(BG_HALF_WIDTH_A / len_coeff)));
ParallelChunks(D, nthreads, [&](int d0, int d1) {
std::vector<double> mag(out_len), pref(out_len + 1);
for (int d = d0; d < d1; ++d) {
const auto* spec = h_output_fft.data() + static_cast<size_t>(d) * out_len;
pref[0] = 0.0;
for (int j = 0; j < out_len; ++j) {
mag[j] = std::hypot(spec[j].real(), spec[j].imag());
pref[j + 1] = pref[j] + mag[j];
}
double best_prom = 0.0;
double best_len = -1.0;
for (int j = 0; j < out_len; ++j) {
double len = len_coeff * static_cast<double>(j);
if (len <= static_cast<double>(min_length_A)) continue;
// Slide the background window inward at the ends rather than truncating it. A peak within
// bg_half bins of either end - which is where the LONGEST cells sit, the last usable bin
// being max_length_A itself - otherwise gets its background from a one-sided window, and
// the prominence it is judged on is biased by however much the spectrum slopes there.
int lo = j - bg_half, hi = j + bg_half + 1;
if (lo < 0) { hi = std::min(out_len, hi - lo); lo = 0; }
if (hi > out_len) { lo = std::max(0, lo - (hi - out_len)); hi = out_len; }
const double background = (pref[hi] - pref[lo]) / static_cast<double>(hi - lo);
const double prominence = mag[j] - background;
if (prominence > best_prom) {
best_prom = prominence;
best_len = len;
}
}
result_fft[d] = FFTResult{
.magnitude = static_cast<float>(best_prom),
.direction = d,
.length = static_cast<float>(best_len)
};
}
});
}