2 Commits

Include renames

Author	SHA1	Message	Date
jungfrauandClaude Opus 5	a97d763098	Do not assume a DECTRIS detector's bit depths before asking it ... DetectorSetup gave a DECTRIS detector bit_depth_image = 16 and bit_depth_readout = 16 the moment it was constructed. Both mean "the detector told us", and at construction nothing has asked it: the SIMPLON client learns them at configure time, and the lite receiver reads them off the start message. Until then they were an assumption wearing the clothes of a measurement. The assumption was load-bearing in the wrong direction. GetByteDepthImage() gives the detector's image depth absolute priority - correctly, since the DECTRIS path forwards images verbatim and the depth has to be the one the pixels actually have - so a value that was always set meant everything below it was unreachable on DECTRIS: * image_format_settings.bit_depth_image, which the API documents as "bit depth of resulting image ... if not provided value is adjusted automatically", was silently discarded. It works on JUNGFRAU, where the detector's value is not set, and did nothing at all on an EIGER. No error, no warning. * so was the promotion to four bytes that summation needs. Both are now unset for DECTRIS. JUNGFRAU keeps its readout depth of 16, because there that is a property of the hardware rather than something configured. Where nothing supplies a depth the answer does not change: GetByteDepthImage() falls through to the same two bytes it produced before, and the fallback no longer throws merely because the readout depth is not known yet - GetBitDepthReadoutIfKnown() reports it as unknown instead of inventing one. The start message carries it as an optional already, and the receiver already guards on that, so "not known" travels end to end rather than being papered over. GetBitDepthReadout() still throws for the callers that genuinely require a value; all of them are on the FPGA path, where it is always set. Also fixes the jfjoch_test build, which the previous commit broke: SpotExtractorGPU's Extract() takes a PixelView now, and the parity test still passed a raw pointer. That should have been caught before it was pushed. Tests: DetectorSetup (with a new case pinning the contract this restores), plus DiffractionExperiment, CBOR, writer, HDF5, preprocessing, azimuthal integration and the GPU spot-finding / integration / decoder suites. rugnux unchanged end to end. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-18 17:48:19 -04:00
leonarski_f	538f3504d3	v1.0.0.rc-161 (#71) ... This is an UNSTABLE release. It includes many experimental features, as well as many AI generated fixes. We recommend using rc.152 for production use. * **rugnux: significantly better quality of results, and faster.** A large rework of integration, scaling, merging, geometry refinement and space-group determination, together with measurements the program previously made no attempt at - the direct beam before indexing, the beam stop, the goniometer rotation scale, and the stretches of a sweep the crystal did not deliver. A rotation dataset typically gains observations at better <I/sigma> and R_meas, and every `mx` and `scale` run writes a `<prefix>_report.txt` results report modelled on XDS's `CORRECT.LP`. Many defaults moved with it: spot detection is self-calibrating, beam-stop detection and rotation geometry post-refinement are on, resolution limits default to as far as the detector reaches, and ice-ring handling engages only where the crystal is measured to have ice. * **jfjoch_viewer:** the beam-stop shadow, the detector calibration and the beam-centre measurement are reachable from "Analyze dataset"; the settings panel reports how the sample moved and how polarized the beam was; image rendering and interaction are faster. * **Performance:** bitshuffle+LZ4 images are decoded on the GPU rather than on the host, with the bitshuffle inverse fused into preprocessing so the decompressed frame is never held in device memory. * **Broker, writer, packaging and build:** image-slot lifetime and locking fixes, per-image datasets sized by the images actually written, the Debian/Ubuntu broker package renamed to `jfjoch`, and `image_analysis` compiling under MSVC again. **Breaking change to the rugnux command line:** * `--azint-only` and `--scale` are **removed**, replaced by `--mode azint` and `--mode scale`; the full pipeline is `--mode mx` and remains the default. A script passing the old flags now fails with the list of valid modes rather than silently running the wrong one. * `-t`/`--stride` is **refused on rotation data**: skipping frames cuts every reflection's rocking curve, so the combined fulls and their partiality would be measured over frames the sweep never recorded. Select a contiguous range with `-s`/`-e` instead. `--mode azint` and `--force-still` still take a stride. **Breaking changes to OpenAPI** - regenerate the client (`jfjoch-client` 1.0.0-rc.161, `frontend/src/client`) or read the affected fields as optional: * `image_scale_b` is removed from the `plot_type` enum, so a client requesting that plot now gets an error rather than a curve. * `azim_int_settings.high_q_recipA`, `spot_finding_settings.high_resolution_limit` and `spot_finding_settings.low_resolution_limit` are no longer `required`. All three mean "no limit at that end" when unset and are omitted from the response instead of carrying a placeholder value, which raises in a client generated from an rc.160-or-earlier spec. A value of 0 is still accepted and means the same thing. **Breaking changes to the stored formats** - a consumer reading these fields must treat them as optional: * The per-image image-scale B factor is no longer computed, so `/entry/MX/imageScaleBFactor` is absent from newly written HDF5 files and the corresponding key is absent from the CBOR DataMessage and END blocks. Files written by rc.160 and earlier still contain it and still open; nothing in the pipeline reads it any more. * `_reflns.jfjoch_diffrn_ISa` now carries the whole-range `1/sqrt(a*b)` that XDS's ISa denotes, and the error-model `a` and `b` are reported in XDS's convention; the strong-reflection asymptote moves to `_reflns.jfjoch_diffrn_ISa_asymptotic`. **A file written by an earlier version carries the asymptote under the plain `ISa` name.** Reviewed-on: #71 Co-authored-by: Filip Leonarski <filip.leonarski@psi.ch>	2026-08-13 17:03:10 +02:00