rugnux --model: say why validation did not run when the data carry no resolution
Build Packages / build:windows:nocuda (push) Failing after 13m34s
Build Packages / build:windows:cuda (push) Failing after 15m29s
Build Packages / build:rugnux:windows (push) Failing after 16m25s
Build Packages / build:rugnux:aarch64 (cross) (push) Successful in 9m28s
Build Packages / build:viewer-tgz:cpu (push) Successful in 14m49s
Build Packages / build:rugnux-tgz (x86_64) (push) Successful in 14m9s
Build Packages / build:viewer-tgz:cuda (push) Successful in 16m4s
Build Packages / build:rpm (rocky8_nocuda) (push) Successful in 17m12s
Build Packages / build:rpm (rocky9_nocuda) (push) Successful in 15m7s
Build Packages / build:rpm (ubuntu2204_nocuda) (push) Successful in 19m39s
Build Packages / build:rpm (ubuntu2404_nocuda) (push) Successful in 17m18s
Build Packages / build:rpm (rocky8_sls9) (push) Successful in 21m56s
Build Packages / build:rpm (rocky9_sls9) (push) Successful in 18m8s
Build Packages / XDS test (durin plugin) (push) Canceled after 0s
Build Packages / XDS test (JFJoch plugin) (push) Canceled after 0s
Build Packages / XDS test (neggia plugin) (push) Canceled after 0s
Build Packages / Generate python client (push) Canceled after 0s
Build Packages / Build documentation (push) Canceled after 0s
Build Packages / build:rpm (ubuntu2404) (push) Canceled after 7m35s
Build Packages / Create release (push) Canceled after 0s
Build Packages / build:rpm (rocky8) (push) Canceled after 18m19s
Build Packages / Unit tests (push) Canceled after 46m52s
Build Packages / build:rpm (ubuntu2204) (push) Canceled after 12m17s
Build Packages / build:rpm (rocky9) (push) Canceled after 12m19s
Build Packages / DIALS test (push) Canceled after 7m28s

The d_min <= 0 return was the one failure path that left failure_reason empty.
The report's MODEL_VALIDATION= NOT_PERFORMED line and the WARNING that goes with
it are both gated on that string, so this case printed a blank reason and no
warning - the "indistinguishable from a run that was never given --model" outcome
the field was added to prevent. All four failure returns now set it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016L1qig74oYQzfUJJZbbxFh
This commit is contained in:
2026-08-27 16:28:11 +02:00
co-authored by Claude Opus 5
parent e09ae7e522
commit 7c42439af8
+2 -1
View File
@@ -137,7 +137,8 @@ ModelValidationResult ValidateAgainstModel(const std::vector<MergedReflection> &
if (r.d > 0 && (d_min == 0.0 || r.d < d_min))
d_min = r.d;
if (d_min <= 0.0) {
logger.Error("Model validation: merged reflections carry no resolution");
result.failure_reason = "the merged reflections carry no resolution";
logger.Error("Model validation: {}", result.failure_reason);
return result;
}