DetectorGeometry: Remove IsModularDetector() as it is not used and actually designed wrong

common/DetectorGeometry.h

@@ -21,7 +21,6 @@ public:
     [[nodiscard]] virtual int64_t GetSlowDirectionStep(int64_t module_number) const = 0;
     [[nodiscard]] virtual Coord GetFastDirection(int64_t module_number) const = 0;
     [[nodiscard]] virtual Coord GetSlowDirection(int64_t module_number) const = 0;
-    [[nodiscard]] virtual bool IsModularDetector() const = 0;
 };
 
 #endif //JUNGFRAUJOCH_DETECTORGEOMETRY_H

common/DetectorGeometryFixed.cpp

@@ -78,6 +78,3 @@ void DetectorGeometryFixed::VerticalFlip() {
     // Nothing;
 }
 
-bool DetectorGeometryFixed::IsModularDetector() const {
-    return true;
-}

common/DetectorGeometryFixed.h

@@ -22,7 +22,6 @@ public:
     Coord GetFastDirection(int64_t module_number) const override;
     Coord GetSlowDirection(int64_t module_number) const override;
     void VerticalFlip();
-    bool IsModularDetector() const override;
 };
 
 

common/DetectorGeometryModular.cpp

@@ -141,10 +141,6 @@ void DetectorGeometryModular::VerticalFlip() {
         m.VerticalFlip(height);
 }
 
-bool DetectorGeometryModular::IsModularDetector() const {
-    return false;
-}
-
 int64_t DetectorGeometryModular::GetDirectionStep(DetectorModuleGeometry::Direction direction) const {
     switch (direction) {
         case DetectorModuleGeometry::Direction::Xneg:

common/DetectorGeometryModular.h

@@ -30,7 +30,6 @@ public:
     Coord GetFastDirection(int64_t module_number) const override;
     Coord GetSlowDirection(int64_t module_number) const override;
     void VerticalFlip();
-    bool IsModularDetector() const override;
 };