mx/AareDAQ
0
1 Fork 0
Code Issues 27 Pull Requests 1 Actions Packages Projects Releases 99 Wiki Activity

fix: fall back to jfjoch default when n_images_per_file is not configured #256

Merged
leonarski_f merged 1 commits from fix/jfjoch-images-per-file-default into main 2026-11-04 17:02:00 +01:00
Conversation 1 Commits 1 Files Changed 2
+35 -6
leonarski_f commented 2026-11-04 16:46:53 +01:00
Owner
Copy link
Copy source

Reading jfjoch/n_images_per_file from aare config raises when the key is
not set and has no default (e.g. on x06da), which aborted data collection
setup. Treat a failed lookup like a missing config client: log a warning
and let JFJoch use its own images-per-file default.

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com

Reading jfjoch/n_images_per_file from aare config raises when the key is not set and has no default (e.g. on x06da), which aborted data collection setup. Treat a failed lookup like a missing config client: log a warning and let JFJoch use its own images-per-file default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leonarski_f added 1 commit 2026-11-04 16:46:53 +01:00
fix: fall back to jfjoch default when n_images_per_file is not configured
CI / lint (pull_request) Successful in 1m5s
Details
CI / test (3.12) (pull_request) Successful in 4m13s
Details
CI / test (3.13) (pull_request) Successful in 4m10s
Details
CI / test (3.14) (pull_request) Successful in 4m16s
Details
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 4m4s
Details
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 4m9s
Details
CI / test-with-coverage (pull_request) Successful in 4m23s
Details
CI / coverage-analysis (pull_request) Successful in 2s
Details
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 3m44s
Details
Docs build and publish / docker (push) Successful in 3s
Details
CI / coverage-analysis (push) Canceled after 0s
Details
Build and Publish / release (push) Successful in 59s
Details
CI / test-with-beamline-plugins (pxi_bec) (push) Canceled after 1m6s
Details
CI / test-with-coverage (push) Canceled after 1m3s
Details
CI / test (3.13) (push) Canceled after 1m6s
Details
CI / test (3.12) (push) Canceled after 1m7s
Details
CI / lint (push) Canceled after 1m7s
Details
CI / test-with-beamline-plugins (pxiii_bec) (push) Canceled after 1m4s
Details
CI / test-with-beamline-plugins (pxii_bec) (push) Canceled after 1m4s
Details
CI / test (3.14) (push) Canceled after 1m7s
Details
d0cef9385b 
Reading jfjoch/n_images_per_file from aare config raises when the key is
not set and has no default (e.g. on x06da), which aborted data collection
setup. Treat a failed lookup like a missing config client: log a warning
and let JFJoch use its own images-per-file default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gitea-actions Bot commented 2026-11-04 16:51:22 +01:00
Copy link
Copy source

Coverage report (automated)

Total line + branch coverage: 51%
Diff coverage vs main: 100% (minimum 80%)

Full report: coverage artifact on this run.

Coverage report (automated) Total line + branch coverage: 51% Diff coverage vs main: 100% (minimum 80%) Full report: coverage artifact on this run.
leonarski_f scheduled this pull request to auto merge when all checks succeed 2026-11-04 16:51:35 +01:00
leonarski_f merged commit d0cef9385b into main 2026-11-04 17:02:00 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
buntschu_d (buntschu_d) duan_j (duan_j) glettig_w (glettig_w) gobbo_a (gobbo_a) gotthard_g (gotthard_g) leonarski_f (leonarski_f) mx-gitea olieric (olieric) perl_d (perl_d) takaba_k (takaba_k) wang_m (wang_m)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mx/AareDAQ#256