mx/AareDAQ
0
1
Fork 0
Code Issues 49 Pull Requests Actions Packages Projects Releases 84 Wiki Activity

fix(gui): add "Show beam crosshair" toggle to the camera right-click menu #236

Merged
duan_j merged 3 commits from feat/gui-statusbar-pin-right into main 2026-09-18 16:39:09 +02:00
Conversation 1 Commits 3 Files Changed 2
+48 -7
duan_j commented 2026-09-18 11:38:06 +02:00
Owner
Copy Link
Copy Source

Right-clicking the sample camera now offers a checkable "Show beam
crosshair" entry. When on, two full-frame lines through the beam center
are drawn with the same pen as the beam box, so the crosshair follows
the beam state color. Off by default so the view stays as before.

Co-Authored-By: Claude Fable 5.1 noreply@anthropic.com

Right-clicking the sample camera now offers a checkable "Show beam crosshair" entry. When on, two full-frame lines through the beam center are drawn with the same pen as the beam box, so the crosshair follows the beam state color. Off by default so the view stays as before. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
duan_j added 1 commit 2026-09-18 11:38:07 +02:00
fix(gui): add "Show beam crosshair" toggle to the camera right-click menu
CI / lint (push) Skipped
CI / test (3.12) (push) Skipped
CI / test (3.13) (push) Skipped
CI / test-with-beamline-plugins (pxi_bec) (push) Skipped
CI / test-with-beamline-plugins (pxii_bec) (push) Skipped
CI / test-with-beamline-plugins (pxiii_bec) (push) Skipped
CI / lint (pull_request) Successful in 49s
Details
CI / test (3.12) (pull_request) Successful in 1m10s
Details
CI / test (3.13) (pull_request) Successful in 1m11s
Details
CI / test (3.14) (pull_request) Successful in 1m17s
Details
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 1m13s
Details
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 1m14s
Details
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 1m36s
Details
CI / test-with-coverage (pull_request) Successful in 1m23s
Details
CI / coverage-analysis (pull_request) Successful in 2m7s
Details
b5e6159118 
Right-clicking the sample camera now offers a checkable "Show beam
crosshair" entry. When on, two full-frame lines through the beam center
are drawn with the same pen as the beam box, so the crosshair follows
the beam state color. Off by default so the view stays as before.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
gitea-actions bot commented 2026-09-18 14:55:14 +02:00
Copy Link
Copy Source

Coverage report (automated)

Total line + branch coverage: 51%
Diff coverage vs main: 100% (minimum 80%)

Full report: coverage artifact on this run.

Coverage report (automated) Total line + branch coverage: 51% Diff coverage vs main: 100% (minimum 80%) Full report: coverage artifact on this run.
duan_j added 1 commit 2026-09-18 15:09:11 +02:00
style: have the cross hair not too long, just a small cross
CI / lint (push) Skipped
CI / test (3.12) (push) Skipped
CI / test (3.13) (push) Skipped
CI / test-with-beamline-plugins (pxi_bec) (push) Skipped
CI / test-with-beamline-plugins (pxii_bec) (push) Skipped
CI / test-with-beamline-plugins (pxiii_bec) (push) Skipped
CI / lint (pull_request) Successful in 44s
Details
CI / test (3.12) (pull_request) Successful in 1m2s
Details
CI / test (3.13) (pull_request) Successful in 1m10s
Details
CI / test (3.14) (pull_request) Successful in 1m15s
Details
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 1m16s
Details
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 1m29s
Details
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 1m27s
Details
CI / test-with-coverage (pull_request) Successful in 1m46s
Details
CI / coverage-analysis (pull_request) Successful in 4s
Details
3f404af069 
Anuschka and Katherine really need it
duan_j added 1 commit 2026-09-18 16:37:13 +02:00
style(gui): soften the mounted-sample HUD ink on light themes
CI / lint (pull_request) Successful in 51s
Details
CI / test (3.12) (pull_request) Successful in 1m18s
Details
CI / test (3.14) (pull_request) Successful in 1m15s
Details
CI / test (3.13) (pull_request) Successful in 1m23s
Details
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 1m16s
Details
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 1m23s
Details
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 1m38s
Details
CI / test-with-coverage (pull_request) Successful in 1m41s
Details
Docs build and publish / docker (push) Successful in 10s
Details
CI / lint (push) Successful in 35s
Details
CI / coverage-analysis (pull_request) Successful in 10s
Details
CI / test (3.12) (push) Canceled after 48s
Details
CI / test (3.13) (push) Canceled after 43s
Details
CI / test (3.14) (push) Canceled after 43s
Details
CI / test-with-beamline-plugins (pxi_bec) (push) Canceled after 38s
Details
CI / test-with-beamline-plugins (pxii_bec) (push) Canceled after 38s
Details
CI / test-with-beamline-plugins (pxiii_bec) (push) Canceled after 33s
Details
CI / test-with-coverage (push) Canceled after 33s
Details
CI / coverage-analysis (push) Canceled after 0s
Details
Build and Publish / release (push) Successful in 20s
Details
79bb351437 
Pure black (SHADOW) over the camera image read too harsh; use the
theme text ink (TEXT) with the same white halo instead. Sunset keeps
white on black.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
duan_j scheduled this pull request to auto merge when all checks succeed 2026-09-18 16:38:33 +02:00
duan_j merged commit 79bb351437 into main 2026-09-18 16:39:09 +02:00
duan_j deleted branch feat/gui-statusbar-pin-right 2026-09-18 16:39:09 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
buntschu_d (buntschu_d) duan_j (duan_j) glettig_w (glettig_w) gobbo_a (gobbo_a) gotthard_g (gotthard_g) leonarski_f (leonarski_f) mx-gitea olieric (olieric) perl_d (perl_d) takaba_k (takaba_k) wang_m (wang_m)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mx/AareDAQ#236