mx/AareDAQ
0
1
Fork 0
Code Issues 49 Pull Requests Actions Packages Projects Releases 84 Wiki Activity

Feat/smart rotation dose strategy 2 #229

Merged
perl_d merged 3 commits from feat/smart-rotation-dose-strategy-2 into main 2026-09-16 09:36:19 +02:00
Conversation 2 Commits 3 Files Changed 1
+306 -194
leonarski_f commented 2026-09-14 16:27:52 +02:00
Owner
Copy Link
Copy Source

Simple parameter panel simplification

Simple parameter panel simplification
leonarski_f added 2 commits 2026-09-14 16:27:52 +02:00
Feat: Improve smart data collection panel
CI / lint (push) Skipped
CI / test (3.12) (push) Skipped
CI / test (3.13) (push) Skipped
CI / test-with-beamline-plugins (pxi_bec) (push) Skipped
CI / test-with-beamline-plugins (pxii_bec) (push) Skipped
CI / test-with-beamline-plugins (pxiii_bec) (push) Skipped
766ca8b71e
Fix: Calculated dose rate units
CI / lint (push) Skipped
CI / test (3.12) (push) Skipped
CI / test (3.13) (push) Skipped
CI / test-with-beamline-plugins (pxi_bec) (push) Skipped
CI / test-with-beamline-plugins (pxii_bec) (push) Skipped
CI / test-with-beamline-plugins (pxiii_bec) (push) Skipped
CI / lint (pull_request) Failing after 43s
Details
CI / test (3.12) (pull_request) Successful in 1m13s
Details
CI / test (3.14) (pull_request) Successful in 1m14s
Details
CI / test (3.13) (pull_request) Successful in 1m18s
Details
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 1m17s
Details
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 1m22s
Details
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 1m36s
Details
CI / test-with-coverage (pull_request) Successful in 1m49s
Details
CI / coverage-analysis (pull_request) Failing after 4s
Details
b17b38adfe
gitea-actions bot commented 2026-09-14 16:30:06 +02:00
Copy Link
Copy Source

Coverage report (automated)

Total line + branch coverage: 51%
Diff coverage vs main: 77% (minimum 80%)

Full report: coverage artifact on this run.

Coverage report (automated) Total line + branch coverage: 51% Diff coverage vs main: 77% (minimum 80%) Full report: coverage artifact on this run.
leonarski_f added 1 commit 2026-09-14 16:43:33 +02:00
Feat: Setup dose/Ang
CI / lint (push) Skipped
CI / test (3.12) (push) Skipped
CI / test (3.13) (push) Skipped
CI / test-with-beamline-plugins (pxi_bec) (push) Skipped
CI / test-with-beamline-plugins (pxii_bec) (push) Skipped
CI / test-with-beamline-plugins (pxiii_bec) (push) Skipped
CI / lint (pull_request) Failing after 43s
Details
CI / test (3.12) (pull_request) Successful in 1m12s
Details
CI / test (3.14) (pull_request) Successful in 1m15s
Details
CI / test (3.13) (pull_request) Successful in 1m20s
Details
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 1m20s
Details
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 1m29s
Details
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 1m35s
Details
CI / test-with-coverage (pull_request) Successful in 1m44s
Details
CI / coverage-analysis (pull_request) Failing after 3s
Details
4ce7692e86
perl_d approved these changes 2026-09-16 09:12:26 +02:00
perl_d left a comment
Owner
Copy Link
Copy Source

looks fine, one minor comment

looks fine, one minor comment
src/aare/gui/panels/smart_rotation_panel.py
@@ -352,2 +447,3 @@
)
self.total_time_s = self.target_dose_MGy / self.dose_rate_MGy_s
if self._beamline is MXBeamline.X10SA:
perl_d commented 2026-09-16 09:10:42 +02:00
Owner
Copy Link
Copy Source

minor: I'm trying to reduce the use of if beamline is ...: to make the eventual necessary refactor easier, prefer adding beamline specific stuff to the beamline_dispatch protocol(s) and just using dispatch.blah here - but we would need to make a frontend/GUI version which didn't have the hardware/bec macros so I think this is acceptable for now - this stuff should probably actually just go into config anyway

minor: I'm trying to reduce the use of `if beamline is ...:` to make the eventual necessary refactor easier, prefer adding beamline specific stuff to the `beamline_dispatch` protocol(s) and just using `dispatch.blah` here - but we would need to make a frontend/GUI version which didn't have the hardware/bec macros so I think this is acceptable for now - this stuff should probably actually just go into config anyway
perl_d merged commit 5c600785f4 into main 2026-09-16 09:36:19 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
perl_d
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
buntschu_d (buntschu_d) duan_j (duan_j) glettig_w (glettig_w) gobbo_a (gobbo_a) gotthard_g (gotthard_g) leonarski_f (leonarski_f) mx-gitea olieric (olieric) perl_d (perl_d) takaba_k (takaba_k) wang_m (wang_m)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mx/AareDAQ#229