Sample list: spreadsheet param columns + whole-row mounted highlight #209

Merged

perl_d merged 2 commits from where_I_am_show_more_info into main 2026-09-09 18:12:59 +02:00

Conversation 1 Commits 2 Files Changed 2

+80 -9

duan_j commented 2026-09-09 15:33:10 +02:00

Owner

Copy link

Copy source

Summary

Two independent changes to the dewar sample list, one commit each:

1. feat: show spreadsheet params in sample list

   • New columns after Rotation count: Oscillation (deg), Exposure (s),
     Total range (deg), Transmission (%).
   • Read from SampleShortInfo.aaredb_params, which spreadsheetupdater
     already fills from the AareDB message. No server or DB change.
   • Transmission is shown as percent like the user spreadsheet
     (model holds a 0-1 fraction).
   • Header sort key is now None-safe: blanks sort last instead of
     raising on None < float.

2. feat: highlight whole mounted row in sample list

   • Mounted sample paints the full row in the existing blue
     (SAMPLE_ROW_QUEUED_BG) instead of only the frozen "#" cell.
   • Mounted row keeps the theme's own text color; the dark-ink override
     stays only on the pastel status tints in the "#" column.
   • Mount/unmount repaints the whole row span.

Test plan

• tests/unit/gui/test_models.py: 2 new tests (param columns + None-safe
  sort, whole-row blue without foreground override)
• ruff check (incl. isort gate), ruff format --check
• diff-cover 100%, diff-quality basedpyright 100%
• Full unit suite: only the known-flaky test_main_window QSettings
  tests failed in-suite, both pass in isolation
• Visual check on the RHEL9/noVNC sandbox

Generated with Claude Code

## Summary Two independent changes to the dewar sample list, one commit each: 1. feat: show spreadsheet params in sample list - New columns after Rotation count: Oscillation (deg), Exposure (s), Total range (deg), Transmission (%). - Read from SampleShortInfo.aaredb_params, which spreadsheetupdater already fills from the AareDB message. No server or DB change. - Transmission is shown as percent like the user spreadsheet (model holds a 0-1 fraction). - Header sort key is now None-safe: blanks sort last instead of raising on None < float. 2. feat: highlight whole mounted row in sample list - Mounted sample paints the full row in the existing blue (SAMPLE_ROW_QUEUED_BG) instead of only the frozen "#" cell. - Mounted row keeps the theme's own text color; the dark-ink override stays only on the pastel status tints in the "#" column. - Mount/unmount repaints the whole row span. ## Test plan - [x] tests/unit/gui/test_models.py: 2 new tests (param columns + None-safe sort, whole-row blue without foreground override) - [x] ruff check (incl. isort gate), ruff format --check - [x] diff-cover 100%, diff-quality basedpyright 100% - [x] Full unit suite: only the known-flaky test_main_window QSettings tests failed in-suite, both pass in isolation - [ ] Visual check on the RHEL9/noVNC sandbox Generated with Claude Code

gitea-actions Bot commented 2026-09-09 15:35:21 +02:00

Copy link

Copy source

Coverage report (automated)

Total line + branch coverage: 51%
Diff coverage vs main: 100% (minimum 80%)

Full report: coverage artifact on this run.

Coverage report (automated) Total line + branch coverage: 51% Diff coverage vs main: 100% (minimum 80%) Full report: coverage artifact on this run.

duan_j added 2 commits 2026-09-09 16:54:45 +02:00

feat: show spreadsheet params in sample list ... a2c5ed3d5c

Add Oscillation, Exposure, Total range and Transmission columns to the
dewar sample table, read from SampleShortInfo.aaredb_params (already
filled by spreadsheetupdater from AareDB, so no server change).
Transmission is shown as percent like the user spreadsheet.

The new columns are nullable, so the header sort key now puts None last
instead of raising on None < float.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

feat: highlight whole mounted row in sample list ... 22228c0868

The mounted sample used to tint only the frozen "#" cell. Paint the full
row in the same blue so it is findable at a glance, and keep the theme's
own text color on it (the mid-tone blue reads fine without the dark ink
that the pastel status tints need). Repaint the whole row span on
mount/unmount, not just column 0.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

duan_j force-pushed where_I_am_show_more_info from 22bb3b2e46 to 22228c0868 2026-09-09 16:54:45 +02:00 Compare

perl_d merged commit 22228c0868 into main 2026-09-09 18:12:59 +02:00

perl_d deleted branch where_I_am_show_more_info 2026-09-09 18:13:06 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

buntschu_d (buntschu_d) duan_j (duan_j) glettig_w (glettig_w) gobbo_a (gobbo_a) gotthard_g (gotthard_g) leonarski_f (leonarski_f) mx-gitea olieric (olieric) perl_d (perl_d) takaba_k (takaba_k) wang_m (wang_m)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mx/AareDAQ#209