mx/AareDAQ
0
1
Fork 0
Code Issues 52 Pull Requests 1 Actions Packages Projects Releases 65 Wiki Activity

Feat/disable reload db param #168

Merged
duan_j merged 4 commits from feat/disable-reload-db-param into main 2026-08-25 13:54:29 +02:00
Conversation 3 Commits 4 Files Changed 3
+4 -15
duan_j commented 2026-08-25 11:12:32 +02:00
Owner
Copy Link
Copy Source

According to Vincent's input:
disable Reload DB button and related usages
reorder unmeasured to the front of measured

According to Vincent's input: disable Reload DB button and related usages reorder unmeasured to the front of measured
gitea-actions bot commented 2026-08-25 11:14:50 +02:00
Copy Link
Copy Source

Coverage report (automated)

Total line + branch coverage: 50%
Diff coverage vs main: 100% (minimum 80%)

Full report: coverage artifact on this run.

Coverage report (automated) Total line + branch coverage: 50% Diff coverage vs main: 100% (minimum 80%) Full report: coverage artifact on this run.
duan_j added 2 commits 2026-08-25 13:07:01 +02:00
style: reorder the position of measured tab 838ae1828b
feat: disable Reload DB params and related usage
CI / lint (push) Skipped
CI / test (3.11) (push) Skipped
CI / test (3.12) (push) Skipped
CI / test (3.13) (push) Skipped
CI / test-with-beamline-plugins (pxi_bec) (push) Skipped
CI / test-with-beamline-plugins (pxii_bec) (push) Skipped
CI / test-with-beamline-plugins (pxiii_bec) (push) Skipped
CI / lint (pull_request) Successful in 42s
Details
CI / test (3.11) (pull_request) Successful in 1m3s
Details
CI / test (3.13) (pull_request) Successful in 1m3s
Details
CI / test (3.12) (pull_request) Successful in 1m4s
Details
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 1m14s
Details
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 1m18s
Details
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 1m30s
Details
CI / test-with-coverage (pull_request) Successful in 1m36s
Details
CI / coverage-analysis (pull_request) Successful in 3s
Details
96d7e82f48
duan_j force-pushed feat/disable-reload-db-param from 6ed6cc153b to 96d7e82f48 2026-08-25 13:07:01 +02:00 Compare
duan_j commented 2026-08-25 13:25:59 +02:00
Author
Owner
Copy Link
Copy Source

@perl_d ready for review and merge =)

Checked with Katherine and she says she doesn't use Reload DB params, the removal was requested by Vincent.

And I didn't remove them just in case we need them??? I don't know, maybe we should remove them directly

@perl_d ready for review and merge =) Checked with Katherine and she says she doesn't use `Reload DB params`, the removal was requested by Vincent. And I didn't remove them just in case we need them??? I don't know, maybe we should remove them directly
src/aare/gui/panels/rotation_data_collection.py Outdated
@@ -163,3 +163,1 @@
self._layout.removeWidget(self.reload_params_button)
self._layout.addWidget(self.reload_params_button, 15, 0, 1, 6)
self.reload_params_button.setVisible(True)
# self._layout.removeWidget(self.reload_params_button)
perl_d commented 2026-08-25 13:34:17 +02:00
Owner
Copy Link
Copy Source

please don't comment out code, just delete it. it is always available in the history.

please don't comment out code, just delete it. it is always available in the history.
duan_j commented 2026-08-25 13:48:55 +02:00
Author
Owner
Copy Link
Copy Source

deleted =)

deleted =)
duan_j marked this conversation as resolved
duan_j added 1 commit 2026-08-25 13:48:03 +02:00
style:delete the commented code
CI / lint (push) Skipped
CI / test (3.11) (push) Skipped
CI / test (3.12) (push) Skipped
CI / test (3.13) (push) Skipped
CI / test-with-beamline-plugins (pxi_bec) (push) Skipped
CI / test-with-beamline-plugins (pxii_bec) (push) Skipped
CI / test-with-beamline-plugins (pxiii_bec) (push) Skipped
CI / lint (pull_request) Canceled after 32s
Details
CI / test (3.13) (pull_request) Canceled after 26s
Details
CI / test (3.11) (pull_request) Canceled after 31s
Details
CI / test (3.12) (pull_request) Canceled after 27s
Details
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Canceled after 22s
Details
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Canceled after 21s
Details
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Canceled after 17s
Details
CI / test-with-coverage (pull_request) Canceled after 16s
Details
CI / coverage-analysis (pull_request) Canceled after 0s
Details
0a30723f6a
duan_j added 1 commit 2026-08-25 13:48:38 +02:00
style:delete the commented code
CI / lint (pull_request) Successful in 52s
Details
CI / test (3.12) (pull_request) Successful in 1m4s
Details
CI / test (3.13) (pull_request) Successful in 1m40s
Details
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 1m9s
Details
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 1m38s
Details
CI / test-with-coverage (pull_request) Successful in 1m49s
Details
CI / coverage-analysis (pull_request) Successful in 3s
Details
CI / test (3.11) (pull_request) Successful in 57s
Details
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 1m5s
Details
CI / lint (push) Successful in 40s
Details
Docs build and publish / docker (push) Successful in 24s
Details
CI / test (3.11) (push) Canceled after 49s
Details
CI / test-with-beamline-plugins (pxi_bec) (push) Canceled after 41s
Details
CI / test (3.12) (push) Canceled after 46s
Details
CI / test (3.13) (push) Canceled after 44s
Details
CI / test-with-beamline-plugins (pxii_bec) (push) Canceled after 39s
Details
CI / test-with-beamline-plugins (pxiii_bec) (push) Canceled after 36s
Details
CI / test-with-coverage (push) Canceled after 34s
Details
CI / coverage-analysis (push) Canceled after 0s
Details
Build and Publish / release (push) Successful in 36s
Details
873143d846
duan_j merged commit 873143d846 into main 2026-08-25 13:54:29 +02:00
duan_j deleted branch feat/disable-reload-db-param 2026-08-25 13:54:29 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
perl_d
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
buntschu_d (buntschu_d) duan_j (duan_j) glettig_w (glettig_w) gobbo_a (gobbo_a) gotthard_g (gotthard_g) leonarski_f (leonarski_f) mx-gitea olieric (olieric) perl_d (perl_d) takaba_k (takaba_k) wang_m (wang_m)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mx/AareDAQ#168