Feat/style input box #162

Merged

duan_j merged 13 commits from feat/style-input-box into main 2026-08-24 19:26:49 +02:00

Conversation 1 Commits 13 Files Changed 17

+418 -41

duan_j commented 2026-08-22 02:54:45 +02:00

Owner

Copy Link

Copy Source

make input box change color (orange = pending) and clear the color after enter
update banner to have colored text so it shows on both white/black backgrounds

make input box change color (orange = pending) and clear the color after enter update banner to have colored text so it shows on both white/black backgrounds

duan_j force-pushed feat/style-input-box from 93fddd7a1b to 11a3487c00 2026-08-22 02:54:56 +02:00 Compare

gitea-actions bot commented 2026-08-22 03:11:43 +02:00

Copy Link

Copy Source

Coverage report (automated)

Total line + branch coverage: 50%
Diff coverage vs main: 100% (minimum 80%)

Full report: coverage artifact on this run.

Coverage report (automated) Total line + branch coverage: 50% Diff coverage vs main: 100% (minimum 80%) Full report: coverage artifact on this run.

duan_j force-pushed feat/style-input-box from 194ab82322 to 3354745648 2026-08-24 13:40:05 +02:00 Compare

duan_j force-pushed feat/style-input-box from 3354745648 to a75eac264e 2026-08-24 13:40:27 +02:00 Compare

duan_j force-pushed feat/style-input-box from a75eac264e to cf68a4c34c 2026-08-24 18:45:05 +02:00 Compare

duan_j added 13 commits 2026-08-24 19:24:31 +02:00

chore: sync uv.lock with 0.13.4 version bump ... d65ff27b3a

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

feat: pending color while typing in Experiment configuration values ... 3e7c334abb

Values inside the Experiment configuration banner now show the same
pending color as the motor move boxes while the typed text differs from
the applied value; Enter (or focus-out) commits as before and clears it.
Opt-in via NumberLineEdit(track_pending=True) because MotorMoveGroup
owns the movestate property on its registered boxes; reuses the existing
movestate QSS, so no new styling. The Set Energy spinbox marks pending
until Change Energy is clicked, since its apply gate is the button.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

feat: bound Set Energy to a 4-20 keV placeholder range ... 225d7064c4

Both Set Energy rows allowed 1-30 keV, an arbitrary spinbox default;
nothing downstream validates the request (daq.change_energy forwards
straight to bec). Shared ENERGY_MIN/MAX_KEV constants now bound both
spins to 4-20 keV with a tooltip flagging the range as pending
Beamline Scientist confirmation.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

feat: MotorMoveGroup semantics for both Set Energy rows ... e1d11aa949

The energy setpoint applies via the Change Energy button, not Enter, so
it gets the full motor state machine instead of the typing-pending
color: neutral tracks the readback, a user edit stages pending (and is
the only thing that enables the button), the click turns moving, and
readback arrival within tol returns to neutral. New SpinMoveState in
motor_move_group.py adapts the pattern to a QDoubleSpinBox+button pair
(colors ride the movestate QSS via the spin's internal QLineEdit);
replaces the hand-rolled pending-until-click in the exp-config row and
covers the Beamline setup row that had no color at all. The server's
0.0 detector-unavailable energy is kept out of the readback feed so it
cannot clamp the spin to the range minimum.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix: energy spin movestate colors never rendered ... b984a36f7c

The movestate property sat on the spinbox's inner QLineEdit, which both
themes deliberately paint transparent (QAbstractSpinBox QLineEdit rule)
- the state machine worked but no color ever showed, and the tests only
asserted the property, not the paint. The property now lives on the
spinbox itself with QAbstractSpinBox[movestate=...] added to both
themes' rules, verified by a pixel-sampling regression test that grabs
the rendered widget through the real stylesheet.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

style: make the banner text colored ... 3192fd2388

so it shows on white/black background

test: sample padding pixel so movestate colors survive Linux fonts ... a7bd46c14b

x=20 sits on a digit glyph with CI's Linux fonts, so the assert compared
an antialiased glyph blend against the pure background. The padding area
(border 1px + padding 6px) can never contain text on any font.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0147jE48bQUTm9AqNQApT6b2

fix: energy tolerance to 0.001 instead of 0.01 789b2ae6e2

chore: cleanup repeating code 09f81c8392

feat: allow dismissing notification. Trial. If not good, revert this. bdafc03963

test: log panel c71676a29c

fix: wheel include png and svg 855632d5b5

test: no need to test energy 0 and update tolerance ... a19cbf1081

test: update test...

duan_j force-pushed feat/style-input-box from 14c7c1605a to a19cbf1081 2026-08-24 19:24:31 +02:00 Compare

duan_j merged commit a19cbf1081 into main 2026-08-24 19:26:49 +02:00

duan_j deleted branch feat/style-input-box 2026-08-24 19:26:49 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

buntschu_d (buntschu_d) duan_j (duan_j) glettig_w (glettig_w) gobbo_a (gobbo_a) gotthard_g (gotthard_g) leonarski_f (leonarski_f) mx-gitea olieric (olieric) perl_d (perl_d) takaba_k (takaba_k) wang_m (wang_m)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: mx/AareDAQ#162