mx/AareDAQ
0
1
Fork 0
Code Issues 27 Pull Requests Actions Packages Projects Releases 95 Wiki Activity

WIP: refactor: replace Qt overrides with native mechanisms, install app filters once #142

Closed
duan_j wants to merge 1 commits from refactor/reduce-overwriting-qt-method into fix/graphics-and-recovery
pull from: refactor/reduce-overwriting-qt-method
merge into: :fix/graphics-and-recovery
Conversation 1 Commits 1 Files Changed 9
+183 -113
duan_j commented 2026-08-17 10:56:43 +02:00
Owner
Copy Link
Copy Source

To be tested

Per-window installs of the two QApplication-level filters (cursor,
wheel guard) stacked one stale copy per MainWindow; now installed once
per process, parented to the app. closeEvent overrides in the baton
dialogs replaced by finished.connect(timer.stop); keyPressEvent in
VideoGraphicsView replaced by WidgetShortcut QShortcuts; hover
enter/leave overrides in PlayPauseButton replaced by underMouse();
ValueLabel inherits ClickableLabel instead of duplicating its
mousePressEvent. Dead raster-timer branch and a PyQt5-era
event-position fallback deleted; redundant try/except and getattr
guards dropped now that class-level defaults cover pre-init reads.

Co-Authored-By: Claude Fable 5 noreply@anthropic.com

To be tested Per-window installs of the two QApplication-level filters (cursor, wheel guard) stacked one stale copy per MainWindow; now installed once per process, parented to the app. closeEvent overrides in the baton dialogs replaced by finished.connect(timer.stop); keyPressEvent in VideoGraphicsView replaced by WidgetShortcut QShortcuts; hover enter/leave overrides in PlayPauseButton replaced by underMouse(); ValueLabel inherits ClickableLabel instead of duplicating its mousePressEvent. Dead raster-timer branch and a PyQt5-era event-position fallback deleted; redundant try/except and getattr guards dropped now that class-level defaults cover pre-init reads. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
duan_j added 1 commit 2026-08-17 10:56:43 +02:00
refactor: replace Qt overrides with native mechanisms, install app filters once
CI / lint (push) Skipped
CI / test (3.11) (push) Skipped
CI / test (3.12) (push) Skipped
CI / test (3.13) (push) Skipped
CI / test-with-beamline-plugins (pxi_bec) (push) Skipped
CI / test-with-beamline-plugins (pxii_bec) (push) Skipped
CI / test-with-beamline-plugins (pxiii_bec) (push) Skipped
CI / test (3.11) (pull_request) Successful in 1m0s
Details
CI / test (3.12) (pull_request) Successful in 1m5s
Details
CI / test (3.13) (pull_request) Successful in 1m11s
Details
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 1m8s
Details
CI / lint (pull_request) Successful in 1m21s
Details
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 1m10s
Details
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 1m22s
Details
CI / test-with-coverage (pull_request) Successful in 1m35s
Details
CI / coverage-analysis (pull_request) Successful in 4s
Details
111c6885f9 
Per-window installs of the two QApplication-level filters (cursor,
wheel guard) stacked one stale copy per MainWindow; now installed once
per process, parented to the app. closeEvent overrides in the baton
dialogs replaced by finished.connect(timer.stop); keyPressEvent in
VideoGraphicsView replaced by WidgetShortcut QShortcuts; hover
enter/leave overrides in PlayPauseButton replaced by underMouse();
ValueLabel inherits ClickableLabel instead of duplicating its
mousePressEvent. Dead raster-timer branch and a PyQt5-era
event-position fallback deleted; redundant try/except and getattr
guards dropped now that class-level defaults cover pre-init reads.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gitea-actions bot commented 2026-08-17 10:58:42 +02:00
Copy Link
Copy Source

Coverage report (automated)

Total line + branch coverage: 48%
Diff coverage vs fix/graphics-and-recovery: 100% (minimum 80%)

Full report: coverage artifact on this run.

Coverage report (automated) Total line + branch coverage: 48% Diff coverage vs fix/graphics-and-recovery: 100% (minimum 80%) Full report: coverage artifact on this run.
duan_j closed this pull request 2026-08-17 16:26:09 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
buntschu_d (buntschu_d) duan_j (duan_j) glettig_w (glettig_w) gobbo_a (gobbo_a) gotthard_g (gotthard_g) leonarski_f (leonarski_f) mx-gitea olieric (olieric) perl_d (perl_d) takaba_k (takaba_k) wang_m (wang_m)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mx/AareDAQ#142