fix: report better errors on critical failures
CI / lint (pull_request) Successful in 45s
CI / test (3.12) (pull_request) Successful in 1m7s
CI / test (3.13) (pull_request) Successful in 1m10s
CI / test (3.14) (pull_request) Successful in 1m8s
CI / test-with-beamline-plugins (pxi_bec) (pull_request) Successful in 1m10s
CI / test-with-beamline-plugins (pxii_bec) (pull_request) Successful in 1m14s
CI / test-with-beamline-plugins (pxiii_bec) (pull_request) Successful in 1m31s
CI / test-with-coverage (pull_request) Successful in 1m38s
CI / coverage-analysis (pull_request) Successful in 4s
CI / lint (push) Successful in 30s
Docs build and publish / docker (push) Successful in 15s
CI / test (3.12) (push) Canceled after 41s
CI / test (3.13) (push) Canceled after 39s
CI / test (3.14) (push) Canceled after 36s
CI / test-with-beamline-plugins (pxi_bec) (push) Canceled after 34s
CI / test-with-beamline-plugins (pxii_bec) (push) Canceled after 31s
CI / test-with-beamline-plugins (pxiii_bec) (push) Canceled after 29s
CI / test-with-coverage (push) Canceled after 26s
CI / coverage-analysis (push) Canceled after 0s
Build and Publish / release (push) Successful in 29s

This commit was merged in pull request #235.
This commit is contained in:
David Perl
2026-09-17 15:50:13 +02:00
parent 106b8b9093
commit 735650aea7
2 changed files with 3 additions and 3 deletions
+2 -2
View File
@@ -415,7 +415,7 @@ class SampleQueuePanel(QFrame):
self._emit_samples_in_queue_changed()
self.automation_running_changed.emit(False)
@Slot(int, bool)
@Slot(int, bool, str)
def automated_scan_done(self, db_id: int, success: bool, reply: str):
if self._current_db_id is not None and db_id != self._current_db_id:
return
@@ -470,7 +470,7 @@ class SampleQueuePanel(QFrame):
self.show_error_dialog(
title=reply,
msg="Critical Error",
info="Repeated mount failuers.\n"
info="Repeated mount failures.\n"
"Please check to see if pins"
" are loaded in these postions."
"\n If not please continue with new "
+1 -1
View File
@@ -111,7 +111,7 @@ class DAQWorker(QObject):
# from /status; surfaced as a non-modal warning banner.
pss_alarm_changed = Signal(bool)
automated_scan_done = Signal(int, bool, str) # sample ID, success
automated_scan_done = Signal(int, bool, str) # sample ID, success, message
run_number_incremented = Signal()
raster_scan_completed = Signal(CompletedRasterGrid)
standard_scan_completed = Signal(CompletedRotationScan)