lin-midas-drivers/mepicsca
0
0 Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Improvements after code discussion 28.04.2026 #2

New Issue
Open
opened 2026-04-28 12:01:16 +02:00 by mathis_s · 2 comments
mathis_s commented 2026-04-28 12:01:16 +02:00
Owner
Copy link
Copy source
  • Add docstrings where the weird casting in getRaw for waveforms is explained
  • Add support for 64bit ints
  • Test what happens if I try to write / read a too long string to / from a stringin
  • Add locks around _cached and _chanInfo accesses (because these might be updated from the callback threads)
  • Removes accessor method to cached value
  • Add CI pipeline
  • Use Midas INVALID error where appropriate
  • Return the value even if the severity is minor or major (but don't for an invalid record)
  • Prefetch enum variant strings if the record is an enum record
  • Remove Darwin stuff in CMakeLists.txt
  • Add explicit string constructor to *value = buf in get method.
  • Check if signal(SIGTERM, SIG_IGN); can be removed.
  • Collapsed putRaw and getRaw into single, templated methods
  • Simplified readout of status and severity in callback.
  • Make it possible to use put asynchronously.
  • Document which types are possible for put and get
- [x] Add docstrings where the weird casting in getRaw for waveforms is explained - [ ] Add support for 64bit ints - [x] Test what happens if I try to write / read a too long string to / from a stringin - [x] Add locks around _cached and _chanInfo accesses (because these might be updated from the callback threads) - [x] Removes accessor method to cached value - [x] Add CI pipeline - [x] Use Midas INVALID error where appropriate - [x] Return the value even if the severity is minor or major (but don't for an invalid record) - [x] Prefetch enum variant strings if the record is an enum record - [x] Remove Darwin stuff in CMakeLists.txt - [x] Add explicit string constructor to `*value = buf` in `get` method. - [x] Check if `signal(SIGTERM, SIG_IGN);` can be removed. - [x] Collapsed `putRaw` and `getRaw` into single, templated methods - [x] Simplified readout of status and severity in callback. - [x] Make it possible to use `put` asynchronously. - [x] Document which types are possible for `put` and `get`
mathis_s commented 2026-04-28 16:51:07 +02:00
Author
Owner
Copy link
Copy source

No, signal(SIGTERM, SIG_IGN); needs to stay.

No, `signal(SIGTERM, SIG_IGN);` needs to stay.
mathis_s commented 2026-04-29 09:45:07 +02:00
Author
Owner
Copy link
Copy source

CI is now running, that was a biggy :-)

CI is now running, that was a biggy :-)
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
krieger_j (krieger_j) mathis_s (mathis_s) mueller_r4 (mueller_r4) soederqvist_a (soederqvist_a) wall_e (wall_e)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lin-midas-drivers/mepicsca#2