lin-midas-drivers/ePowerSwitch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Code review 30 apr #1

New Issue
Closed
opened 2026-04-30 13:10:16 +02:00 by ponsin_h · 2 comments
ponsin_h commented 2026-04-30 13:10:16 +02:00
Owner
Copy Link
Copy Source
  • include dir must only contained expose header for library, mode all header into src dir
  • split code into frontend and equipment
    - [ ] format() -> reduce memory allocation => use name from Settings
  • argc -> write default and overwrite after
  • l.55 remove new
  • "don't know comment" -> should like to the exemple or line need to be removed
  • maybe .get and .put already return a correct error message (may remove mine)
    - [ ] format() : use ref if possible
  • vector.back_pop should be closer to vector.back()
  • remove ptr in vector if possible
- [x] include dir must only contained expose header for library, mode all header into src dir - [x] split code into frontend and equipment ~~- [ ] format() -> reduce memory allocation~~ => use name from Settings - [x] argc -> write default and overwrite after - [x] l.55 remove new - [x] "don't know comment" -> should like to the exemple or line need to be removed - [x] maybe .get and .put already return a correct error message (may remove mine) ~~- [ ] format() : use ref if possible~~ - [x] vector.back_pop should be closer to vector.back() - [x] remove ptr in vector if possible
ponsin_h commented 2026-04-30 16:56:04 +02:00
Author
Owner
Copy Link
Copy Source

cannot remote ptr, using uniqu_ptr now

cannot remote ptr, using uniqu_ptr now
ponsin_h commented 2026-05-01 14:26:20 +02:00
Author
Owner
Copy Link
Copy Source

added naming field

added naming field
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
krieger_j (krieger_j) mathis_s (mathis_s) mueller_r4 (mueller_r4) ponsin_h (ponsin_h) soederqvist_a (soederqvist_a) wall_e (wall_e)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lin-midas-drivers/ePowerSwitch#1