CodeReview#2 #4

New Issue

2026-05-19T11:33:25+02:00

ponsin_h commented

2026-05-19 11:33:25 +02:00

output : read the record and override user input with it
if channel unused, print and error but continue to run
converting need to be more explicite
double => bool (true if x != 0 else false)
integer => clamp value (no overflow / underflow)
unsigned => stay in possitif
Name : default name should never be identical from the current one
Detect if some name are identical, and print error message + exit if so
put error message if size changed (can't detect where the new value have been added)
README.md
put more into description
put 2 picutres, config + result
int16_t => uint16_t
int type is missing
put typeas CAINFO show (more easy for scientiste)
Inform that frontend and logger should be restarted after modification
typo : valide => valid in english
check wrong type : add index to the error message
initVariableDir() : add comment on the why
generate Template message should only be writtend on time
addToChannel => addChannel (rename)
float / double => error, it's not the same type

- [ ] output : read the record and override user input with it - [ ] if channel unused, print and error but continue to run - [ ] converting need to be more explicite - [ ] double => bool (true if x != 0 else false) - [ ] integer => clamp value (no overflow / underflow) - [ ] unsigned => stay in possitif - [ ] Name : default name should never be identical from the current one - [ ] Detect if some name are identical, and print error message + exit if so - [ ] put error message if size changed (can't detect where the new value have been added) - [ ] README.md - [ ] put more into description - [ ] put 2 picutres, config + result - [ ] int16_t => uint16_t - [ ] int type is missing - [ ] put typeas CAINFO show (more easy for scientiste) - [ ] Inform that frontend **and** logger should be restarted after modification - [ ] typo : valide => valid in english - [ ] check wrong type : add index to the error message - [ ] initVariableDir() : add comment on the why - [ ] generate Template message should only be writtend on time - [ ] addToChannel => addChannel (rename) - [ ] float / double => error, it's not the same type

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lin-midas-drivers/Epics_bridge#4