Code review #1

New Issue

2026-05-13T16:16:41+02:00

ponsin_h commented

2026-05-13 16:16:41 +02:00

README.md

expend ch name to channel name
name => generic need to be change for something more explicite

CMakeLists.txt

remove IOS support
remove libCom.so if possible

Generic_sfce.cpp:

l.24

Generic_conf.h

separate with comment name and constructed path

Generic.h

l.46 typo
l.9 typedef : comment the type for other futur use, and why order is important
l.15 not needed, describe the filename

Generic.cpp

review error, need to be way more explicite
~~- [ ] l.72 checking for all value : output should be initiated why epics value by default, if not able to read, default value should be 0.0~~ => not possible
std::get => use try catch, to get any error thrown if invalide or incoherent type with mepicsca. use PRETTY_FUNCTION and LINE for better error message
verify if int, short, long and int64t can use int mepicsca ... this might be a bug
hotlink -> send a command only if someone write it

Improvement :

type : detect wrong / unspecified type enterend in the type array
detect if some channel is not in input nor output
mepicsca : detect if connected, if not, do not spam the user about disconnected channel
default name for input and output should be pv name
puppet : try to see if epics have it's environment variable, because couldn't connect on http:mpc2752:8081/

README.md - [x] expend ch name to channel name - [x] name => generic need to be change for something more explicite CMakeLists.txt - [x] remove IOS support - [x] remove libCom.so if possible Generic_sfce.cpp: - [x] l.24 Generic_conf.h - [x] separate with comment name and constructed path Generic.h - [x] l.46 typo - [x] l.9 typedef : comment the type for other futur use, and why order is important - [x] l.15 not needed, describe the filename Generic.cpp - [x] review error, need to be way more explicite ~~- [ ] l.72 checking for all value : output should be initiated why epics value by default, if not able to read, default value should be 0.0~~ => not possible - [x] std::get => use try catch, to get any error thrown if invalide or incoherent type with mepicsca. use __PRETTY_FUNCTION__ and __LINE__ for better error message - [x] verify if int, short, long and int64t can use int mepicsca ... this might be a bug - [x] hotlink -> send a command only if someone write it Improvement : - [x] type : detect wrong / unspecified type enterend in the type array - [x] detect if some channel is not in input nor output - [x] mepicsca : detect if connected, if not, do not spam the user about disconnected channel - [x] default name for input and output should be pv name - [x] puppet : try to see if epics have it's environment variable, because couldn't connect on http:mpc2752:8081/

ponsin_h closed this issue

2026-05-19 08:04:49 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: lin-midas-drivers/Epics_bridge#1