lin-epics-modules/e_power_switch
0
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

code review #1

New Issue
Open
opened 2026-04-30 13:22:21 +02:00 by ponsin_h · 0 comments
ponsin_h commented 2026-04-30 13:22:21 +02:00
Owner
Copy Link
Copy Source

General

  • make it more integreable -> sinqdac
  • add makefile, that allow to install in the shared module (for everyone) : see SINQDAC

README.md

  • add manuel of both device
  • add manufacturer name
  • set and get are in the wrong place
  • only write macro for what is really importante (only for DEVICE)

Testing:

  • IC pipeline
  • post dummy (check if docker img support jvm)
  • add .gitea/workflow (check sinqdac) for auto testing att push

Substitution files

  • use $(DEVICE) everywhere

st.cmd

  • remove unnecessary require
  • comment http weird case
General - [x] make it more integreable -> sinqdac - [x] add makefile, that allow to install in the shared module (for everyone) : see SINQDAC README.md - [x] add manuel of both device - [x] add manufacturer name - [x] set and get are in the wrong place - [x] only write macro for what is really importante (only for DEVICE) Testing: - [ ] IC pipeline - [x] post dummy (check if docker img support jvm) - [ ] add .gitea/workflow (check sinqdac) for auto testing att push Substitution files - [x] use $(DEVICE) everywhere st.cmd - [x] remove unnecessary require - [x] comment http weird case
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
mathis_s (mathis_s) mueller_r4 (mueller_r4) plank_a (plank_a) schlienger_s (schlienger_s) soederqvist_a (soederqvist_a) wall_e (wall_e)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: lin-epics-modules/e_power_switch#1